[U-Boot] [Patch] Fix compiler warning vcxk
My new video driver vcxk produce a compiler warning.
I'm sorry about this.
This patch will
* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
Signed-off-by: Jens Scharsig esw@bus-elektronik.de ---
diff --git a/drivers/video/bus_vcxk.c b/drivers/video/bus_vcxk.c index b3b53e1..7726bb3 100644 --- a/drivers/video/bus_vcxk.c +++ b/drivers/video/bus_vcxk.c @@ -380,7 +380,6 @@ int vcxk_display_bitmap(ulong addr, int x, int y) unsigned long c_width; unsigned long c_height; unsigned char *dataptr; - unsigned char *lineptr;
bmp = (bmp_image_t *) addr; if ((bmp->header.signature[0] == 'B') &&
Jens Scharsig wrote:
My new video driver vcxk produce a compiler warning.
I'm sorry about this.
This patch will
- FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
Signed-off-by: Jens Scharsig esw@bus-elektronik.de
Applied to u-boot-video/master. Thanks.
Please note that comments to the patch should go below "---" line so that they do not appear in the commit message, e.g. in this case:
This patch will
* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
Your SOB --- Here is the place for comments which should not appear in the commit log, in this case this is:
"My new video driver vcxk produce a compiler warning.
I'm sorry about this."
Best regards, Anatolij
Anatolij Gustschin wrote:
Please note that comments to the patch should go below "---" line so that they do not appear in the commit message, e.g. in this case:
This patch will
- FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
Your SOB
Here is the place for comments which should not appear in the commit log, in this case this is:
"My new video driver vcxk produce a compiler warning.
I think the http://www.denx.de/wiki/U-Boot/Patches is a good place to describe such basic things. Especially for people who publish their first patch.
Best regard
Jens
Dear Jens Scharsig,
In message h4ka2d$mpo$1@ger.gmane.org you wrote:
My new video driver vcxk produce a compiler warning.
I'm sorry about this.
This patch will
- FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'
Signed-off-by: Jens Scharsig esw@bus-elektronik.de
Applied (after editing the commit message; hope this is OK).
Best regards,
Wolfgang Denk
participants (3)
-
Anatolij Gustschin -
Jens Scharsig -
Wolfgang Denk