[U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors.

This patch adds the SA1110 register definition for PXA2xx processors. I could only get my hands on a PXA27x developer's manual, but I'm assuming the register is available on previous generations as well. If not it should be moved into a CONFIG_PXA27X section.
Cheers, Thierry
---
include/asm-arm/arch-pxa/pxa-regs.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/asm-arm/arch-pxa/pxa-regs.h b/include/asm-arm/arch-pxa/pxa-regs.h index 9b4da3a..099db5a 100644 --- a/include/asm-arm/arch-pxa/pxa-regs.h +++ b/include/asm-arm/arch-pxa/pxa-regs.h @@ -2211,6 +2211,7 @@ typedef void (*ExcpHndlr) (void) ; #define MCIO1 __REG(0x4800003C) /* Card interface I/O Space Socket 1 Timing Configuration */ #define MDMRS __REG(0x48000040) /* MRS value to be written to SDRAM */ #define BOOT_DEF __REG(0x48000044) /* Read-Only Boot-Time Register. Contains BOOT_SEL and PKG_SEL */ +#define SA1110 __REG(0x48000064) /* Static Memory SA-1110 Compatibility Configuration Register */
#define MDREFR_K2FREE (1 << 25) /* SDRAM Free-Running Control */ #define MDREFR_K1FREE (1 << 24) /* SDRAM Free-Running Control */

In message 20071002051753.16402.86018.stgit@avionic-0027.adnet.avionic-design.de you wrote:
This patch adds the SA1110 register definition for PXA2xx processors. I could only get my hands on a PXA27x developer's manual, but I'm assuming the register is available on previous generations as well. If not it should be moved into a CONFIG_PXA27X section.
Who needs this register? Seems all existing U-Boot code can do without it?
Best regards,
Wolfgang Denk

* Wolfgang Denk wrote:
In message 20071002051753.16402.86018.stgit@avionic-0027.adnet.avionic-design.de you wrote:
This patch adds the SA1110 register definition for PXA2xx processors. I could only get my hands on a PXA27x developer's manual, but I'm assuming the register is available on previous generations as well. If not it should be moved into a CONFIG_PXA27X section.
Who needs this register? Seems all existing U-Boot code can do without it?
We use this register in some of our boards. I was planning to submit patches with the board-specific code sometime later so I thought it was a good idea to send this in before.
Best regards,
Wolfgang Denk
Cheers, Thierry

In message 20071002065111.GA27564@avionic-tr-basi.adnet.avionic-design.de you wrote:
Who needs this register? Seems all existing U-Boot code can do without it?
We use this register in some of our boards. I was planning to submit patches with the board-specific code sometime later so I thought it was a good idea to send this in before.
Please include it with the patches that use it, then.
I don't want to add unused code.
Best regards,
Wolfgang Denk
participants (2)
-
Thierry Reding
-
Wolfgang Denk