[U-Boot] tftp packet failure counter reset
I do large transfers via tftp, and since the timeout counter never resets, they often fail since the failures are counted throughout the entire transfer. By resetting the counter to 0 on a successful packet, this issue is fixed
tftp.c: } else { if (((TftpBlock - 1) % 10) == 0) { putc ('#'); } else if ((TftpBlock % (10 * HASHES_PER_LINE)) == 0) { puts ("\n\t "); } + //Reset timeout count since we received a good packet + TftpTimeoutCount = 0; }
if (TftpState == STATE_RRQ) _________________________________________________________________ Hotmail: Free, trusted and rich email service. http://clk.atdmt.com/GBL/go/171222984/direct/01/
Jeffery Palmer wrote:
I do large transfers via tftp, and since the timeout counter never resets, they often fail since the failures are counted throughout the entire transfer. By resetting the counter to 0 on a successful packet, this issue is fixed
tftp.c: } else { if (((TftpBlock - 1) % 10) == 0) { putc ('#'); } else if ((TftpBlock % (10 * HASHES_PER_LINE)) == 0) { puts ("\n\t "); }
//Reset timeout count since we received a good packetTftpTimeoutCount = 0; } if (TftpState == STATE_RRQ)
Please send a proper patch in plaintext with all the right bits and pieces.
regards, Ben
Patch is attached
Date: Tue, 22 Sep 2009 16:32:37 -0700 From: biggerbadderben@gmail.com To: jefferypalmer@hotmail.com CC: u-boot@lists.denx.de Subject: Re: [U-Boot] tftp packet failure counter reset
Jeffery Palmer wrote:
I do large transfers via tftp, and since the timeout counter never resets, they often fail since the failures are counted throughout the entire transfer. By resetting the counter to 0 on a successful packet, this issue is fixed
tftp.c: } else { if (((TftpBlock - 1) % 10) == 0) { putc ('#'); } else if ((TftpBlock % (10 * HASHES_PER_LINE)) == 0) { puts ("\n\t "); }
//Reset timeout count since we received a good packetTftpTimeoutCount = 0; } if (TftpState == STATE_RRQ)Please send a proper patch in plaintext with all the right bits and pieces.
regards, Ben
_________________________________________________________________ Bing brings you health info from trusted sources. http://www.bing.com/search?q=pet+allergy&form=MHEINA&publ=WLHMTAG&am...
On Wednesday 23 September 2009 10:23:38 Jeffery Palmer wrote:
From: biggerbadderben@gmail.com
Jeffery Palmer wrote:
I do large transfers via tftp, and since the timeout counter never resets, they often fail since the failures are counted throughout the entire transfer. By resetting the counter to 0 on a successful packet, this issue is fixed
Please send a proper patch in plaintext with all the right bits and pieces.
Patch is attached
he didnt say "attach the patch", he said "do it right". that means: - do not top post in your e-mails - use a proper changelog - include your s-o-b tag
if you dont know how to do these bits, then use `git commit` to do it for you: git commit -s -a -m 'tftp packet failure counter reset' -e <enter your changelog as a new paragraph> git format-patch HEAD^ -mike
participants (3)
-
Ben Warren -
Jeffery Palmer -
Mike Frysinger