[U-Boot] CREDITS for some old code

Hello,
I'm not usually this pedantic, but about 9 years ago I ported the CoLiLo boot loader to the ColdFire MCF5249 platform, and it appears as though some of my code has been assimilated into U-Boot. I recently came across my comments verbatim in the master branch! Please see lines 681-684 and 694-697 of arch/m68k/cpu/mcf52x2/cpu_init.c for an example. The "~Jeremy" is me...
It would be nice to have my name added to the CREDITS file if at all possible:
N: Jeremy C. Andrus E: jeremy@jeremya.com D: MCF5249 initialization code
Sorry for the out-of-the-blue request, but you can Google "Jeremy Andrus colilo" for some verification if you want ;-) http://marc.info/?l=uclinux-dev&m=105219912621419&w=1 http://www.nevis.columbia.edu/~chi/NCC/n3c/bootloader/colilo-HOWTO.html
Thanks for your consideration,
-Jeremy

Dear Jeremy,
In message CDEAAB86-94D1-402D-B6C7-E72A337A281C@jeremya.com you wrote:
I'm not usually this pedantic, but about 9 years ago I ported the CoLiLo boot loader to the ColdFire MCF5249 platform, and it appears as though some of my code has been assimilated into U-Boot. I recently came across my comments verbatim in the master branch!
This has nothing to do with pedantism; your request is perfectly right.
Please see lines 681-684 and 694-697 of arch/m68k/cpu/mcf52x2/cpu_init.c for an example. The "~Jeremy" is me...
Indeed.
It appears the respective code was added as commit 8c725b9 "Coldfire MCF5249 support added" by "stroese" = Stefan Roese.
Stefan, can you please comment and explain where exactly this code has been derived from?
It would be nice to have my name added to the CREDITS file if at all possible:
N: Jeremy C. Andrus E: jeremy@jeremya.com D: MCF5249 initialization code
Can you please submit a patch for this? Thanks!
Best regards,
Wolfgang Denk

Hi Wolfgang,
On 08/13/2012 12:20 PM, Wolfgang Denk wrote:
I'm not usually this pedantic, but about 9 years ago I ported the CoLiLo boot loader to the ColdFire MCF5249 platform, and it appears as though some of my code has been assimilated into U-Boot. I recently came across my comments verbatim in the master branch!
This has nothing to do with pedantism; your request is perfectly right.
Please see lines 681-684 and 694-697 of arch/m68k/cpu/mcf52x2/cpu_init.c for an example. The "~Jeremy" is me...
Indeed.
It appears the respective code was added as commit 8c725b9 "Coldfire MCF5249 support added" by "stroese" = Stefan Roese.
Stefan, can you please comment and explain where exactly this code has been derived from?
Hmmm, nearly 10 years ago... Not easy to remember. Especially since I changed workplace since then and I don't have access to the development resources from that time. But from what I do remember, the source is partly copied from the CoLiLo project. So Jeremy is correct.
Jeremy, I'm sorry that I didn't acknowledge your work while "borrowing" from your sources. Please send a patch to the list to add yourself to the CREDITS file.
Thanks.
Best regards, Stefan Roese
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
participants (3)
-
Jeremy Andrus
-
Stefan Roese
-
Wolfgang Denk