[U-Boot] [PATCH] sandbox: Correct operaion of 'reset' command

Currently 'reset' only works with the test device tree. When run without a device tree, or with the normal device tree, the following error is displayed:
Reset not supported on this platform
Fix the driver and the standard device tree to avoid this.
Signed-off-by: Simon Glass sjg@chromium.org Reported-by: Stephen Warren swarren@nvidia.com ---
arch/sandbox/dts/sandbox.dts | 4 ++++ drivers/misc/reset_sandbox.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts index 65b9125..08f72ac 100644 --- a/arch/sandbox/dts/sandbox.dts +++ b/arch/sandbox/dts/sandbox.dts @@ -153,6 +153,10 @@ }; };
+ reset@1 { + compatible = "sandbox,reset"; + }; + spi@0 { #address-cells = <1>; #size-cells = <0>; diff --git a/drivers/misc/reset_sandbox.c b/drivers/misc/reset_sandbox.c index 917121b..2691bb0 100644 --- a/drivers/misc/reset_sandbox.c +++ b/drivers/misc/reset_sandbox.c @@ -40,7 +40,7 @@ static int sandbox_reset_request(struct udevice *dev, enum reset_t type) * (see the U_BOOT_DEVICE() declaration below) should not do anything. * If we are that device, return an error. */ - if (gd->fdt_blob && dev->of_offset == -1) + if (state->fdt_fname && dev->of_offset == -1) return -ENODEV;
switch (type) {

On 10/03/2015 11:21 AM, Simon Glass wrote:
Currently 'reset' only works with the test device tree. When run without a device tree, or with the normal device tree, the following error is displayed:
Reset not supported on this platform
Fix the driver and the standard device tree to avoid this.
Tested-by: Stephen Warren swarren@wwwdotorg.org
Thanks!
participants (2)
-
Simon Glass
-
Stephen Warren