[regression] 2023.01 breaks u-boot-initial-env for aarch64
Hello,
When using v2023.01-rc4-49-g582e3c9fb23 for aarch64 (technically imx8mm-lpddr4-evk) I get following error:
| /bin/false) | cat u-boot-nodtb.bin dts/dt.dtb > u-boot-dtb.bin | cp u-boot-dtb.bin u-boot.bin | aarch64-oel-linux-objcopy --dump-section .rodata.default_environment=u-boot-initial-env env/common.o; sed --in-place -e 's/\x00/\x0A/g' u-boot-initial-env; sed --in-place -e '/^\s*$/d' u-boot-initial-env; sort --field-separator== -k1,1 --stable u-boot-initial-env -o u-boot-initial-env | aarch64-oel-linux-objcopy: env/common.o: can't dump section '.rodata.default_environment' - it does not exist: file format not recognized | sed: can't read u-boot-initial-env: No such file or directory
The very same works just fine with 2022.10 it works. I didn't investigate more yet.
On 1/6/23 19:44, Otavio Salvador wrote:
Hello,
When using v2023.01-rc4-49-g582e3c9fb23 for aarch64 (technically imx8mm-lpddr4-evk) I get following error:
| /bin/false) | cat u-boot-nodtb.bin dts/dt.dtb > u-boot-dtb.bin | cp u-boot-dtb.bin u-boot.bin | aarch64-oel-linux-objcopy --dump-section .rodata.default_environment=u-boot-initial-env env/common.o; sed --in-place -e 's/\x00/\x0A/g' u-boot-initial-env; sed --in-place -e '/^\s*$/d' u-boot-initial-env; sort --field-separator== -k1,1 --stable u-boot-initial-env -o u-boot-initial-env | aarch64-oel-linux-objcopy: env/common.o: can't dump section '.rodata.default_environment' - it does not exist: file format not recognized | sed: can't read u-boot-initial-env: No such file or directory
The very same works just fine with 2022.10 it works. I didn't investigate more yet.
Do you have LTO enabled?
Does 486aef08de ("u-boot-initial-env: rework make target") fix things?
--Sean
Hello Sean,
Em sex., 6 de jan. de 2023 às 22:59, Sean Anderson seanga2@gmail.com escreveu:
On 1/6/23 19:44, Otavio Salvador wrote:
The very same works just fine with 2022.10 it works. I didn't investigate more yet.
Do you have LTO enabled?
I didn't enable it explicitly.
Does 486aef08de ("u-boot-initial-env: rework make target") fix things?
Yes, this fixed it. @Tom Rini tom_rini@mentor.com please add this to v2023.01 release.
Thanks for the quick response.
Hi Otavio,
On Sat, Jan 7, 2023 at 10:22 AM Otavio Salvador otavio.salvador@ossystems.com.br wrote:
I didn't enable it explicitly.
I enable LTO in this commit: https://source.denx.de/u-boot/u-boot/-/commit/750d7ddf2c514949228d991e6dd4f7...
Does 486aef08de ("u-boot-initial-env: rework make target") fix things?
Yes, this fixed it. @Tom Rini tom_rini@mentor.com please add this to v2023.01 release.
Adding the correct Tom's email.
Thanks!
Em sáb., 7 de jan. de 2023 às 10:44, Fabio Estevam festevam@gmail.com escreveu:
Hi Otavio,
On Sat, Jan 7, 2023 at 10:22 AM Otavio Salvador otavio.salvador@ossystems.com.br wrote:
I didn't enable it explicitly.
I enable LTO in this commit:
https://source.denx.de/u-boot/u-boot/-/commit/750d7ddf2c514949228d991e6dd4f7...
Does 486aef08de ("u-boot-initial-env: rework make target") fix things?
Yes, this fixed it. @Tom Rini tom_rini@mentor.com please add this to v2023.01 release.
Adding the correct Tom's email.
On Sat, Jan 07, 2023 at 11:47:28AM -0300, Otavio Salvador wrote:
Thanks!
Em sáb., 7 de jan. de 2023 às 10:44, Fabio Estevam festevam@gmail.com escreveu:
Hi Otavio,
On Sat, Jan 7, 2023 at 10:22 AM Otavio Salvador otavio.salvador@ossystems.com.br wrote:
I didn't enable it explicitly.
I enable LTO in this commit:
https://source.denx.de/u-boot/u-boot/-/commit/750d7ddf2c514949228d991e6dd4f7...
Does 486aef08de ("u-boot-initial-env: rework make target") fix things?
Yes, this fixed it. @Tom Rini tom_rini@mentor.com please add this to v2023.01 release.
Adding the correct Tom's email.
LTO and u-boot-initial-env have never been compatible, until that rework of how we implement u-boot-initial-env. I really don't want to pull that in for the release (which is why I didn't, to start with). Please cherry-pick it as needed, thanks.
participants (4)
-
Fabio Estevam -
Otavio Salvador -
Sean Anderson -
Tom Rini