[U-Boot] [PATCH] x86: coreboot: delete unused coreboot/config.mk
HOSTCFLAGS_autoconf.mk.dep was added by commit 422322f but it has never been used.
Cc: Vadim Bendebury vbendeb@chromium.org Cc: Simon Glass sjg@chromium.org Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com ---
Hello Vadim, Simon.
I cannot understand what the hell this macro is used for.
Why HOSTCFLAGS_...? Why not CFLAGS_... ?
Can you explain?
board/chromebook-x86/coreboot/config.mk | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 board/chromebook-x86/coreboot/config.mk
diff --git a/board/chromebook-x86/coreboot/config.mk b/board/chromebook-x86/coreboot/config.mk deleted file mode 100644 index 0c05dd0..0000000 --- a/board/chromebook-x86/coreboot/config.mk +++ /dev/null @@ -1,7 +0,0 @@ -# -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# SPDX-License-Identifier: GPL-2.0 BSD-3-Clause -# - -HOSTCFLAGS_autoconf.mk.dep = -Wno-variadic-macros
On Mon, Feb 24, 2014 at 09:36:35PM +0900, Masahiro Yamada wrote:
HOSTCFLAGS_autoconf.mk.dep was added by commit 422322f but it has never been used.
Cc: Vadim Bendebury vbendeb@chromium.org Cc: Simon Glass sjg@chromium.org Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com
Applied to u-boot/master, thanks!
Hi Masahiro,
On 24 February 2014 05:36, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
HOSTCFLAGS_autoconf.mk.dep was added by commit 422322f but it has never been used.
Cc: Vadim Bendebury vbendeb@chromium.org Cc: Simon Glass sjg@chromium.org Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com
Hello Vadim, Simon.
I cannot understand what the hell this macro is used for.
Why HOSTCFLAGS_...? Why not CFLAGS_... ?
Can you explain?
No I can't. I don't think this makes any sense.
Acked-by: Simon Glass sjg@chromium.org
Regards, Simon
board/chromebook-x86/coreboot/config.mk | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 board/chromebook-x86/coreboot/config.mk
diff --git a/board/chromebook-x86/coreboot/config.mk b/board/chromebook-x86/coreboot/config.mk deleted file mode 100644 index 0c05dd0..0000000 --- a/board/chromebook-x86/coreboot/config.mk +++ /dev/null @@ -1,7 +0,0 @@ -# -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# SPDX-License-Identifier: GPL-2.0 BSD-3-Clause -#
-HOSTCFLAGS_autoconf.mk.dep = -Wno-variadic-macros
1.8.3.2
On Tue, Feb 25, 2014 at 3:43 PM, Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 24 February 2014 05:36, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
HOSTCFLAGS_autoconf.mk.dep was added by commit 422322f but it has never been used.
Cc: Vadim Bendebury vbendeb@chromium.org Cc: Simon Glass sjg@chromium.org Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com
Hello Vadim, Simon.
I cannot understand what the hell this macro is used for.
Why HOSTCFLAGS_...? Why not CFLAGS_... ?
Can you explain?
No I can't. I don't think this makes any sense.
this all is ancient history by now, but I think this made sense at the time, it was affecting compilation options for coreboot.
--vb
Acked-by: Simon Glass sjg@chromium.org
Regards, Simon
board/chromebook-x86/coreboot/config.mk | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 board/chromebook-x86/coreboot/config.mk
diff --git a/board/chromebook-x86/coreboot/config.mk b/board/chromebook-x86/coreboot/config.mk deleted file mode 100644 index 0c05dd0..0000000 --- a/board/chromebook-x86/coreboot/config.mk +++ /dev/null @@ -1,7 +0,0 @@ -# -# Copyright (c) 2011 The Chromium OS Authors. All rights reserved. -# -# SPDX-License-Identifier: GPL-2.0 BSD-3-Clause -#
-HOSTCFLAGS_autoconf.mk.dep = -Wno-variadic-macros
1.8.3.2
participants (4)
-
Masahiro Yamada -
Simon Glass -
Tom Rini -
Vadim Bendebury