Hi Tom,
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10771
The following changes since commit 6146cd62aedc4849fec66f10ab0aa57f1dc64b8e:
Merge branch '2022-01-24-assorted-updates' (2022-01-25 08:01:43 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-26jan22
for you to fetch changes up to 2d2384bbaff0ab84c868b553c74048a5f6acc9e3:
tools: mkimage: Show where signatures/keys are written (2022-01-26 08:50:44 -0700)
---------------------------------------------------------------- acpi refactoring to allow non-x86 use binman support for bintools (binary tools) minor tools improvements in preparation for FDT signing various minor fixes and improvements
---------------------------------------------------------------- Heiko Thiery (1): binman: doc: fix typo for u-boot-tpl
Heinrich Schuchardt (2): sandbox: sandbox_serial_pending depends on DM_VIDEO sandbox: eth-raw: fix building with musl library
Patrice Chotard (1): dm: Fix OF_BAD_ADDR definition
Rasmus Villemoes (1): introduce CONFIG_DEVICE_TREE_INCLUDES
Sean Anderson (1): usb: Use the first available device for ehci_gadget
Simon Glass (83): x86: Allow any arch to generate ACPI tables x86: Move the acpi table to generic global_data arm: Allow supporting ACPI-table generation x86: Tidy up use of CONFIG_ACPIGEN sandbox: Allow building with GENERATE_ACPI_TABLE efi: Correct call to write_acpi_tables() efi: Correct address handling with ACPI tables acpi: Use finer-grained control of ACPI-table generation acpi: Allow include files within the board directory acpi: Move acpi_fill_header() to the generic header acpi: Add a table start acpi: Add a linker list for ACPI tables x86: acpi: Split out context creation from base tables x86: Use the ACPI table writer x86: Move base tables to a writer function x86: Move FACS table to a writer function x86: Move DSDT table to a writer function x86: Move GNVS table to a writer function x86: Move FADT table to a writer function x86: Move FACP table into separate functions x86: Move SSDT table to a writer function x86: Move TPM2 table to a writer function x86: Move MADT table to a writer function x86: Move TCPA table to a writer function x86: Move CSRT table to a writer function x86: acpi: Update acpi_fill_csrt() to use acpi_ctx x86: Move device-specific ACPI tables to a writer function x86: Move acpi_get_rsdp_addr() ACPI tables to the writer acpi: Collect tables in the acpi_item list acpi: Tidy up the item list acpi: Tidy up the table list doc: Add usage information for the acpi command acpi: Add some tables needed by ARM devices acpi: Add myself as maintainer Makefile: Fake external blobs by default with binman binman: Tweak elf tests for a toolchain change mkimage: Show the external-offset error binman: Expand the external FIT test a little patman: Allow running a tool and returning the full result buildman: Move the download function to tools patman: Tidy up the download function a little patman: Add a function to find a tool on the path binman: Drop the image name from the fake-blob message binman: Allow faked blobs in blob-ext-list binman: Correct path for fip_util binman: Add installation instructions binman: Add support for bintools binman: Plumb in support for bintools binman: Add tests for bintool binman: Add a bintool implementation for cbfstool binman: Add a bintool implementation for fiptool binman: Add a bintool implementation for futility binman: Add a bintool implementation for ifwitool binman: Add a bintool implementation for mkimage binman: Enable bintool tests including cmdline processing binman: Convert to using the CBFS bintool binman: Convert to using the FIP bintool binman: Convert to using the futility bintool binman: Convert to using the ifwitool bintool binman: Convert to using the mkimage bintool binman: Move compression into binman binman: Tidy up pylint warnings in comp_util binman: Add a bintool implementation for lz4 binman: Convert to using the lz4 bintool binman: Add a bintool implementation for lzma_alone binman: Convert to using the lzma_alone bintool binman: Plumb in support for missing bintools binman: Complete test coverage of comp_util binman: Add a command to generate bintool docs binman: Add documentation for bintools binman: Document the __bss_size symbol error rsa: Add debugging for failure cases fit_check_sign: Update help to mention the key is in a dtb tools: Move copyfile() into a common file tools: Avoid leaving extra data at the end of copied files tools: Improve comments in signing functions tools: Drop unused name in image-host tools: Avoid confusion between keys and signatures tools: Tidy up argument order in fit_config_check_sig() tools: Pass the key blob around image: Return destination node for add_verify_data() method tools: Pass public-key node through to caller tools: mkimage: Show where signatures/keys are written
MAINTAINERS | 6 + Makefile | 2 +- arch/Kconfig | 6 +- arch/sandbox/cpu/eth-raw-os.c | 2 + arch/sandbox/include/asm/acpi_table.h | 2 + arch/sandbox/include/asm/global_data.h | 1 - arch/sandbox/include/asm/tables.h | 0 arch/x86/Kconfig | 9 - arch/x86/cpu/apollolake/acpi.c | 17 +- arch/x86/cpu/baytrail/acpi.c | 27 +- arch/x86/cpu/quark/acpi.c | 27 +- arch/x86/cpu/tangier/acpi.c | 34 ++- arch/x86/include/asm/acpi_table.h | 4 - arch/x86/include/asm/global_data.h | 1 - arch/x86/lib/Makefile | 2 +- arch/x86/lib/acpi_table.c | 374 +++++++------------------- boot/image-fit-sig.c | 151 ++++++++--- boot/image-fit.c | 12 +- cmd/acpi.c | 13 +- common/spl/spl_fit.c | 3 +- configs/cherryhill_defconfig | 1 + configs/chromebook_link64_defconfig | 1 + configs/chromebook_link_defconfig | 1 + configs/chromebook_samus_tpl_defconfig | 1 + configs/coreboot64_defconfig | 1 + configs/coreboot_defconfig | 1 + configs/crownbay_defconfig | 1 + configs/efi-x86_payload32_defconfig | 1 + configs/efi-x86_payload64_defconfig | 1 + configs/slimbootloader_defconfig | 1 + configs/tools-only_defconfig | 1 + doc/develop/devicetree/control.rst | 18 ++ doc/develop/package/bintools.rst | 1 + doc/usage/acpi.rst | 235 +++++++++++++++++ doc/usage/index.rst | 1 + drivers/core/acpi.c | 70 +++-- drivers/misc/qfw.c | 3 +- drivers/serial/sandbox.c | 2 +- drivers/usb/host/usb-uclass.c | 4 +- dts/Kconfig | 9 + include/acpi/acpi_table.h | 235 ++++++++++++++++- include/asm-generic/global_data.h | 8 + include/dm/acpi.h | 110 ++++++++ include/fdtdec.h | 5 +- include/image.h | 51 +++- include/u-boot/ecdsa.h | 5 +- include/u-boot/rsa.h | 5 +- lib/Kconfig | 18 ++ lib/Makefile | 2 +- lib/acpi/Makefile | 23 +- lib/acpi/acpi_table.c | 82 ------ lib/acpi/acpi_writer.c | 131 +++++++++ lib/acpi/base.c | 94 +++++++ lib/acpi/csrt.c | 49 ++++ lib/acpi/dsdt.c | 55 ++++ lib/acpi/facs.c | 35 +++ lib/acpi/ssdt.c | 49 ++++ lib/ecdsa/ecdsa-libcrypto.c | 4 +- lib/efi_loader/efi_acpi.c | 5 +- lib/rsa/rsa-sign.c | 5 +- lib/rsa/rsa-verify.c | 13 +- scripts/Makefile.lib | 6 +- test/dm/acpi.c | 79 ++++-- test/dm/ofnode.c | 2 +- test/dm/pci.c | 4 +- test/dm/test-fdt.c | 2 +- tools/binman/binman.rst | 129 ++++++++- tools/binman/bintool.py | 466 +++++++++++++++++++++++++++++++++ tools/binman/bintool_test.py | 353 +++++++++++++++++++++++++ tools/binman/bintools.rst | 115 ++++++++ tools/binman/btool/_testing.py | 36 +++ tools/binman/btool/cbfstool.py | 219 ++++++++++++++++ tools/binman/btool/fiptool.py | 123 +++++++++ tools/binman/btool/futility.py | 178 +++++++++++++ tools/binman/btool/ifwitool.py | 166 ++++++++++++ tools/binman/btool/lz4.py | 140 ++++++++++ tools/binman/btool/lzma_alone.py | 126 +++++++++ tools/binman/btool/mkimage.py | 80 ++++++ tools/binman/cbfs_util.py | 33 +-- tools/binman/cbfs_util_test.py | 59 ++--- tools/binman/cmdline.py | 12 + tools/binman/comp_util.py | 76 ++++++ tools/binman/control.py | 50 +++- tools/binman/elf_test.py | 8 +- tools/binman/entry.py | 47 +++- tools/binman/etype/blob_ext_list.py | 1 + tools/binman/etype/fit.py | 20 +- tools/binman/etype/gbb.py | 37 +-- tools/binman/etype/intel_ifwi.py | 25 +- tools/binman/etype/mkimage.py | 13 +- tools/binman/etype/section.py | 19 +- tools/binman/etype/vblock.py | 32 ++- tools/binman/fip_util.py | 26 -- tools/binman/fip_util_test.py | 25 +- tools/binman/ftest.py | 163 +++++++++++- tools/binman/image.py | 14 + tools/binman/main.py | 11 +- tools/binman/test/162_fit_external.dts | 2 +- tools/binman/test/218_blob_ext_list_fake.dts | 14 + tools/buildman/toolchain.py | 46 +--- tools/fdt_host.h | 8 + tools/fit_check_sign.c | 4 +- tools/fit_common.c | 69 +++++ tools/fit_common.h | 23 ++ tools/fit_image.c | 64 +---- tools/image-host.c | 155 ++++++++--- tools/imagetool.h | 3 + tools/mkimage.c | 4 + tools/patman/tools.py | 238 +++++++++-------- 109 files changed, 4567 insertions(+), 989 deletions(-) create mode 100644 arch/sandbox/include/asm/tables.h create mode 120000 doc/develop/package/bintools.rst create mode 100644 doc/usage/acpi.rst create mode 100644 lib/acpi/acpi_writer.c create mode 100644 lib/acpi/base.c create mode 100644 lib/acpi/csrt.c create mode 100644 lib/acpi/dsdt.c create mode 100644 lib/acpi/facs.c create mode 100644 lib/acpi/ssdt.c create mode 100644 tools/binman/bintool.py create mode 100644 tools/binman/bintool_test.py create mode 100644 tools/binman/bintools.rst create mode 100644 tools/binman/btool/_testing.py create mode 100644 tools/binman/btool/cbfstool.py create mode 100644 tools/binman/btool/fiptool.py create mode 100644 tools/binman/btool/futility.py create mode 100644 tools/binman/btool/ifwitool.py create mode 100644 tools/binman/btool/lz4.py create mode 100644 tools/binman/btool/lzma_alone.py create mode 100644 tools/binman/btool/mkimage.py create mode 100644 tools/binman/comp_util.py create mode 100644 tools/binman/test/218_blob_ext_list_fake.dts
Regards, Simon
On Wed, Jan 26, 2022 at 08:35:43PM -0700, Simon Glass wrote:
Hi Tom,
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10771
The following changes since commit 6146cd62aedc4849fec66f10ab0aa57f1dc64b8e:
Merge branch '2022-01-24-assorted-updates' (2022-01-25 08:01:43 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-26jan22
for you to fetch changes up to 2d2384bbaff0ab84c868b553c74048a5f6acc9e3:
tools: mkimage: Show where signatures/keys are written (2022-01-26 08:50:44 -0700)
I'm going to push back on this slightly. I ran "make pylint" (which yes, is new) locally, and it complains about needing to update scripts/pylint.base. Did that, and here's the less than obvious to me results:
diff --git a/scripts/pylint.base b/scripts/pylint.base index cefdc2355506..f5a045a384a9 100644 --- a/scripts/pylint.base +++ b/scripts/pylint.base @@ -1,71 +1,105 @@ +0.00 patman.checkpatch +1.43 buildman.test +1.71 buildman.builder +10.00 binman.fmap_util +3.12 rkmux +3.25 patman.control +4.15 buildman.board +4.48 binman.main +4.50 dtoc.fdt_util +4.69 patman.tout +4.74 patman.commit +4.86 binman.setup +5.00 binman.state +5.00 dtoc.src_scan +5.00 patman.status +5.62 patman.main +5.89 patman.setup +6.16 patman.settings +6.17 buildman.toolchain +6.44 concurrencytest +6.47 patman.gitutil +6.67 +6.67 patman.series +6.70 dtoc.main +6.71 endian-swap +6.81 patman.test_util +6.88 binman.ftest +6.89 patman.tools +6.90 rmboard +6.91 buildman.builderthread +6.96 dtoc.test_src_scan +7.05 patman.test_checkpatch +7.10 binman.image_test +7.18 buildman.kconfiglib +7.25 moveconfig +7.26 dtoc.dtb_platdata +7.39 buildman.cmdline +7.45 binman.image +7.49 buildman.main +7.56 patman.func_test +7.76 zynqmp_pm_cfg_obj_convert +7.78 dtoc.setup +7.82 buildman.bsettings +7.90 dtoc.fdt +7.95 microcode-tool +8.04 patman.command +8.10 buildman.func_test +8.14 patman.cros_subprocess +8.14 patman.get_maintainer +8.23 patman.patchstream +8.32 patman +8.56 dtoc.test_fdt +8.62 patman.terminal +8.91 dtoc.test_dtoc +9.04 buildman.control +9.11 patman.project +9.29 genboardscfg +9.43 efivar _testing 0.83 +_testing 6.09 atf_bl31 -6.00 atf_fip 0.29 -binman.cbfs_util 8.38 -binman.cbfs_util_test 9.30 -binman.cmdline 9.09 -binman.control 4.92 +binman.bintool 8.59 +binman.bintool_test 9.87 +binman.cbfs_util 8.46 +binman.cbfs_util_test 9.38 +binman.cmdline 9.03 +binman.comp_util 6.88 +binman.control 5.01 binman.elf 6.73 binman.elf_test 5.41 -binman.entry 3.38 +binman.entry 3.36 binman.entry_test 5.34 binman.fdt_test 3.23 -binman.fip_util 9.86 -binman.fip_util_test 9.75 -binman.fmap_util 6.88 -binman.ftest 7.46 -binman.image 7.05 -binman.image_test 4.48 -binman.main 5.00 -binman.setup 5.00 -binman.state 4.15 +binman.fip_util 9.85 blob -1.58 blob_dtb -10.00 blob_ext -19.09 -blob_ext_list -0.32 +blob_ext_list 0.00 blob_named_by_arg -7.78 blob_phase -5.00 -buildman.board 7.82 -buildman.bsettings 1.71 -buildman.builder 6.91 -buildman.builderthread 7.39 -buildman.cmdline 9.04 -buildman.control 8.10 -buildman.func_test 7.18 -buildman.kconfiglib 7.49 -buildman.main 1.43 -buildman.test 6.17 -buildman.toolchain 6.55 capsule_defs 5.00 cbfs -1.44 +cbfstool 7.83 collection 2.67 -concurrencytest 7.26 conftest -3.29 conftest 1.88 conftest 5.13 conftest 6.56 cros_ec_rw -6.00 defs 6.67 -dtoc.dtb_platdata 7.90 -dtoc.fdt 4.50 -dtoc.fdt_util 6.70 -dtoc.main 7.78 -dtoc.setup 5.00 -dtoc.src_scan 8.91 -dtoc.test_dtoc 8.56 -dtoc.test_fdt 6.96 -dtoc.test_src_scan 9.43 -efivar 6.71 -endian-swap 9.29 fdtmap -3.28 files -7.43 fill -6.43 -fit 5.32 +fiptool 7.62 +fit 5.26 fmap -0.29 fstest_defs 8.33 fstest_helpers 4.29 -gbb -0.30 -genboardscfg 7.95 +futility 7.39 +gbb 0.83 +ifwitool 3.81 image_header 5.77 intel_cmc -12.50 intel_descriptor 4.62 @@ -75,43 +109,21 @@ intel_fsp -12.50 intel_fsp_m -12.50 intel_fsp_s -12.50 intel_fsp_t -12.50 -intel_ifwi 2.71 +intel_ifwi 2.88 intel_me -12.50 intel_mrc -10.00 intel_refcode -10.00 intel_vbt -12.50 intel_vga -12.50 -microcode-tool 7.25 -mkimage 2.57 -moveconfig 8.32 +lz4 6.30 +lzma_alone 6.97 +mkimage 2.31 +mkimage 7.86 multiplexed_log 7.49 opensbi -6.00 -patman 0.00 -patman.checkpatch 8.04 -patman.command 4.74 -patman.commit 3.25 -patman.control 8.14 -patman.cros_subprocess 7.56 -patman.func_test 8.14 -patman.get_maintainer 6.47 -patman.gitutil 5.62 -patman.main 8.23 -patman.patchstream 9.11 -patman.project 6.67 -patman.series 6.16 -patman.settings 5.89 -patman.setup 5.00 -patman.status 8.62 -patman.terminal 7.05 -patman.test_checkpatch 6.81 -patman.test_util 6.89 -patman.tools 4.31 -patman.tout 3.12 powerpc_mpc85xx_bootpg_resetvec -10.00 -rkmux 6.90 -rmboard 7.76 scp -6.00 -section 4.68 +section 4.56 sqfs_common 8.41 test 8.18 test_000_version 7.50 @@ -203,7 +215,7 @@ u_boot_tpl_with_ucode_ptr -20.83 u_boot_ucode 1.52 u_boot_utils 6.94 u_boot_with_ucode_ptr -0.71 -vblock -1.61 +vblock 0.27 vboot_evil 8.95 vboot_forge 9.22 x86_reset16 -15.71 @@ -212,4 +224,3 @@ x86_reset16_tpl -15.71 x86_start16 -15.71 x86_start16_spl -15.71 x86_start16_tpl -15.71 -zynqmp_pm_cfg_obj_convert 6.67
Entries like "score name" rather than "name score" are odd, why did that happen? Also there's at least a few entries where the score decreased, but I assume that's because of code removal. Can you interpret the above and tell me what's going on, and that it makes sense to you at least? And, as a problem, re-running "make pylint" with that base file then fails with awk-spew related to "score name" and not "name score" lines.
Hi Tom,
On Thu, 27 Jan 2022 at 10:31, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 26, 2022 at 08:35:43PM -0700, Simon Glass wrote:
Hi Tom,
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10771
The following changes since commit 6146cd62aedc4849fec66f10ab0aa57f1dc64b8e:
Merge branch '2022-01-24-assorted-updates' (2022-01-25 08:01:43 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-26jan22
for you to fetch changes up to 2d2384bbaff0ab84c868b553c74048a5f6acc9e3:
tools: mkimage: Show where signatures/keys are written (2022-01-26 08:50:44 -0700)
I'm going to push back on this slightly. I ran "make pylint" (which yes, is new) locally, and it complains about needing to update scripts/pylint.base. Did that, and here's the less than obvious to me results:
diff --git a/scripts/pylint.base b/scripts/pylint.base index cefdc2355506..f5a045a384a9 100644 --- a/scripts/pylint.base +++ b/scripts/pylint.base @@ -1,71 +1,105 @@ +0.00 patman.checkpatch +1.43 buildman.test +1.71 buildman.builder +10.00 binman.fmap_util +3.12 rkmux +3.25 patman.control +4.15 buildman.board +4.48 binman.main +4.50 dtoc.fdt_util +4.69 patman.tout +4.74 patman.commit +4.86 binman.setup +5.00 binman.state +5.00 dtoc.src_scan +5.00 patman.status +5.62 patman.main +5.89 patman.setup +6.16 patman.settings +6.17 buildman.toolchain +6.44 concurrencytest +6.47 patman.gitutil +6.67 +6.67 patman.series +6.70 dtoc.main +6.71 endian-swap +6.81 patman.test_util +6.88 binman.ftest +6.89 patman.tools +6.90 rmboard +6.91 buildman.builderthread +6.96 dtoc.test_src_scan +7.05 patman.test_checkpatch +7.10 binman.image_test +7.18 buildman.kconfiglib +7.25 moveconfig +7.26 dtoc.dtb_platdata +7.39 buildman.cmdline +7.45 binman.image +7.49 buildman.main +7.56 patman.func_test +7.76 zynqmp_pm_cfg_obj_convert +7.78 dtoc.setup +7.82 buildman.bsettings +7.90 dtoc.fdt +7.95 microcode-tool +8.04 patman.command +8.10 buildman.func_test +8.14 patman.cros_subprocess +8.14 patman.get_maintainer +8.23 patman.patchstream +8.32 patman +8.56 dtoc.test_fdt +8.62 patman.terminal +8.91 dtoc.test_dtoc +9.04 buildman.control +9.11 patman.project +9.29 genboardscfg +9.43 efivar _testing 0.83 +_testing 6.09 atf_bl31 -6.00 atf_fip 0.29 -binman.cbfs_util 8.38 -binman.cbfs_util_test 9.30 -binman.cmdline 9.09 -binman.control 4.92 +binman.bintool 8.59 +binman.bintool_test 9.87 +binman.cbfs_util 8.46 +binman.cbfs_util_test 9.38 +binman.cmdline 9.03 +binman.comp_util 6.88 +binman.control 5.01 binman.elf 6.73 binman.elf_test 5.41 -binman.entry 3.38 +binman.entry 3.36 binman.entry_test 5.34 binman.fdt_test 3.23 -binman.fip_util 9.86 -binman.fip_util_test 9.75 -binman.fmap_util 6.88 -binman.ftest 7.46 -binman.image 7.05 -binman.image_test 4.48 -binman.main 5.00 -binman.setup 5.00 -binman.state 4.15 +binman.fip_util 9.85 blob -1.58 blob_dtb -10.00 blob_ext -19.09 -blob_ext_list -0.32 +blob_ext_list 0.00 blob_named_by_arg -7.78 blob_phase -5.00 -buildman.board 7.82 -buildman.bsettings 1.71 -buildman.builder 6.91 -buildman.builderthread 7.39 -buildman.cmdline 9.04 -buildman.control 8.10 -buildman.func_test 7.18 -buildman.kconfiglib 7.49 -buildman.main 1.43 -buildman.test 6.17 -buildman.toolchain 6.55 capsule_defs 5.00 cbfs -1.44 +cbfstool 7.83 collection 2.67 -concurrencytest 7.26 conftest -3.29 conftest 1.88 conftest 5.13 conftest 6.56 cros_ec_rw -6.00 defs 6.67 -dtoc.dtb_platdata 7.90 -dtoc.fdt 4.50 -dtoc.fdt_util 6.70 -dtoc.main 7.78 -dtoc.setup 5.00 -dtoc.src_scan 8.91 -dtoc.test_dtoc 8.56 -dtoc.test_fdt 6.96 -dtoc.test_src_scan 9.43 -efivar 6.71 -endian-swap 9.29 fdtmap -3.28 files -7.43 fill -6.43 -fit 5.32 +fiptool 7.62 +fit 5.26 fmap -0.29 fstest_defs 8.33 fstest_helpers 4.29 -gbb -0.30 -genboardscfg 7.95 +futility 7.39 +gbb 0.83 +ifwitool 3.81 image_header 5.77 intel_cmc -12.50 intel_descriptor 4.62 @@ -75,43 +109,21 @@ intel_fsp -12.50 intel_fsp_m -12.50 intel_fsp_s -12.50 intel_fsp_t -12.50 -intel_ifwi 2.71 +intel_ifwi 2.88 intel_me -12.50 intel_mrc -10.00 intel_refcode -10.00 intel_vbt -12.50 intel_vga -12.50 -microcode-tool 7.25 -mkimage 2.57 -moveconfig 8.32 +lz4 6.30 +lzma_alone 6.97 +mkimage 2.31 +mkimage 7.86 multiplexed_log 7.49 opensbi -6.00 -patman 0.00 -patman.checkpatch 8.04 -patman.command 4.74 -patman.commit 3.25 -patman.control 8.14 -patman.cros_subprocess 7.56 -patman.func_test 8.14 -patman.get_maintainer 6.47 -patman.gitutil 5.62 -patman.main 8.23 -patman.patchstream 9.11 -patman.project 6.67 -patman.series 6.16 -patman.settings 5.89 -patman.setup 5.00 -patman.status 8.62 -patman.terminal 7.05 -patman.test_checkpatch 6.81 -patman.test_util 6.89 -patman.tools 4.31 -patman.tout 3.12 powerpc_mpc85xx_bootpg_resetvec -10.00 -rkmux 6.90 -rmboard 7.76 scp -6.00 -section 4.68 +section 4.56 sqfs_common 8.41 test 8.18 test_000_version 7.50 @@ -203,7 +215,7 @@ u_boot_tpl_with_ucode_ptr -20.83 u_boot_ucode 1.52 u_boot_utils 6.94 u_boot_with_ucode_ptr -0.71 -vblock -1.61 +vblock 0.27 vboot_evil 8.95 vboot_forge 9.22 x86_reset16 -15.71 @@ -212,4 +224,3 @@ x86_reset16_tpl -15.71 x86_start16 -15.71 x86_start16_spl -15.71 x86_start16_tpl -15.71 -zynqmp_pm_cfg_obj_convert 6.67
Entries like "score name" rather than "name score" are odd, why did that happen? Also there's at least a few entries where the score decreased, but I assume that's because of code removal. Can you interpret the above and tell me what's going on, and that it makes sense to you at least? And, as a problem, re-running "make pylint" with that base file then fails with awk-spew related to "score name" and not "name score" lines.
It's because one of the lines doesn't have a filename and everything gets out of sync:
... 6.51 patman.tools 6.55 buildman.builderthread 6.67 6.67 binman.ftest 6.71 endian-swap ...
I'd suggest going ahead with the PR and I can dig into it at the weekend. I was trying to do everything in the makefile but it is possible I was too ambitious and we might need a tool.
As you say, this is not part of CI yet.
Regards, Simon
On Thu, Jan 27, 2022 at 12:09:29PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 27 Jan 2022 at 10:31, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 26, 2022 at 08:35:43PM -0700, Simon Glass wrote:
Hi Tom,
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10771
The following changes since commit 6146cd62aedc4849fec66f10ab0aa57f1dc64b8e:
Merge branch '2022-01-24-assorted-updates' (2022-01-25 08:01:43 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-26jan22
for you to fetch changes up to 2d2384bbaff0ab84c868b553c74048a5f6acc9e3:
tools: mkimage: Show where signatures/keys are written (2022-01-26 08:50:44 -0700)
I'm going to push back on this slightly. I ran "make pylint" (which yes, is new) locally, and it complains about needing to update scripts/pylint.base. Did that, and here's the less than obvious to me results:
diff --git a/scripts/pylint.base b/scripts/pylint.base index cefdc2355506..f5a045a384a9 100644 --- a/scripts/pylint.base +++ b/scripts/pylint.base @@ -1,71 +1,105 @@ +0.00 patman.checkpatch +1.43 buildman.test +1.71 buildman.builder +10.00 binman.fmap_util +3.12 rkmux +3.25 patman.control +4.15 buildman.board +4.48 binman.main +4.50 dtoc.fdt_util +4.69 patman.tout +4.74 patman.commit +4.86 binman.setup +5.00 binman.state +5.00 dtoc.src_scan +5.00 patman.status +5.62 patman.main +5.89 patman.setup +6.16 patman.settings +6.17 buildman.toolchain +6.44 concurrencytest +6.47 patman.gitutil +6.67 +6.67 patman.series +6.70 dtoc.main +6.71 endian-swap +6.81 patman.test_util +6.88 binman.ftest +6.89 patman.tools +6.90 rmboard +6.91 buildman.builderthread +6.96 dtoc.test_src_scan +7.05 patman.test_checkpatch +7.10 binman.image_test +7.18 buildman.kconfiglib +7.25 moveconfig +7.26 dtoc.dtb_platdata +7.39 buildman.cmdline +7.45 binman.image +7.49 buildman.main +7.56 patman.func_test +7.76 zynqmp_pm_cfg_obj_convert +7.78 dtoc.setup +7.82 buildman.bsettings +7.90 dtoc.fdt +7.95 microcode-tool +8.04 patman.command +8.10 buildman.func_test +8.14 patman.cros_subprocess +8.14 patman.get_maintainer +8.23 patman.patchstream +8.32 patman +8.56 dtoc.test_fdt +8.62 patman.terminal +8.91 dtoc.test_dtoc +9.04 buildman.control +9.11 patman.project +9.29 genboardscfg +9.43 efivar _testing 0.83 +_testing 6.09 atf_bl31 -6.00 atf_fip 0.29 -binman.cbfs_util 8.38 -binman.cbfs_util_test 9.30 -binman.cmdline 9.09 -binman.control 4.92 +binman.bintool 8.59 +binman.bintool_test 9.87 +binman.cbfs_util 8.46 +binman.cbfs_util_test 9.38 +binman.cmdline 9.03 +binman.comp_util 6.88 +binman.control 5.01 binman.elf 6.73 binman.elf_test 5.41 -binman.entry 3.38 +binman.entry 3.36 binman.entry_test 5.34 binman.fdt_test 3.23 -binman.fip_util 9.86 -binman.fip_util_test 9.75 -binman.fmap_util 6.88 -binman.ftest 7.46 -binman.image 7.05 -binman.image_test 4.48 -binman.main 5.00 -binman.setup 5.00 -binman.state 4.15 +binman.fip_util 9.85 blob -1.58 blob_dtb -10.00 blob_ext -19.09 -blob_ext_list -0.32 +blob_ext_list 0.00 blob_named_by_arg -7.78 blob_phase -5.00 -buildman.board 7.82 -buildman.bsettings 1.71 -buildman.builder 6.91 -buildman.builderthread 7.39 -buildman.cmdline 9.04 -buildman.control 8.10 -buildman.func_test 7.18 -buildman.kconfiglib 7.49 -buildman.main 1.43 -buildman.test 6.17 -buildman.toolchain 6.55 capsule_defs 5.00 cbfs -1.44 +cbfstool 7.83 collection 2.67 -concurrencytest 7.26 conftest -3.29 conftest 1.88 conftest 5.13 conftest 6.56 cros_ec_rw -6.00 defs 6.67 -dtoc.dtb_platdata 7.90 -dtoc.fdt 4.50 -dtoc.fdt_util 6.70 -dtoc.main 7.78 -dtoc.setup 5.00 -dtoc.src_scan 8.91 -dtoc.test_dtoc 8.56 -dtoc.test_fdt 6.96 -dtoc.test_src_scan 9.43 -efivar 6.71 -endian-swap 9.29 fdtmap -3.28 files -7.43 fill -6.43 -fit 5.32 +fiptool 7.62 +fit 5.26 fmap -0.29 fstest_defs 8.33 fstest_helpers 4.29 -gbb -0.30 -genboardscfg 7.95 +futility 7.39 +gbb 0.83 +ifwitool 3.81 image_header 5.77 intel_cmc -12.50 intel_descriptor 4.62 @@ -75,43 +109,21 @@ intel_fsp -12.50 intel_fsp_m -12.50 intel_fsp_s -12.50 intel_fsp_t -12.50 -intel_ifwi 2.71 +intel_ifwi 2.88 intel_me -12.50 intel_mrc -10.00 intel_refcode -10.00 intel_vbt -12.50 intel_vga -12.50 -microcode-tool 7.25 -mkimage 2.57 -moveconfig 8.32 +lz4 6.30 +lzma_alone 6.97 +mkimage 2.31 +mkimage 7.86 multiplexed_log 7.49 opensbi -6.00 -patman 0.00 -patman.checkpatch 8.04 -patman.command 4.74 -patman.commit 3.25 -patman.control 8.14 -patman.cros_subprocess 7.56 -patman.func_test 8.14 -patman.get_maintainer 6.47 -patman.gitutil 5.62 -patman.main 8.23 -patman.patchstream 9.11 -patman.project 6.67 -patman.series 6.16 -patman.settings 5.89 -patman.setup 5.00 -patman.status 8.62 -patman.terminal 7.05 -patman.test_checkpatch 6.81 -patman.test_util 6.89 -patman.tools 4.31 -patman.tout 3.12 powerpc_mpc85xx_bootpg_resetvec -10.00 -rkmux 6.90 -rmboard 7.76 scp -6.00 -section 4.68 +section 4.56 sqfs_common 8.41 test 8.18 test_000_version 7.50 @@ -203,7 +215,7 @@ u_boot_tpl_with_ucode_ptr -20.83 u_boot_ucode 1.52 u_boot_utils 6.94 u_boot_with_ucode_ptr -0.71 -vblock -1.61 +vblock 0.27 vboot_evil 8.95 vboot_forge 9.22 x86_reset16 -15.71 @@ -212,4 +224,3 @@ x86_reset16_tpl -15.71 x86_start16 -15.71 x86_start16_spl -15.71 x86_start16_tpl -15.71 -zynqmp_pm_cfg_obj_convert 6.67
Entries like "score name" rather than "name score" are odd, why did that happen? Also there's at least a few entries where the score decreased, but I assume that's because of code removal. Can you interpret the above and tell me what's going on, and that it makes sense to you at least? And, as a problem, re-running "make pylint" with that base file then fails with awk-spew related to "score name" and not "name score" lines.
It's because one of the lines doesn't have a filename and everything gets out of sync:
... 6.51 patman.tools 6.55 buildman.builderthread 6.67 6.67 binman.ftest 6.71 endian-swap ...
I'd suggest going ahead with the PR and I can dig into it at the weekend. I was trying to do everything in the makefile but it is possible I was too ambitious and we might need a tool.
As you say, this is not part of CI yet.
OK. Applied, thanks!
participants (2)
-
Simon Glass -
Tom Rini