[U-Boot] [PATCH] board: freescale: ls1012a: fix RGMII TX-delay issue
Recently logic to enable RGMII TX-delay was changed by commit 05b29aa0cb68 ("net: phy: realtek: fix enabling of the TX-delay for RTL8211F")
Based on this, here we are enabling the TX-delay again using PHY_INTERFACE_MODE_RGMII_TXID.
Signed-off-by: Calvin Johnson calvin.johnson@nxp.com Signed-off-by: Anjaneyulu Jagarlmudi anji.jagarlmudi@nxp.com ---
board/freescale/ls1012ardb/eth.c | 2 +- drivers/net/pfe_eth/pfe_eth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/ls1012ardb/eth.c b/board/freescale/ls1012ardb/eth.c index 286bc8a..c0f6306 100644 --- a/board/freescale/ls1012ardb/eth.c +++ b/board/freescale/ls1012ardb/eth.c @@ -62,7 +62,7 @@ int board_eth_init(bd_t *bis) /* MAC2 */ ls1012a_set_mdio(1, miiphy_get_dev_by_name(DEFAULT_PFE_MDIO_NAME)); ls1012a_set_phy_address_mode(1, EMAC2_PHY_ADDR, - PHY_INTERFACE_MODE_RGMII); + PHY_INTERFACE_MODE_RGMII_TXID);
cpu_eth_init(bis); #endif diff --git a/drivers/net/pfe_eth/pfe_eth.c b/drivers/net/pfe_eth/pfe_eth.c index 8d8de40..4db823f 100644 --- a/drivers/net/pfe_eth/pfe_eth.c +++ b/drivers/net/pfe_eth/pfe_eth.c @@ -27,7 +27,7 @@ struct gemac_s gem_info[] = {
/* phy iface */ .phy_address = EMAC2_PHY_ADDR, - .phy_mode = PHY_INTERFACE_MODE_RGMII, + .phy_mode = PHY_INTERFACE_MODE_RGMII_TXID, }, };
On Thu, Oct 26, 2017 at 12:01 AM, Calvin Johnson calvin.johnson@nxp.com wrote:
Recently logic to enable RGMII TX-delay was changed by commit 05b29aa0cb68 ("net: phy: realtek: fix enabling of the TX-delay for RTL8211F")
Based on this, here we are enabling the TX-delay again using PHY_INTERFACE_MODE_RGMII_TXID.
Signed-off-by: Calvin Johnson calvin.johnson@nxp.com Signed-off-by: Anjaneyulu Jagarlmudi anji.jagarlmudi@nxp.com
board/freescale/ls1012ardb/eth.c | 2 +- drivers/net/pfe_eth/pfe_eth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/ls1012ardb/eth.c b/board/freescale/ls1012ardb/eth.c index 286bc8a..c0f6306 100644 --- a/board/freescale/ls1012ardb/eth.c +++ b/board/freescale/ls1012ardb/eth.c @@ -62,7 +62,7 @@ int board_eth_init(bd_t *bis) /* MAC2 */ ls1012a_set_mdio(1, miiphy_get_dev_by_name(DEFAULT_PFE_MDIO_NAME)); ls1012a_set_phy_address_mode(1, EMAC2_PHY_ADDR,
PHY_INTERFACE_MODE_RGMII);
PHY_INTERFACE_MODE_RGMII_TXID); cpu_eth_init(bis);#endif diff --git a/drivers/net/pfe_eth/pfe_eth.c b/drivers/net/pfe_eth/pfe_eth.c index 8d8de40..4db823f 100644 --- a/drivers/net/pfe_eth/pfe_eth.c +++ b/drivers/net/pfe_eth/pfe_eth.c
Is this still needed with v2 of your patch?
@@ -27,7 +27,7 @@ struct gemac_s gem_info[] = {
/* phy iface */ .phy_address = EMAC2_PHY_ADDR,
.phy_mode = PHY_INTERFACE_MODE_RGMII,
.phy_mode = PHY_INTERFACE_MODE_RGMII_TXID, },};
-- 2.7.4
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
-----Original Message----- From: Joe Hershberger [mailto:joe.hershberger@ni.com] Sent: Tuesday, February 27, 2018 9:28 PM To: Calvin Johnson calvin.johnson@nxp.com Cc: u-boot u-boot@lists.denx.de; Joe Hershberger joe.hershberger@ni.com; Anji Jagarlmudi anji.jagarlmudi@nxp.com Subject: Re: [U-Boot] [PATCH] board: freescale: ls1012a: fix RGMII TX-delay issue
On Thu, Oct 26, 2017 at 12:01 AM, Calvin Johnson calvin.johnson@nxp.com wrote:
Recently logic to enable RGMII TX-delay was changed by commit 05b29aa0cb68 ("net: phy: realtek: fix enabling of the TX-delay for RTL8211F")
Based on this, here we are enabling the TX-delay again using PHY_INTERFACE_MODE_RGMII_TXID.
Signed-off-by: Calvin Johnson calvin.johnson@nxp.com Signed-off-by: Anjaneyulu Jagarlmudi anji.jagarlmudi@nxp.com
board/freescale/ls1012ardb/eth.c | 2 +- drivers/net/pfe_eth/pfe_eth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/ls1012ardb/eth.c
b/board/freescale/ls1012ardb/eth.c
index 286bc8a..c0f6306 100644 --- a/board/freescale/ls1012ardb/eth.c +++ b/board/freescale/ls1012ardb/eth.c @@ -62,7 +62,7 @@ int board_eth_init(bd_t *bis) /* MAC2 */ ls1012a_set_mdio(1,
miiphy_get_dev_by_name(DEFAULT_PFE_MDIO_NAME));
ls1012a_set_phy_address_mode(1, EMAC2_PHY_ADDR,
PHY_INTERFACE_MODE_RGMII);
PHY_INTERFACE_MODE_RGMII_TXID); cpu_eth_init(bis);#endif diff --git a/drivers/net/pfe_eth/pfe_eth.c b/drivers/net/pfe_eth/pfe_eth.c index 8d8de40..4db823f 100644 --- a/drivers/net/pfe_eth/pfe_eth.c +++ b/drivers/net/pfe_eth/pfe_eth.c
Is this still needed with v2 of your patch?
No. It is already squashed into v2.
Along with this, following patches also were squashed as you and York suggested. [U-Boot,1/3] drivers: net: pfe_eth: add pfe_rx_done to clear bd after packet processing [U-Boot,2/3] drivers: net: pfe_eth: use writel/readl to access hw bds [U-Boot,3/3] drivers: net: pfe_eth: cleanup typos and indent [U-Boot,1/2] drivers: net: pfe_eth: remove unused code under CONFIG_UTIL_PE_DISABLED [U-Boot,2/2] drivers: net: pfe_eth: remove unused code under CONFIG_PFE_WARN_WA
Thanks Calvin
participants (2)
-
Calvin Johnson -
Joe Hershberger