[U-Boot] [PATCH] Kconfig: move EXPERT option under "General setup" menu

Make it a sub-menu of "General setup" like Linux Kernel.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Tom Rini trini@ti.com ---
Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Kconfig b/Kconfig index 153ee2b..60cf1dd 100644 --- a/Kconfig +++ b/Kconfig @@ -56,8 +56,6 @@ config CC_OPTIMIZE_FOR_SIZE
This option is enabled by default for U-Boot.
-endmenu # General setup - menuconfig EXPERT bool "Configure standard U-Boot features (expert users)" help @@ -66,6 +64,8 @@ menuconfig EXPERT environments which can tolerate a "non-standard" U-Boot. Only use this if you really know what you are doing.
+endmenu # General setup + menu "Boot images"
config SPL_BUILD

Tom,
Is there any reason why this patch is not applied?
2014-11-26 18:42 GMT+09:00 Masahiro Yamada yamada.m@jp.panasonic.com:
Make it a sub-menu of "General setup" like Linux Kernel.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Tom Rini trini@ti.com
Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Kconfig b/Kconfig index 153ee2b..60cf1dd 100644 --- a/Kconfig +++ b/Kconfig @@ -56,8 +56,6 @@ config CC_OPTIMIZE_FOR_SIZE
This option is enabled by default for U-Boot.
-endmenu # General setup
menuconfig EXPERT bool "Configure standard U-Boot features (expert users)" help @@ -66,6 +64,8 @@ menuconfig EXPERT environments which can tolerate a "non-standard" U-Boot. Only use this if you really know what you are doing.
+endmenu # General setup
menu "Boot images"
config SPL_BUILD
1.9.1
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

On Tue, Jan 06, 2015 at 12:37:24AM +0900, Masahiro YAMADA wrote:
Tom,
Is there any reason why this patch is not applied?
Eh? $ git log --pretty=fuller 1bf0979f5ff4c297149a705d129ab8db4bec7763 -n1 commit 1bf0979f5ff4c297149a705d129ab8db4bec7763 Author: Tom Rini trini@ti.com AuthorDate: Fri Nov 14 09:34:29 2014 +0100 Commit: Albert ARIBAUD albert.u.boot@aribaud.net CommitDate: Mon Nov 24 09:09:46 2014 +0100
Kconfig: Add EXPERT option
For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases.
Signed-off-by: Tom Rini trini@ti.com Acked-by: Masahiro Yamada yamada.m@jp.panasonic.com Acked-by: Hans de Goede hdegoede@redhat.com Signed-off-by: Hans de Goede hdegoede@redhat.com

Hi Tom,
Please see my patch carefully. http://patchwork.ozlabs.org/patch/415041/
Your commit (1bf0979f5ff4c297) added the expert menu at the root menu.
Mine moves it under the "General setup" menu like Linux.
On Mon, 5 Jan 2015 12:41:56 -0500 Tom Rini trini@ti.com wrote:
On Tue, Jan 06, 2015 at 12:37:24AM +0900, Masahiro YAMADA wrote:
Tom,
Is there any reason why this patch is not applied?
Eh? $ git log --pretty=fuller 1bf0979f5ff4c297149a705d129ab8db4bec7763 -n1 commit 1bf0979f5ff4c297149a705d129ab8db4bec7763 Author: Tom Rini trini@ti.com AuthorDate: Fri Nov 14 09:34:29 2014 +0100 Commit: Albert ARIBAUD albert.u.boot@aribaud.net CommitDate: Mon Nov 24 09:09:46 2014 +0100
Kconfig: Add EXPERT option For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases. Signed-off-by: Tom Rini <trini@ti.com> Acked-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Acked-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
-- Tom

Ping?
2015-01-06 11:17 GMT+09:00 Masahiro Yamada yamada.m@jp.panasonic.com:
Hi Tom,
Please see my patch carefully. http://patchwork.ozlabs.org/patch/415041/
Your commit (1bf0979f5ff4c297) added the expert menu at the root menu.
Mine moves it under the "General setup" menu like Linux.
On Mon, 5 Jan 2015 12:41:56 -0500 Tom Rini trini@ti.com wrote:
On Tue, Jan 06, 2015 at 12:37:24AM +0900, Masahiro YAMADA wrote:
Tom,
Is there any reason why this patch is not applied?
Eh? $ git log --pretty=fuller 1bf0979f5ff4c297149a705d129ab8db4bec7763 -n1 commit 1bf0979f5ff4c297149a705d129ab8db4bec7763 Author: Tom Rini trini@ti.com AuthorDate: Fri Nov 14 09:34:29 2014 +0100 Commit: Albert ARIBAUD albert.u.boot@aribaud.net CommitDate: Mon Nov 24 09:09:46 2014 +0100
Kconfig: Add EXPERT option For similar reasons to why the Linux Kernel has an EXPERT option, we too want an option to allow for tweaking of some options that while normally should remain hidden, may need to be changed in some cases. Signed-off-by: Tom Rini <trini@ti.com> Acked-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Acked-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
-- Tom
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

On Wed, Nov 26, 2014 at 06:42:31PM +0900, Masahiro Yamada wrote:
Make it a sub-menu of "General setup" like Linux Kernel.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Tom Rini trini@ti.com
Applied to u-boot/master, thanks!
participants (3)
-
Masahiro YAMADA
-
Masahiro Yamada
-
Tom Rini