Dear Denis,
the PIP405 board throws some build warnings:
Configuring for PIP405 board... ../common/isa.c: In function 'handle_isa_int': ../common/isa.c:385:21: warning: variable 'isr2' set but not used [-Wunused-but-set-variable] ../common/isa.c:385:16: warning: variable 'isr1' set but not used [-Wunused-but-set-variable]
Are you going to fix these, or can we assume this board is dead and can be removed?
Thanks.
Wolfgang Denk
Fix: ../common/isa.c: In function 'handle_isa_int': ../common/isa.c:385:21: warning: variable 'isr2' set but not used [-Wunused-but-set-variable] ../common/isa.c:385:16: warning: variable 'isr1' set but not used [-Wunused-but-set-variable]
Signed-off-by: David Mueller d.mueller@elsoft.ch
--- board/mpl/common/isa.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/board/mpl/common/isa.c b/board/mpl/common/isa.c index 5d467b4..fc56153 100644 --- a/board/mpl/common/isa.c +++ b/board/mpl/common/isa.c @@ -382,12 +382,12 @@ void init_8259A(void) int handle_isa_int(void) { unsigned long irqack; - unsigned char isr1,isr2,irq; + unsigned char irq; /* first we acknokledge the int via the PCI bus */ irqack=in32(PCI_INT_ACK_ADDR); /* now we get the ISRs */ - isr2=in8(ISR_2); - isr1=in8(ISR_1); + in8(ISR_2); + in8(ISR_1); irq=(unsigned char)irqack; irq-=32; /* if((irq==7)&&((isr1&0x80)==0)) {
Dear =?UTF-8?q?David=20M=C3=BCller?=,
In message 1323689813-21224-1-git-send-email-d.mueller@elsoft.ch you wrote:
Fix: ../common/isa.c: In function 'handle_isa_int': ../common/isa.c:385:21: warning: variable 'isr2' set but not used [-Wunused-but-set-variable] ../common/isa.c:385:16: warning: variable 'isr1' set but not used [-Wunused-but-set-variable]
Signed-off-by: David Mueller d.mueller@elsoft.ch
board/mpl/common/isa.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
David Müller -
Wolfgang Denk