[PATCH] configs: Layerscape: Remove the 'fdt_addr' env
From: Hou Zhiqiang Zhiqiang.Hou@nxp.com
On Layerscape platforms, the DTB is loaded from boot filesystem, per the fdt_addr description in doc/README.distro, it must be removed.
And on many platforms, like ls1046a, ls1088a, ls2088a and lx216xa, the 'fdt_addr' pointed address is not accessible. And with the current EFI boot process, since the EFI_LOADER and CMD_BOOTEFI_BOOTMGR are enabled by default, if the EFI boot components are not deployed in the boot filesystem, it will try to get DTB at address 'fdt_addr' and then result in "SError" or "Synchronous Abort":
Error log on ls1046ardb: => run distro_bootcmd switch to partitions #0, OK mmc0 is current device Scanning mmc 0:1... libfdt fdt_check_header(): FDT_ERR_BADMAGIC Scanning disk esdhc@1560000.blk... Found 5 disks No EFI system partition "Error" handler, esr 0xbf000000 elr: 00000000820704f4 lr : 00000000820080d4 (reloc) elr: 00000000fbd914f4 lr : 00000000fbd290d4 x0 : 0000000064f00000 x1 : 00000000edfe0dd0 x2 : 0000000000000000 x3 : 0000000000000000 x4 : 00000000fbc2ee1a x5 : 000000000000000f x6 : 0000000000000000 x7 : 0000000000000008 x8 : 0000000000000010 x9 : 0000000000000008 x10: 0000000000000044 x11: 00000008ffff0220 x12: 00000000fbdaa748 x13: 00000000fbda70f8 x14: 00000000fbd21d20 x15: 00000000fbc194e8 x16: 00000000fbd70fc8 x17: 0000000000000000 x18: 00000000fbc1cdb0 x19: 00000000fbd21bf0 x20: 0000000064f00000 x21: 00000000fbda6fb8 x22: 0000000000000018 x23: 0000000000000018 x24: 00000000fbde6344 x25: 0000000000000000 x26: 0000000000000000 x27: 0000000000000000 x28: 00000000fbc53660 x29: 00000000fbc19220
Code: 7a419060 1a9f3000 a8c17bfd d65f03c0 (12800100)
Resetting CPU ...
Signed-off-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com --- include/configs/ls1012a2g5rdb.h | 1 - include/configs/ls1012afrdm.h | 2 +- include/configs/ls1012afrwy.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1021atsn.h | 3 +-- include/configs/ls1021atwr.h | 4 +--- include/configs/ls1028aqds.h | 3 +-- include/configs/ls1028ardb.h | 3 +-- include/configs/ls1043a_common.h | 1 - include/configs/ls1046a_common.h | 1 - include/configs/ls1088ardb.h | 2 -- include/configs/ls2080ardb.h | 2 -- include/configs/lx2160a_common.h | 1 - 14 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h index 44f9da7306..d9ff011bac 100644 --- a/include/configs/ls1012a2g5rdb.h +++ b/include/configs/ls1012a2g5rdb.h @@ -29,7 +29,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "kernelheader_addr=0x800000\0" \ "scriptaddr=0x80000000\0" \ diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h index 2711f651d7..c7fdd10cf5 100644 --- a/include/configs/ls1012afrdm.h +++ b/include/configs/ls1012afrdm.h @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright 2016 Freescale Semiconductor, Inc. + * Copyright 2021 NXP */
#ifndef __LS1012ARDB_H__ @@ -24,7 +25,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "fdt_high=0xffffffffffffffff\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "scriptaddr=0x80000000\0" \ "fdtheader_addr_r=0x80100000\0" \ diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h index f8b386125c..7ffca56d72 100644 --- a/include/configs/ls1012afrwy.h +++ b/include/configs/ls1012afrwy.h @@ -41,7 +41,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "kernel_size_sd=0x16000\0" \ "kernelhdr_size_sd=0x10\0" \ diff --git a/include/configs/ls1012aqds.h b/include/configs/ls1012aqds.h index 3e5fdadc40..d0bfd3e494 100644 --- a/include/configs/ls1012aqds.h +++ b/include/configs/ls1012aqds.h @@ -101,7 +101,6 @@ #undef CONFIG_EXTRA_ENV_SETTINGS #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "kernelheader_addr=0x600000\0" \ "scriptaddr=0x80000000\0" \ diff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h index c8a2f120dc..6fff966ee2 100644 --- a/include/configs/ls1012ardb.h +++ b/include/configs/ls1012ardb.h @@ -46,7 +46,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "kernelheader_addr=0x600000\0" \ "scriptaddr=0x80000000\0" \ diff --git a/include/configs/ls1021atsn.h b/include/configs/ls1021atsn.h index 58c2d97a32..97fd61f6f9 100644 --- a/include/configs/ls1021atsn.h +++ b/include/configs/ls1021atsn.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 - * Copyright 2016-2019 NXP Semiconductors + * Copyright 2016-2019, 2021 NXP Semiconductors * Copyright 2019 Vladimir Oltean olteanv@gmail.com */
@@ -151,7 +151,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "bootargs=root=/dev/ram0 rw console=ttyS0,115200\0" \ "initrd_high=0xffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x61000000\0" \ "kernelheader_addr=0x60800000\0" \ "scriptaddr=0x80000000\0" \ diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h index ba308c514b..5be179a36b 100644 --- a/include/configs/ls1021atwr.h +++ b/include/configs/ls1021atwr.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright 2014 Freescale Semiconductor, Inc. - * Copyright 2019 NXP + * Copyright 2019, 2021 NXP */
#ifndef __CONFIG_H @@ -290,7 +290,6 @@ "bootargs=root=/dev/ram0 rw console=ttyLP0,115200 " \ "cma=64M@0x0-0xb0000000\0" \ "initrd_high=0xffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x65000000\0" \ "scriptaddr=0x80000000\0" \ "scripthdraddr=0x80080000\0" \ @@ -347,7 +346,6 @@ "bootargs=root=/dev/ram0 rw console=ttyS0,115200 " \ "cma=64M@0x0-0xb0000000\0" \ "initrd_high=0xffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x61000000\0" \ "kernelheader_addr=0x60800000\0" \ "scriptaddr=0x80000000\0" \ diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h index 9ae37b96ce..31f60b1a9d 100644 --- a/include/configs/ls1028aqds.h +++ b/include/configs/ls1028aqds.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* - * Copyright 2019-2020 NXP + * Copyright 2019-2021 NXP */
#ifndef __LS1028A_QDS_H @@ -88,7 +88,6 @@ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "ramdisk_addr=0x800000\0" \ "ramdisk_size=0x2000000\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "scriptaddr=0x80000000\0" \ "scripthdraddr=0x80080000\0" \ diff --git a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 1a80cb945d..2806012960 100644 --- a/include/configs/ls1028ardb.h +++ b/include/configs/ls1028ardb.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* - * Copyright 2019 NXP + * Copyright 2019, 2021 NXP */
#ifndef __LS1028A_RDB_H @@ -78,7 +78,6 @@ "ramdisk_addr=0x800000\0" \ "ramdisk_size=0x2000000\0" \ "bootm_size=0x10000000\0" \ - "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "scriptaddr=0x80000000\0" \ "scripthdraddr=0x80080000\0" \ diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h index 834c3e6780..aa280cbfc9 100644 --- a/include/configs/ls1043a_common.h +++ b/include/configs/ls1043a_common.h @@ -236,7 +236,6 @@ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "fdt_high=0xffffffffffffffff\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x61000000\0" \ "scriptaddr=0x80000000\0" \ "scripthdraddr=0x80080000\0" \ diff --git a/include/configs/ls1046a_common.h b/include/configs/ls1046a_common.h index 289acc02d3..329f667cda 100644 --- a/include/configs/ls1046a_common.h +++ b/include/configs/ls1046a_common.h @@ -229,7 +229,6 @@ "ramdisk_addr=0x800000\0" \ "ramdisk_size=0x2000000\0" \ "bootm_size=0x10000000\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x61000000\0" \ "scriptaddr=0x80000000\0" \ "scripthdraddr=0x80080000\0" \ diff --git a/include/configs/ls1088ardb.h b/include/configs/ls1088ardb.h index ad3043bbdb..58cde004c1 100644 --- a/include/configs/ls1088ardb.h +++ b/include/configs/ls1088ardb.h @@ -313,7 +313,6 @@ "ramdisk_size=0x2000000\0" \ "fdt_high=0xa0000000\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x1000000\0" \ "kernel_addr_sd=0x8000\0" \ "kernelhdr_addr_sd=0x3000\0" \ @@ -382,7 +381,6 @@ "ramdisk_size=0x2000000\0" \ "fdt_high=0xa0000000\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x1000000\0" \ "kernel_addr_sd=0x8000\0" \ "kernelhdr_addr_sd=0x3000\0" \ diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h index 49c2cc573b..b6a12870d7 100644 --- a/include/configs/ls2080ardb.h +++ b/include/configs/ls2080ardb.h @@ -371,7 +371,6 @@ unsigned long get_board_sys_clk(void); "ramdisk_size=0x2000000\0" \ "fdt_high=0xa0000000\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x581000000\0" \ "kernel_start=0x1000000\0" \ "kernelheader_start=0x800000\0" \ @@ -434,7 +433,6 @@ unsigned long get_board_sys_clk(void); "ramdisk_size=0x2000000\0" \ "fdt_high=0xa0000000\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_addr=0x581000000\0" \ "kernel_start=0x1000000\0" \ "kernelheader_start=0x600000\0" \ diff --git a/include/configs/lx2160a_common.h b/include/configs/lx2160a_common.h index 1338ee3cda..cdc392a7fb 100644 --- a/include/configs/lx2160a_common.h +++ b/include/configs/lx2160a_common.h @@ -214,7 +214,6 @@ unsigned long get_board_ddr_clk(void); "ramdisk_size=0x2000000\0" \ "fdt_high=0xa0000000\0" \ "initrd_high=0xffffffffffffffff\0" \ - "fdt_addr=0x64f00000\0" \ "kernel_start=0x1000000\0" \ "kernelheader_start=0x600000\0" \ "scriptaddr=0x80000000\0" \
Dear Zhiqiang Hou,
In message 20210812072846.39305-1-Zhiqiang.Hou@nxp.com you wrote:
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h index 2711f651d7..c7fdd10cf5 100644 --- a/include/configs/ls1012afrdm.h +++ b/include/configs/ls1012afrdm.h @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /*
- Copyright 2016 Freescale Semiconductor, Inc.
*/
- Copyright 2021 NXP
#ifndef __LS1012ARDB_H__ @@ -24,7 +25,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "fdt_high=0xffffffffffffffff\0" \
- "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "scriptaddr=0x80000000\0" \ "fdtheader_addr_r=0x80100000\0" \
diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
Adding or - like here, even worse - removing just a few lines of data definitions is certainly nothing where you can claim a copyright on.
Best regards,
Wolfgang Denk
Hello Wolfgang,
-----Original Message----- From: Wolfgang Denk wd@denx.de Sent: 2021年8月12日 15:24 To: Z.Q. Hou zhiqiang.hou@nxp.com Cc: u-boot@lists.denx.de; Priyanka Jain priyanka.jain@nxp.com; ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com Subject: Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
Dear Zhiqiang Hou,
In message 20210812072846.39305-1-Zhiqiang.Hou@nxp.com you wrote:
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h index 2711f651d7..c7fdd10cf5 100644 --- a/include/configs/ls1012afrdm.h +++ b/include/configs/ls1012afrdm.h @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /*
- Copyright 2016 Freescale Semiconductor, Inc.
*/
- Copyright 2021 NXP
#ifndef __LS1012ARDB_H__ @@ -24,7 +25,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "fdt_high=0xffffffffffffffff\0" \
- "fdt_addr=0x00f00000\0" \ "kernel_addr=0x01000000\0" \ "scriptaddr=0x80000000\0" \ "fdtheader_addr_r=0x80100000\0" \
diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
Adding or - like here, even worse - removing just a few lines of data definitions is certainly nothing where you can claim a copyright on.
It's NXP's legal check policy.
Thanks, Zhiqiang
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de HR Manager to job candidate "I see you've had no computer training. Although that qualifies you for upper management, it means you're under-qualified for our entry level positions."
Dear "Z.Q. Hou",
In message HE1PR0402MB3371AFC92DF5C544E6363D4684F99@HE1PR0402MB3371.eurprd04.prod.outlook.com you wrote:
Adding or - like here, even worse - removing just a few lines of data definitions is certainly nothing where you can claim a copyright on.
It's NXP's legal check policy.
Maybe, but that's not how copyright works. You cannot claim any copyright on trivial changes.
Best regards,
Wolfgang Denk
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Wolfgang Denk Sent: Thursday, August 12, 2021 2:29 PM To: Z.Q. Hou zhiqiang.hou@nxp.com Cc: u-boot@lists.denx.de; Priyanka Jain priyanka.jain@nxp.com; ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com Subject: Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
Dear "Z.Q. Hou",
In message <HE1PR0402MB3371AFC92DF5C544E6363D4684F99@HE1PR0402MB3371.eurpr d04.prod.outlook.com> you wrote:
Adding or - like here, even worse - removing just a few lines of data definitions is certainly nothing where you can claim a copyright on.
It's NXP's legal check policy.
Maybe, but that's not how copyright works. You cannot claim any copyright on trivial changes.
Best regards,
Wolfgang Denk
Wolfgang Denk,
I agree we cant add copyright for minor changes.
But this file already contains Freescale (now merged into NXP) copyright. Zhiqiang is updating to latest copyright text used by NXP(Freescale) with proper year. I hope this is fine.
Regards Priyanka
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Imitation is the sincerest form of plagarism.
Dear Priyanka,
In message AM6PR04MB5144A92D8955A1DF670163DCE6FF9@AM6PR04MB5144.eurprd04.prod.outlook.com you wrote:
I agree we cant add copyright for minor changes.
But this file already contains Freescale (now merged into NXP) copyright. Zhiqiang is updating to latest copyright text used by NXP(Freescale) with proper year. I hope this is fine.
Hm... I cannot see this.
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h index 2711f651d7..c7fdd10cf5 100644 --- a/include/configs/ls1012afrdm.h +++ b/include/configs/ls1012afrdm.h @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /*
- Copyright 2016 Freescale Semiconductor, Inc.
*/
- Copyright 2021 NXP
This is adding a NEW copyright entry - for deleting one line of data (not even code).
diff --git a/include/configs/ls1021atsn.h b/include/configs/ls1021atsn.h index 58c2d97a32..97fd61f6f9 100644 --- a/include/configs/ls1021atsn.h +++ b/include/configs/ls1021atsn.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0
- Copyright 2016-2019 NXP Semiconductors
*/
- Copyright 2016-2019, 2021 NXP Semiconductors
- Copyright 2019 Vladimir Oltean olteanv@gmail.com
Same here, again for deleting one line of data.
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h index ba308c514b..5be179a36b 100644 --- a/include/configs/ls1021atwr.h +++ b/include/configs/ls1021atwr.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /*
- Copyright 2014 Freescale Semiconductor, Inc.
- Copyright 2019 NXP
*/
- Copyright 2019, 2021 NXP
Again, for deleting 2 lines of data.
And so on.
None of these changes has substance to claim a copyright for.
Best regards,
Wolfgang Denk
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Zhiqiang Hou Sent: Thursday, August 12, 2021 12:59 PM To: u-boot@lists.denx.de; Priyanka Jain priyanka.jain@nxp.com Cc: ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com; Z.Q. Hou zhiqiang.hou@nxp.com Subject: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
From: Hou Zhiqiang Zhiqiang.Hou@nxp.com
On Layerscape platforms, the DTB is loaded from boot filesystem, per the fdt_addr description in doc/README.distro, it must be removed.
Below description is unrelated . It is due to some other issue. Kindly remove it from this patch.
And on many platforms, like ls1046a, ls1088a, ls2088a and lx216xa, the 'fdt_addr' pointed address is not accessible. And with the current EFI boot process, since the EFI_LOADER and CMD_BOOTEFI_BOOTMGR are enabled by default, if the EFI boot components are not deployed in the boot filesystem, it will try to get DTB at address 'fdt_addr' and then result in "SError" or "Synchronous Abort":
Error log on ls1046ardb: => run distro_bootcmd switch to partitions #0, OK mmc0 is current device Scanning mmc 0:1... libfdt fdt_check_header(): FDT_ERR_BADMAGIC Scanning disk esdhc@1560000.blk... Found 5 disks No EFI system partition "Error" handler, esr 0xbf000000 elr: 00000000820704f4 lr : 00000000820080d4 (reloc) elr: 00000000fbd914f4 lr : 00000000fbd290d4 x0 : 0000000064f00000 x1 : 00000000edfe0dd0 x2 : 0000000000000000 x3 : 0000000000000000 x4 : 00000000fbc2ee1a x5 : 000000000000000f x6 : 0000000000000000 x7 : 0000000000000008 x8 : 0000000000000010 x9 : 0000000000000008 x10: 0000000000000044 x11: 00000008ffff0220 x12: 00000000fbdaa748 x13: 00000000fbda70f8 x14: 00000000fbd21d20 x15: 00000000fbc194e8 x16: 00000000fbd70fc8 x17: 0000000000000000 x18: 00000000fbc1cdb0 x19: 00000000fbd21bf0 x20: 0000000064f00000 x21: 00000000fbda6fb8 x22: 0000000000000018 x23: 0000000000000018 x24: 00000000fbde6344 x25: 0000000000000000 x26: 0000000000000000 x27: 0000000000000000 x28: 00000000fbc53660 x29: 00000000fbc19220
Code: 7a419060 1a9f3000 a8c17bfd d65f03c0 (12800100)
Resetting CPU ...
Signed-off-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com
include/configs/ls1012a2g5rdb.h | 1 - include/configs/ls1012afrdm.h | 2 +- include/configs/ls1012afrwy.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1021atsn.h | 3 +-- include/configs/ls1021atwr.h | 4 +--- include/configs/ls1028aqds.h | 3 +-- include/configs/ls1028ardb.h | 3 +-- include/configs/ls1043a_common.h | 1 - include/configs/ls1046a_common.h | 1 - include/configs/ls1088ardb.h | 2 -- include/configs/ls2080ardb.h | 2 -- include/configs/lx2160a_common.h | 1 - 14 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h index 44f9da7306..d9ff011bac 100644 --- a/include/configs/ls1012a2g5rdb.h +++ b/include/configs/ls1012a2g5rdb.h @@ -29,7 +29,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "initrd_high=0xffffffffffffffff\0" \
- "fdt_addr=0x00f00000\0" \
Getting below checkpatch error: ERROR: fdt or initrd relocation disabled at boot time #76: FILE: include/configs/ls1012a2g5rdb.h:31: "initrd_high=0xffffffffffffffff\0" \
Kindly remove unused 'initrd_high' variable as well in this patch in all header files.
Regards Priyanka
-----Original Message----- From: Priyanka Jain (OSS) priyanka.jain@oss.nxp.com Sent: 2021年8月18日 18:33 To: Z.Q. Hou zhiqiang.hou@nxp.com; u-boot@lists.denx.de Cc: ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com; Z.Q. Hou zhiqiang.hou@nxp.com Subject: RE: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Zhiqiang Hou Sent: Thursday, August 12, 2021 12:59 PM To: u-boot@lists.denx.de; Priyanka Jain priyanka.jain@nxp.com Cc: ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com; Z.Q.
Hou
zhiqiang.hou@nxp.com Subject: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
From: Hou Zhiqiang Zhiqiang.Hou@nxp.com
On Layerscape platforms, the DTB is loaded from boot filesystem, per the fdt_addr description in doc/README.distro, it must be removed.
Below description is unrelated . It is due to some other issue. Kindly remove it from this patch.
OK
And on many platforms, like ls1046a, ls1088a, ls2088a and lx216xa, the
'fdt_addr'
pointed address is not accessible. And with the current EFI boot process, since the EFI_LOADER and CMD_BOOTEFI_BOOTMGR are enabled by default, if the EFI boot
components
are not deployed in the boot filesystem, it will try to get DTB at address
'fdt_addr'
and then result in "SError" or "Synchronous Abort":
Error log on ls1046ardb: => run distro_bootcmd switch to partitions #0, OK mmc0 is current device Scanning mmc 0:1... libfdt fdt_check_header(): FDT_ERR_BADMAGIC Scanning disk esdhc@1560000.blk... Found 5 disks No EFI system partition "Error" handler, esr 0xbf000000 elr: 00000000820704f4 lr : 00000000820080d4 (reloc) elr: 00000000fbd914f4 lr : 00000000fbd290d4 x0 : 0000000064f00000 x1 : 00000000edfe0dd0 x2 : 0000000000000000 x3 : 0000000000000000 x4 : 00000000fbc2ee1a x5 : 000000000000000f x6 : 0000000000000000 x7 : 0000000000000008 x8 : 0000000000000010 x9 : 0000000000000008 x10: 0000000000000044 x11: 00000008ffff0220 x12: 00000000fbdaa748 x13: 00000000fbda70f8 x14: 00000000fbd21d20 x15: 00000000fbc194e8 x16: 00000000fbd70fc8 x17: 0000000000000000 x18: 00000000fbc1cdb0 x19: 00000000fbd21bf0 x20: 0000000064f00000 x21: 00000000fbda6fb8 x22: 0000000000000018 x23: 0000000000000018 x24: 00000000fbde6344 x25: 0000000000000000 x26: 0000000000000000 x27: 0000000000000000 x28: 00000000fbc53660 x29: 00000000fbc19220
Code: 7a419060 1a9f3000 a8c17bfd d65f03c0 (12800100)
Resetting CPU ...
Signed-off-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com
include/configs/ls1012a2g5rdb.h | 1 - include/configs/ls1012afrdm.h | 2 +- include/configs/ls1012afrwy.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1021atsn.h | 3 +-- include/configs/ls1021atwr.h | 4 +--- include/configs/ls1028aqds.h | 3 +-- include/configs/ls1028ardb.h | 3 +-- include/configs/ls1043a_common.h | 1 - include/configs/ls1046a_common.h | 1 - include/configs/ls1088ardb.h | 2 -- include/configs/ls2080ardb.h | 2 -- include/configs/lx2160a_common.h | 1 - 14 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h index 44f9da7306..d9ff011bac 100644 --- a/include/configs/ls1012a2g5rdb.h +++ b/include/configs/ls1012a2g5rdb.h @@ -29,7 +29,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "initrd_high=0xffffffffffffffff\0" \
- "fdt_addr=0x00f00000\0" \
Getting below checkpatch error: ERROR: fdt or initrd relocation disabled at boot time #76: FILE: include/configs/ls1012a2g5rdb.h:31: "initrd_high=0xffffffffffffffff\0" \
Kindly remove unused 'initrd_high' variable as well in this patch in all header files.
No, the 'initrd_high' is the context, but it's not changed in this patch.
Thanks, Zhiqiang
Regards Priyanka
-----Original Message----- From: Z.Q. Hou zhiqiang.hou@nxp.com Sent: Monday, August 23, 2021 9:07 AM To: Priyanka Jain (OSS) priyanka.jain@oss.nxp.com; u-boot@lists.denx.de Cc: ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com Subject: RE: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
-----Original Message----- From: Priyanka Jain (OSS) priyanka.jain@oss.nxp.com Sent: 2021年8月18日 18:33 To: Z.Q. Hou zhiqiang.hou@nxp.com; u-boot@lists.denx.de Cc: ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com; Z.Q. Hou zhiqiang.hou@nxp.com Subject: RE: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Zhiqiang Hou Sent: Thursday, August 12, 2021 12:59 PM To: u-boot@lists.denx.de; Priyanka Jain priyanka.jain@nxp.com Cc: ykaukab@suse.de; festevam@gmail.com; trini@konsulko.com; Z.Q.
Hou
zhiqiang.hou@nxp.com Subject: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env
From: Hou Zhiqiang Zhiqiang.Hou@nxp.com
On Layerscape platforms, the DTB is loaded from boot filesystem, per the fdt_addr description in doc/README.distro, it must be removed.
Below description is unrelated . It is due to some other issue. Kindly remove it from this patch.
OK
And on many platforms, like ls1046a, ls1088a, ls2088a and lx216xa, the
'fdt_addr'
pointed address is not accessible. And with the current EFI boot process, since the EFI_LOADER and CMD_BOOTEFI_BOOTMGR are enabled by default, if the EFI boot
components
are not deployed in the boot filesystem, it will try to get DTB at address
'fdt_addr'
and then result in "SError" or "Synchronous Abort":
Error log on ls1046ardb: => run distro_bootcmd switch to partitions #0, OK mmc0 is current device Scanning mmc 0:1... libfdt fdt_check_header(): FDT_ERR_BADMAGIC Scanning disk esdhc@1560000.blk... Found 5 disks No EFI system partition "Error" handler, esr 0xbf000000 elr: 00000000820704f4 lr : 00000000820080d4 (reloc) elr: 00000000fbd914f4 lr : 00000000fbd290d4 x0 : 0000000064f00000 x1 : 00000000edfe0dd0 x2 : 0000000000000000 x3 : 0000000000000000 x4 : 00000000fbc2ee1a x5 : 000000000000000f x6 : 0000000000000000 x7 : 0000000000000008 x8 : 0000000000000010 x9 : 0000000000000008 x10: 0000000000000044 x11: 00000008ffff0220 x12: 00000000fbdaa748 x13: 00000000fbda70f8 x14: 00000000fbd21d20 x15: 00000000fbc194e8 x16: 00000000fbd70fc8 x17: 0000000000000000 x18: 00000000fbc1cdb0 x19: 00000000fbd21bf0 x20: 0000000064f00000 x21: 00000000fbda6fb8 x22: 0000000000000018 x23: 0000000000000018 x24: 00000000fbde6344 x25: 0000000000000000 x26: 0000000000000000 x27: 0000000000000000 x28: 00000000fbc53660 x29: 00000000fbc19220
Code: 7a419060 1a9f3000 a8c17bfd d65f03c0 (12800100)
Resetting CPU ...
Signed-off-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com
include/configs/ls1012a2g5rdb.h | 1 - include/configs/ls1012afrdm.h | 2 +- include/configs/ls1012afrwy.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1021atsn.h | 3 +-- include/configs/ls1021atwr.h | 4 +--- include/configs/ls1028aqds.h | 3 +-- include/configs/ls1028ardb.h | 3 +-- include/configs/ls1043a_common.h | 1 - include/configs/ls1046a_common.h | 1 - include/configs/ls1088ardb.h | 2 -- include/configs/ls2080ardb.h | 2 -- include/configs/lx2160a_common.h | 1 - 14 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h index 44f9da7306..d9ff011bac 100644 --- a/include/configs/ls1012a2g5rdb.h +++ b/include/configs/ls1012a2g5rdb.h @@ -29,7 +29,6 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "verify=no\0" \ "initrd_high=0xffffffffffffffff\0" \
- "fdt_addr=0x00f00000\0" \
Getting below checkpatch error: ERROR: fdt or initrd relocation disabled at boot time #76: FILE: include/configs/ls1012a2g5rdb.h:31: "initrd_high=0xffffffffffffffff\0" \
Kindly remove unused 'initrd_high' variable as well in this patch in all header files.
No, the 'initrd_high' is the context, but it's not changed in this patch.
Thanks, Zhiqiang
Checkpatch is throwing error as ideally we need to remove 'initrd_high' variable as well from NXP platforms. Kindly help to remove 'initrd_high' as well.
Regards Priyanka
Regards Priyanka
participants (4)
-
Priyanka Jain (OSS) -
Wolfgang Denk -
Z.Q. Hou -
Zhiqiang Hou