[U-Boot] [PATCH] ARM: drop "optional" from target select in favor of ARCH_VERSATILE
Since commit a26cd04920dc ("arch: Make board selection choices optional"), Kconfig could create such an insane .config file that no SoC/board is selected.
This is now a real problem for Buildroot, for example. (http://lists.busybox.net/pipermail/buildroot/2015-July/135125.html)
This commit drops the "optional" from the ARM target select menu in favor of "Versatile family".
Rationale: - Historically, Linux chose versatile_defconfig as the default of ARM defconfig. (arch/arm/Makefile of Linux describes: KBUILD_DEFCONFIG := versatile_defconfig)
- It was published by ARM Ltd.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
arch/arm/Kconfig | 2 +- configs/versatileab_defconfig | 1 - configs/versatilepb_defconfig | 1 - configs/versatileqemu_defconfig | 1 - 4 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 9127ace..5caa23e 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -64,7 +64,7 @@ config SEMIHOSTING
choice prompt "Target select" - optional + default ARCH_VERSATILE
config ARCH_AT91 bool "Atmel AT91" diff --git a/configs/versatileab_defconfig b/configs/versatileab_defconfig index 765fe6e..3dc7d19 100644 --- a/configs/versatileab_defconfig +++ b/configs/versatileab_defconfig @@ -1,5 +1,4 @@ CONFIG_ARM=y -CONFIG_ARCH_VERSATILE=y CONFIG_SYS_EXTRA_OPTIONS="ARCH_VERSATILE_AB" # CONFIG_CMD_CONSOLE is not set # CONFIG_CMD_BOOTD is not set diff --git a/configs/versatilepb_defconfig b/configs/versatilepb_defconfig index 1973c38..9fe83b9 100644 --- a/configs/versatilepb_defconfig +++ b/configs/versatilepb_defconfig @@ -1,5 +1,4 @@ CONFIG_ARM=y -CONFIG_ARCH_VERSATILE=y CONFIG_SYS_EXTRA_OPTIONS="ARCH_VERSATILE_PB" # CONFIG_CMD_CONSOLE is not set # CONFIG_CMD_BOOTD is not set diff --git a/configs/versatileqemu_defconfig b/configs/versatileqemu_defconfig index ea9c5b9..9ddef4d 100644 --- a/configs/versatileqemu_defconfig +++ b/configs/versatileqemu_defconfig @@ -1,5 +1,4 @@ CONFIG_ARM=y -CONFIG_ARCH_VERSATILE=y CONFIG_SYS_EXTRA_OPTIONS="ARCH_VERSATILE_QEMU,ARCH_VERSATILE_PB" # CONFIG_CMD_CONSOLE is not set # CONFIG_CMD_BOOTD is not set
Hi Masahiro,
On Sat, Aug 1, 2015 at 2:39 AM, Masahiro Yamada yamada.masahiro@socionext.com wrote:
Since commit a26cd04920dc ("arch: Make board selection choices optional"), Kconfig could create such an insane .config file that no SoC/board is selected.
This is now a real problem for Buildroot, for example. (http://lists.busybox.net/pipermail/buildroot/2015-July/135125.html)
Maybe at some time in the future someone should add a new keyword to Kconfig that forces there to be no implicit default when saving_defconfig (so it is not removed from the defconfig), but also not optional (so that if it really is missing, there is a sane default).
This commit drops the "optional" from the ARM target select menu in favor of "Versatile family".
Rationale:
Historically, Linux chose versatile_defconfig as the default of ARM defconfig. (arch/arm/Makefile of Linux describes: KBUILD_DEFCONFIG := versatile_defconfig)
It was published by ARM Ltd.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
On Sat, Aug 01, 2015 at 04:39:13PM +0900, Masahiro Yamada wrote:
Since commit a26cd04920dc ("arch: Make board selection choices optional"), Kconfig could create such an insane .config file that no SoC/board is selected.
This is now a real problem for Buildroot, for example. (http://lists.busybox.net/pipermail/buildroot/2015-July/135125.html)
This commit drops the "optional" from the ARM target select menu in favor of "Versatile family".
Rationale:
Historically, Linux chose versatile_defconfig as the default of ARM defconfig. (arch/arm/Makefile of Linux describes: KBUILD_DEFCONFIG := versatile_defconfig)
It was published by ARM Ltd.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
participants (3)
-
Joe Hershberger -
Masahiro Yamada -
Tom Rini