[U-Boot] [PATCH v7 00/17] sf: Add support for quad and dual_flash
This series is a combo of quad cmds and dual_flash support Refer [1] and [2] for more functional description about this changes.
[1] http://u-boot.10912.n7.nabble.com/PATCH-v6-00-12-sf-Add-Extended-read-and-qu... [2] http://u-boot.10912.n7.nabble.com/PATCH-v3-0-4-sf-Add-support-to-access-dual...
Tested on sst, stmicro and spansion flash. Testing branch: $ git clone git://git.denx.de/u-boot-spi.git $ cd u-boot-spi $ git checkout -b master-quad origin/master-quad
REQUEST FOR ALL SPI CODE CONTRIBUTORS/USERS, PLEASE TEST THESE CHANGES W.R.T YOUR HW IF POSSIBLE.
Please let me know for any issues/concerns/questions.
On Sun, Jan 12, 2014 at 22:29 +0530, Jagannadha Sutradharudu Teki wrote:
This series is a combo of quad cmds and dual_flash support Refer [1] and [2] for more functional description about this changes.
[ ... ]
Please let me know for any issues/concerns/questions.
-- Thanks, Jagan.
Changes for v7:
- cmdsz on read_ops
- sf param flags are placed spi_flash.h
- code cleanup
- updated dual_flash with BAR support
[ ... ]
Mail setup related nits:
Please don't do this. The dash line correctly separates your signature, which is good (and not a given either). But putting more context below that line will make it look like it's part of the signature, and thus probably will get lost (either by automatic trimming, or folding, or colorization and/or mental filtering).
Then I noticed that the series and your cover letter aren't "connected". The series should be a reply to the cover letter, while you seem to create and send them out in separate steps. Which breaks their relation, and has them appear in random order and with other messages in between them.
And the recipient list suggests that there is an issue with inappropriately quoted entries, there's another nonexistent @theia address as has been in the past. Please fix this (I did upon reply, check your original message).
virtually yours Gerhard Sittig
Hi,
On Mon, Jan 13, 2014 at 3:15 PM, Gerhard Sittig gsi@denx.de wrote:
On Sun, Jan 12, 2014 at 22:29 +0530, Jagannadha Sutradharudu Teki wrote:
This series is a combo of quad cmds and dual_flash support Refer [1] and [2] for more functional description about this changes.
[ ... ]
Please let me know for any issues/concerns/questions.
-- Thanks, Jagan.
Changes for v7: - cmdsz on read_ops - sf param flags are placed spi_flash.h - code cleanup - updated dual_flash with BAR support [ ... ]
Mail setup related nits:
Please don't do this. The dash line correctly separates your signature, which is good (and not a given either). But putting more context below that line will make it look like it's part of the signature, and thus probably will get lost (either by automatic trimming, or folding, or colorization and/or mental filtering).
Yes - will take this input.
Then I noticed that the series and your cover letter aren't "connected". The series should be a reply to the cover letter, while you seem to create and send them out in separate steps. Which breaks their relation, and has them appear in random order and with other messages in between them.
Probably the random order appearance is some issue on my host server side. Will fix to encounter all the mails properly.
And the recipient list suggests that there is an issue with inappropriately quoted entries, there's another nonexistent @theia address as has been in the past. Please fix this (I did upon reply, check your original message).
Try many times to fix this, any idea would appreciate.
participants (3)
-
Gerhard Sittig -
Jagan Teki -
Jagannadha Sutradharudu Teki