[U-Boot] [PATCH] s5pc1xx: gpio: bug fix at gpio_set_pull function

When set to PULL_NONE, gpio_set_pull function is returned without write the register. This patch fixed it.
Signed-off-by: Minkyu Kang mk7.kang@samsung.com --- drivers/gpio/s5p_gpio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c index 0439477..a1bcddc 100644 --- a/drivers/gpio/s5p_gpio.c +++ b/drivers/gpio/s5p_gpio.c @@ -96,7 +96,7 @@ void gpio_set_pull(struct s5p_gpio_bank *bank, int gpio, int mode) value |= PULL_MODE(gpio, mode); break; default: - return; + break; }
writel(value, &bank->pull);

On 28 May 2010 12:52, Minkyu Kang mk7.kang@samsung.com wrote:
When set to PULL_NONE, gpio_set_pull function is returned without write the register. This patch fixed it.
Signed-off-by: Minkyu Kang mk7.kang@samsung.com
drivers/gpio/s5p_gpio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to u-boot-samsung.
Minkyu Kang
participants (2)
-
Minkyu Kang
-
Minkyu Kang