[U-Boot] [RFC] arm: socfpga: introduce SOCFPGA_GEN5 or SOCFPGA_GEN10
From: Dinh Nguyen dinguyen@opensource.altera.com
Define SOCFPGA_GEN5 which applies to Arria5/Cyclone5 hardware, and SOCFPGA_GEN10 for Arria10 hardware.
This would allow us to use the shorten define in the rest of code.
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com --- include/configs/socfpga_common.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 3374683..8fc5666 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -6,6 +6,11 @@ #ifndef __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__ #define __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__
+#if defined(CONFIG_TARGET_SOCFPGA_ARRIA5) || defined(CONFIG_TARGET_SOCFPGA_CYCLONE5) +#define SOCFPGA_GEN5 +#elif defined(CONFIG_TARGET_SOCFPGA_ARRIA10) +#define SOCFPGA_GEN10 +#endif
/* Virtual target or real hardware */ #undef CONFIG_SOCFPGA_VIRTUAL_TARGET
On Tuesday, December 01, 2015 at 11:00:02 PM, dinguyen@opensource.altera.com wrote:
From: Dinh Nguyen dinguyen@opensource.altera.com
Define SOCFPGA_GEN5 which applies to Arria5/Cyclone5 hardware, and SOCFPGA_GEN10 for Arria10 hardware.
This would allow us to use the shorten define in the rest of code.
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com
include/configs/socfpga_common.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 3374683..8fc5666 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -6,6 +6,11 @@ #ifndef __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__ #define __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__
+#if defined(CONFIG_TARGET_SOCFPGA_ARRIA5) || defined(CONFIG_TARGET_SOCFPGA_CYCLONE5) +#define SOCFPGA_GEN5 +#elif defined(CONFIG_TARGET_SOCFPGA_ARRIA10) +#define SOCFPGA_GEN10 +#endif
The same thing can be done in arch/arm/mach-socfpga/Kconfig -- introduce blank symbol similar to TARGET_SOCFPGA_CYCLONE5 and make both of the TARGET_SOCFPGA_CYCLONE5 and TARGET_SOCFPGA_ARRIA5 select it. But do you think it's worth it ?
Best regards, Marek Vasut
On 12/01/2015 05:31 PM, Marek Vasut wrote:
On Tuesday, December 01, 2015 at 11:00:02 PM, dinguyen@opensource.altera.com wrote:
From: Dinh Nguyen dinguyen@opensource.altera.com
Define SOCFPGA_GEN5 which applies to Arria5/Cyclone5 hardware, and SOCFPGA_GEN10 for Arria10 hardware.
This would allow us to use the shorten define in the rest of code.
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com
include/configs/socfpga_common.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 3374683..8fc5666 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -6,6 +6,11 @@ #ifndef __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__ #define __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__
+#if defined(CONFIG_TARGET_SOCFPGA_ARRIA5) || defined(CONFIG_TARGET_SOCFPGA_CYCLONE5) +#define SOCFPGA_GEN5 +#elif defined(CONFIG_TARGET_SOCFPGA_ARRIA10) +#define SOCFPGA_GEN10 +#endif
The same thing can be done in arch/arm/mach-socfpga/Kconfig -- introduce blank symbol similar to TARGET_SOCFPGA_CYCLONE5 and make both of the TARGET_SOCFPGA_CYCLONE5 and TARGET_SOCFPGA_ARRIA5 select it. But do you think it's worth it ?
Yes, I like that idea!
Thanks, Dinh
On Wednesday, December 02, 2015 at 12:37:44 AM, Dinh Nguyen wrote:
On 12/01/2015 05:31 PM, Marek Vasut wrote:
On Tuesday, December 01, 2015 at 11:00:02 PM, dinguyen@opensource.altera.com
wrote:
From: Dinh Nguyen dinguyen@opensource.altera.com
Define SOCFPGA_GEN5 which applies to Arria5/Cyclone5 hardware, and SOCFPGA_GEN10 for Arria10 hardware.
This would allow us to use the shorten define in the rest of code.
Signed-off-by: Dinh Nguyen dinguyen@opensource.altera.com
include/configs/socfpga_common.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 3374683..8fc5666 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -6,6 +6,11 @@
#ifndef __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__ #define __CONFIG_SOCFPGA_CYCLONE5_COMMON_H__
+#if defined(CONFIG_TARGET_SOCFPGA_ARRIA5) || defined(CONFIG_TARGET_SOCFPGA_CYCLONE5) +#define SOCFPGA_GEN5 +#elif defined(CONFIG_TARGET_SOCFPGA_ARRIA10) +#define SOCFPGA_GEN10 +#endif
The same thing can be done in arch/arm/mach-socfpga/Kconfig -- introduce blank symbol similar to TARGET_SOCFPGA_CYCLONE5 and make both of the TARGET_SOCFPGA_CYCLONE5 and TARGET_SOCFPGA_ARRIA5 select it. But do you think it's worth it ?
Yes, I like that idea!
You might want to fix all the places where we use if defined(CV) || defined(AV) then too.
Thanks!
Best regards, Marek Vasut
participants (3)
-
dinguyenï¼ opensource.altera.com -
Dinh Nguyen
-
Marek Vasut