[U-Boot] [PATCH] fs: ext4 write: return file len on success
After rework of the file system API, the size of ext4 write was missed. This causes printing unreliable write size at the end of the file system write operation.
Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com Cc: Sjoerd Simons sjoerd.simons@collabora.co.uk Cc: Lukasz Majewski l.majewski@samsung.com Cc: Simon Glass sjg@chromium.org --- fs/ext4/ext4_write.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c index f7c52cc..fbc4c4b 100644 --- a/fs/ext4/ext4_write.c +++ b/fs/ext4/ext4_write.c @@ -1000,10 +1000,13 @@ int ext4_write_file(const char *filename, void *buf, loff_t offset, } ext4fs_close();
+ *actwrite = len; + return 0;
fail: ext4fs_close(); + *actwrite = 0;
return -1; }
On 02/17/2015 07:31 AM, Przemyslaw Marczak wrote:
After rework of the file system API, the size of ext4 write was missed. This causes printing unreliable write size at the end of the file system write operation.
Tested-by: Stephen Warren swarren@nvidia.com
This fixes the issue I mentioned in the DFU-related thread.
Hello,
On 02/17/2015 03:31 PM, Przemyslaw Marczak wrote:
After rework of the file system API, the size of ext4 write was missed. This causes printing unreliable write size at the end of the file system write operation.
Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com Cc: Sjoerd Simons sjoerd.simons@collabora.co.uk Cc: Lukasz Majewski l.majewski@samsung.com Cc: Simon Glass sjg@chromium.org
fs/ext4/ext4_write.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c index f7c52cc..fbc4c4b 100644 --- a/fs/ext4/ext4_write.c +++ b/fs/ext4/ext4_write.c @@ -1000,10 +1000,13 @@ int ext4_write_file(const char *filename, void *buf, loff_t offset, } ext4fs_close();
*actwrite = len;
return 0;
fail: ext4fs_close();
*actwrite = 0;
return -1; }
Tom, this patch is a fix for write command. Could you please, take it into the master? Then I will not resend it with other patch set, because it's actually independent.
Best regards,
On Tue, Feb 17, 2015 at 03:31:52PM +0100, Przemyslaw Marczak wrote:
After rework of the file system API, the size of ext4 write was missed. This causes printing unreliable write size at the end of the file system write operation.
Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com Cc: Sjoerd Simons sjoerd.simons@collabora.co.uk Cc: Lukasz Majewski l.majewski@samsung.com Cc: Simon Glass sjg@chromium.org Tested-by: Stephen Warren swarren@nvidia.com
Applied to u-boot/master, thanks!
participants (3)
-
Przemyslaw Marczak -
Stephen Warren -
Tom Rini