[U-Boot] [PATCH 1/2] opos6uldev: don't call enable_lcdif_clock
The mxsfb driver already calls enable_lcdif_clock.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- board/armadeus/opos6uldev/board.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/board/armadeus/opos6uldev/board.c b/board/armadeus/opos6uldev/board.c index 4faa997126..aed334f8fb 100644 --- a/board/armadeus/opos6uldev/board.c +++ b/board/armadeus/opos6uldev/board.c @@ -3,7 +3,6 @@ * Copyright (C) 2018 Armadeus Systems */
-#include <asm/arch/clock.h> #include <asm/arch/mx6-pins.h> #include <asm/arch/sys_proto.h> #include <asm/gpio.h> @@ -49,8 +48,6 @@ int setup_lcd(void) struct gpio_desc backlight; int ret;
- enable_lcdif_clock(LCDIF1_BASE_ADDR, 1); - imx_iomux_v3_setup_multiple_pads(lcd_pads, ARRAY_SIZE(lcd_pads));
/* Set Brightness to high */
It's useless on the opos6uldev. Remove it.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- board/armadeus/opos6uldev/board.c | 21 --------------------- 1 file changed, 21 deletions(-)
diff --git a/board/armadeus/opos6uldev/board.c b/board/armadeus/opos6uldev/board.c index aed334f8fb..cbf40d5c4a 100644 --- a/board/armadeus/opos6uldev/board.c +++ b/board/armadeus/opos6uldev/board.c @@ -70,27 +70,6 @@ int setup_lcd(void) } #endif
-#ifdef CONFIG_USB_EHCI_MX6 -#define USB_OTHERREGS_OFFSET 0x800 -#define UCTRL_PWR_POL (1 << 9) - -int board_ehci_hcd_init(int port) -{ - u32 *usbnc_usb_ctrl; - - if (port > 1) - return -EINVAL; - - usbnc_usb_ctrl = (u32 *)(USB_BASE_ADDR + USB_OTHERREGS_OFFSET + - port * 4); - - /* Set Power polarity */ - setbits_le32(usbnc_usb_ctrl, UCTRL_PWR_POL); - - return 0; -} -#endif - int opos6ul_board_late_init(void) { #ifdef CONFIG_VIDEO_MXS
On Tue, May 14, 2019 at 8:48 AM Sébastien Szymanski sebastien.szymanski@armadeus.com wrote:
It's useless on the opos6uldev. Remove it.
Why is it useless? No USB host on this port?
Reviewed-by: Fabio Estevam festevam@gmail.com
Hi Fabio,
On 5/14/19 2:17 PM, Fabio Estevam wrote:
On Tue, May 14, 2019 at 8:48 AM Sébastien Szymanski sebastien.szymanski@armadeus.com wrote:
It's useless on the opos6uldev. Remove it.
Why is it useless? No USB host on this port?
There is an USB host port but this function was just setting the polarity of the PWR signal which is not used on the opos6uldev board.
I guess I should send a v2 with that explanation.
Regards,
Reviewed-by: Fabio Estevam festevam@gmail.com
On Tue, May 14, 2019 at 8:47 AM Sébastien Szymanski sebastien.szymanski@armadeus.com wrote:
The mxsfb driver already calls enable_lcdif_clock.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
Reviewed-by: Fabio Estevam festevam@gmail.com
The mxsfb driver already calls enable_lcdif_clock. Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com Reviewed-by: Fabio Estevam festevam@gmail.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (3)
-
Fabio Estevam -
sbabic＠denx.de -
Sébastien Szymanski