[U-Boot] [PATCH 1/1] xyz-modem: va_start() must be matched by va_end()

Every va_start() call must be matched by a va_end() call.
scripts/checkpatch.pl required reformatting the complete function zm_dprintf().
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- common/xyzModem.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/common/xyzModem.c b/common/xyzModem.c index a126e32ed35..2b18a6e9f50 100644 --- a/common/xyzModem.c +++ b/common/xyzModem.c @@ -180,15 +180,16 @@ static char *zm_out = zm_debug_buf; static char *zm_out_start = zm_debug_buf;
static int -zm_dprintf (char *fmt, ...) +zm_dprintf(char *fmt, ...) { - int len; - va_list args; - - va_start (args, fmt); - len = diag_vsprintf (zm_out, fmt, args); - zm_out += len; - return len; + int len; + va_list args; + + va_start(args, fmt); + len = diag_vsprintf(zm_out, fmt, args); + va_end(args); + zm_out += len; + return len; }
static void

On Mon, May 07, 2018 at 09:59:34PM +0200, Heinrich Schuchardt wrote:
Every va_start() call must be matched by a va_end() call.
scripts/checkpatch.pl required reformatting the complete function zm_dprintf().
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied to u-boot/master, thanks!
participants (2)
-
Heinrich Schuchardt
-
Tom Rini