[U-Boot] [PATCH] sunxi: A64/H5 devices: enable usb keyboard support
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Signed-off-by: Peter Robinson pbrobinson@gmail.com --- configs/a64-olinuxino_defconfig | 2 ++ configs/bananapi_m64_defconfig | 2 ++ configs/nanopi_a64_defconfig | 2 ++ configs/nanopi_neo2_defconfig | 2 ++ configs/nanopi_neo_plus2_defconfig | 2 ++ configs/orangepi_pc2_defconfig | 2 ++ configs/orangepi_win_defconfig | 2 ++ configs/orangepi_zero_plus2_defconfig | 2 ++ configs/pine64_plus_defconfig | 2 ++ configs/sopine_baseboard_defconfig | 2 ++ 10 files changed, 20 insertions(+)
diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig index 6edefa4f67..c4cdec4771 100644 --- a/configs/a64-olinuxino_defconfig +++ b/configs/a64-olinuxino_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/bananapi_m64_defconfig b/configs/bananapi_m64_defconfig index 60cbfd9b2b..4174dd7aac 100644 --- a/configs/bananapi_m64_defconfig +++ b/configs/bananapi_m64_defconfig @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/nanopi_a64_defconfig b/configs/nanopi_a64_defconfig index 122fcc5794..3bef473d48 100644 --- a/configs/nanopi_a64_defconfig +++ b/configs/nanopi_a64_defconfig @@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/nanopi_neo2_defconfig b/configs/nanopi_neo2_defconfig index f27529d7d4..6622a186f3 100644 --- a/configs/nanopi_neo2_defconfig +++ b/configs/nanopi_neo2_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig index 5f69799e06..1c6ad4647d 100644 --- a/configs/nanopi_neo_plus2_defconfig +++ b/configs/nanopi_neo_plus2_defconfig @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2" # CONFIG_SPL_EFI_PARTITION is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig index 893780a0f7..7d01e6f27c 100644 --- a/configs/orangepi_pc2_defconfig +++ b/configs/orangepi_pc2_defconfig @@ -15,3 +15,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/orangepi_win_defconfig b/configs/orangepi_win_defconfig index 0fd297752d..85f0731c3c 100644 --- a/configs/orangepi_win_defconfig +++ b/configs/orangepi_win_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/orangepi_zero_plus2_defconfig b/configs/orangepi_zero_plus2_defconfig index b48f13e7b1..4f1f008ea8 100644 --- a/configs/orangepi_zero_plus2_defconfig +++ b/configs/orangepi_zero_plus2_defconfig @@ -15,3 +15,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/pine64_plus_defconfig b/configs/pine64_plus_defconfig index 23365a57c3..42281a9d7d 100644 --- a/configs/pine64_plus_defconfig +++ b/configs/pine64_plus_defconfig @@ -15,3 +15,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/sopine_baseboard_defconfig b/configs/sopine_baseboard_defconfig index 503e3903ca..30cb6b93d0 100644 --- a/configs/sopine_baseboard_defconfig +++ b/configs/sopine_baseboard_defconfig @@ -19,3 +19,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y
On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Signed-off-by: Peter Robinson pbrobinson@gmail.com
Don't forget any maintainers when you're sending a patch :)
configs/a64-olinuxino_defconfig | 2 ++ configs/bananapi_m64_defconfig | 2 ++ configs/nanopi_a64_defconfig | 2 ++ configs/nanopi_neo2_defconfig | 2 ++ configs/nanopi_neo_plus2_defconfig | 2 ++ configs/orangepi_pc2_defconfig | 2 ++ configs/orangepi_win_defconfig | 2 ++ configs/orangepi_zero_plus2_defconfig | 2 ++ configs/pine64_plus_defconfig | 2 ++ configs/sopine_baseboard_defconfig | 2 ++ 10 files changed, 20 insertions(+)
diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig index 6edefa4f67..c4cdec4771 100644 --- a/configs/a64-olinuxino_defconfig +++ b/configs/a64-olinuxino_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y
Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do you need to enable it in the defconfig?
If this doesn't work for some reason, this should be fixed at the Kconfig level, not in the defconfig.
Maxime
On Mon, Apr 9, 2018 at 1:53 PM, Maxime Ripard maxime.ripard@bootlin.com wrote:
On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Signed-off-by: Peter Robinson pbrobinson@gmail.com
Don't forget any maintainers when you're sending a patch :)
The list in the cc: is what ./scripts/get_maintainer.pl returned when run against the patch
configs/a64-olinuxino_defconfig | 2 ++ configs/bananapi_m64_defconfig | 2 ++ configs/nanopi_a64_defconfig | 2 ++ configs/nanopi_neo2_defconfig | 2 ++ configs/nanopi_neo_plus2_defconfig | 2 ++ configs/orangepi_pc2_defconfig | 2 ++ configs/orangepi_win_defconfig | 2 ++ configs/orangepi_zero_plus2_defconfig | 2 ++ configs/pine64_plus_defconfig | 2 ++ configs/sopine_baseboard_defconfig | 2 ++ 10 files changed, 20 insertions(+)
diff --git a/configs/a64-olinuxino_defconfig b/configs/a64-olinuxino_defconfig index 6edefa4f67..c4cdec4771 100644 --- a/configs/a64-olinuxino_defconfig +++ b/configs/a64-olinuxino_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y
Both are already selected by ARCH_SUNXI if DISTRO_DEFAULTS is set. In turn, DISTRO_DEFAULTS is enabled by default if ARCH_SUNXI is. Why do you need to enable it in the defconfig?
If this doesn't work for some reason, this should be fixed at the Kconfig level, not in the defconfig.
Maxime
-- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Is it usefull on devices without video output(no HDMI, VGA)?
configs/nanopi_neo2_defconfig | 2 ++ configs/nanopi_neo_plus2_defconfig | 2 ++
--- a/configs/nanopi_neo2_defconfig +++ b/configs/nanopi_neo2_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig index 5f69799e06..1c6ad4647d 100644 --- a/configs/nanopi_neo_plus2_defconfig +++ b/configs/nanopi_neo_plus2_defconfig @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2" # CONFIG_SPL_EFI_PARTITION is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y
these two devices have no video out. I am not sure all these have HDMI output.
On Mon, Apr 9, 2018 at 2:50 PM, Antony Antony antony@phenome.org wrote:
On Mon, Apr 09, 2018 at 01:15:00PM +0100, Peter Robinson wrote:
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Is it usefull on devices without video output(no HDMI, VGA)?
configs/nanopi_neo2_defconfig | 2 ++ configs/nanopi_neo_plus2_defconfig | 2 ++
--- a/configs/nanopi_neo2_defconfig +++ b/configs/nanopi_neo2_defconfig @@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2" CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y diff --git a/configs/nanopi_neo_plus2_defconfig b/configs/nanopi_neo_plus2_defconfig index 5f69799e06..1c6ad4647d 100644 --- a/configs/nanopi_neo_plus2_defconfig +++ b/configs/nanopi_neo_plus2_defconfig @@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2" # CONFIG_SPL_EFI_PARTITION is not set CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y +CONFIG_DM_KEYBOARD=y +CONFIG_USB_KEYBOARD=y
these two devices have no video out. I am not sure all these have HDMI output.
Well it's likely a moot point as the HDMI seems enabled on the SoC by default but I'll update to drop those two.
participants (3)
-
Antony Antony -
Maxime Ripard -
Peter Robinson