[U-Boot] [PATCH] fdt: restore board_fdt_blob_setup() declaration

Commit 90c08fa038451d (fdt: Add device tree memory bindings) removed the prototype declaration of board_fdt_blob_setup(), most likely by mistake. This didn't break the build because the only file calling this function (lib/fdtdec.c) provides a local weak definition. Restore the declaration.
Cc: Michael Pratt mpratt@chromium.org Signed-off-by: Baruch Siach baruch@tkos.co.il --- include/fdtdec.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/fdtdec.h b/include/fdtdec.h index 83be06403d8b..250df41e636d 100644 --- a/include/fdtdec.h +++ b/include/fdtdec.h @@ -1001,6 +1001,7 @@ int fdtdec_setup(void); * Called when CONFIG_OF_BOARD is defined, or if CONFIG_OF_SEPARATE is defined * and the board implements it. */ +void *board_fdt_blob_setup(void);
/* * Decode the size of memory

On 28 October 2018 at 05:41, Baruch Siach baruch@tkos.co.il wrote:
Commit 90c08fa038451d (fdt: Add device tree memory bindings) removed the prototype declaration of board_fdt_blob_setup(), most likely by mistake. This didn't break the build because the only file calling this function (lib/fdtdec.c) provides a local weak definition. Restore the declaration.
Cc: Michael Pratt mpratt@chromium.org Signed-off-by: Baruch Siach baruch@tkos.co.il
include/fdtdec.h | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org

On 28 October 2018 at 05:41, Baruch Siach baruch@tkos.co.il wrote:
Commit 90c08fa038451d (fdt: Add device tree memory bindings) removed the prototype declaration of board_fdt_blob_setup(), most likely by mistake. This didn't break the build because the only file calling this function (lib/fdtdec.c) provides a local weak definition. Restore the declaration.
Cc: Michael Pratt mpratt@chromium.org Signed-off-by: Baruch Siach baruch@tkos.co.il
include/fdtdec.h | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm/master, thanks!
participants (3)
-
Baruch Siach
-
Simon Glass
-
sjg@google.com