Re: [U-Boot-Users] arm SoC code in U-Boot.
Hi, I'm afraid I'm quite a bit missing in this discussion. At last, where must I put the imx21 related code? In drivers/imx ? Or will the U-Boot structure be changed (the Soc related code will be spread over drivers/..)?. Must I wait? Must I do something about it?.
Best regards,
-----Mensaje original----- De: wd@denx.de [mailto:wd@denx.de] Enviado el: miércoles, 07 de marzo de 2007 15:39 Para: Haavard Skinnemoen CC: Stefan Roese; u-boot-users@lists.sourceforge.net; Ulf Samuelsson; Grant Likely; TXEMA LOPEZ; Peter Pearse Asunto: Re: [U-Boot-Users] arm SoC code in U-Boot.
In message 1defaf580703070437x2d36edd8q52bc86a41d7df2f2@mail.gmail.com you wrote:
On 3/7/07, Stefan Roese sr@denx.de wrote:
Why not try to match this a little more to the Linux directory structure:
drivers/net/netarm_eth.* drivers/net/qe/* drivers/i2c/omap1510_i2c.* ...
I think this is a great idea. Grouping drivers together by function makes them much easier to find, and it's also easier to find examples when you're writing a new driver. With the current layout, you have to grep through the drivers, cpu and board hierarchies to find existing drivers similar to the one you're trying to write.
Seems we have an agreement. Let's do it this way, then. Thanks to all of you.
Best regards,
Wolfgang Denk
In message 918EB199DDDFFA42BEA2EB3A1C6021F301646DC3@CORREO you wrote:
I'm afraid I'm quite a bit missing in this discussion. At last, where must I put the imx21 related code? In drivers/imx ? Or will the U-Boot structure be changed (the Soc related code will be spread over drivers/..)?. Must I wait? Must I do something about it?.
We agreed to have a directory structure like this:
drivers/net/netarm_eth.* drivers/net/qe/* drivers/i2c/omap1510_i2c.*
Thinking about this again, there is still unneeded redundancy in the names, and it would be better to have simple names like that:
drivers/net/arm* drivers/net/qe/* drivers/i2c/omap1510.*
So if you have a IMX serial driver that should go to drivers/serial/imx.c and an ethernet driver to drivers/net/imx.c and your I2C driver to drivers/i2c/imx.c
As a minimum, you should start this new directory structure and use it for the IMX related code (and leave the cleanup of the other, already existing code in the drivers/ directory to others). Even better, you would include this restructuring of the existing code, too.
[And ideally, you would clean up all the U-Boot code, merge all open patches and fix all the remaining bugs as well. But I guess I'm asking for too much :-) ]
Best regards,
Wolfgang Denk
participants (2)
-
TXEMA LOPEZ -
Wolfgang Denk