[PATCH v3] x86: qemu: Remove dead code

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply replace the rule in it. We use stub C-file like it's done for other boards.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Bin Meng bmeng.cn@gmail.com --- v3: fixed linker error (Bin) board/emulation/qemu-x86/Makefile | 2 +- board/emulation/qemu-x86/qemu-x86.c | 0 board/emulation/qemu-x86/start.S | 8 -------- 3 files changed, 1 insertion(+), 9 deletions(-) create mode 100644 board/emulation/qemu-x86/qemu-x86.c delete mode 100644 board/emulation/qemu-x86/start.S
diff --git a/board/emulation/qemu-x86/Makefile b/board/emulation/qemu-x86/Makefile index 782e298b74ce..ff4aaa51c540 100644 --- a/board/emulation/qemu-x86/Makefile +++ b/board/emulation/qemu-x86/Makefile @@ -2,4 +2,4 @@ # # Copyright (C) 2015, Bin Meng bmeng.cn@gmail.com
-obj-y += start.o +obj-y += qemu-x86.o diff --git a/board/emulation/qemu-x86/qemu-x86.c b/board/emulation/qemu-x86/qemu-x86.c new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/board/emulation/qemu-x86/start.S b/board/emulation/qemu-x86/start.S deleted file mode 100644 index e4bde561b20d..000000000000 --- a/board/emulation/qemu-x86/start.S +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng bmeng.cn@gmail.com - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret

On Tue, Sep 1, 2020 at 4:33 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply replace the rule in it. We use stub C-file like it's done for other boards.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Bin Meng bmeng.cn@gmail.com
v3: fixed linker error (Bin) board/emulation/qemu-x86/Makefile | 2 +- board/emulation/qemu-x86/qemu-x86.c | 0 board/emulation/qemu-x86/start.S | 8 -------- 3 files changed, 1 insertion(+), 9 deletions(-) create mode 100644 board/emulation/qemu-x86/qemu-x86.c delete mode 100644 board/emulation/qemu-x86/start.S
applied to u-boot-x86, thanks!
participants (2)
-
Andy Shevchenko
-
Bin Meng