[U-Boot-Users] ARM[] voiceblue update
Ladislav
Your patch is available for test from
git://linux-arm.org/u-boot-armdev.git#071212_voiceblue
Sorry for the delay.
Please confirm that it builds and runs on a voiceblue.
You have removed the voiceblue_smallflash_config board.
Can we be certain all such boards have disappeared?
Regards
Peter
On Fri, Jan 25, 2008 at 05:24:54PM -0000, Peter Pearse wrote:
Ladislav Your patch is available for test from git://linux-arm.org/u-boot-armdev.git#071212_voiceblue
Sorry for the delay. Please confirm that it builds and runs on a voiceblue.
Builds [1] and runs here...
You have removed the voiceblue_smallflash_config board. Can we be certain all such boards have disappeared?
These boards are still here. This configuration comes from times when we were unable to program flash using JTAG. So these boards come with 1MB flash which was programmed before soldering (yes, ungly) and u-boot running there (voiceblue_smallflash_config) was used to program "real" u-boot. Now, when we are using JTAG programmer, this configuration is no longer needed and thus removed. It was never intended be supported configuration. Newer boards comes without small flash.
Best regards, ladis
[1] except that <asm/mpc8xxx_spi.h> is only available for ppc boards. Your patch from 24 Jan 2008 fixes that.
-----Original Message----- From: Ladislav Michl [mailto:ladis@linux-mips.org] On Behalf Of Ladislav Michl Sent: 28 January 2008 20:45 To: Peter Pearse Cc: u-boot-users@lists.sourceforge.net Subject: Re: ARM[] voiceblue update
On Fri, Jan 25, 2008 at 05:24:54PM -0000, Peter Pearse wrote:
Ladislav Your patch is available for test from git://linux-arm.org/u-boot-armdev.git#071212_voiceblue
Sorry for the delay. Please confirm that it builds and runs on a voiceblue.
Builds [1] and runs here...
Ladislav
I get one warning:-
cmd_jffs2.c:144:2: warning: #warning "MTDPARTS_DEFAULT not defined!"
Your patch removed
#define MTDPARTS_DEFAULT "mtdparts=omapflash.0:128k(uboot),64k(env),64k(r_env),16256k(data1),-(data2) "
from include/configs/voiceblue.h.
Should I replace that line, or delete the
#define CONFIG_CMD_JFFS2
line?
Regards
Peter
On Tue, Jan 29, 2008 at 08:22:20AM +0000, Peter Pearse wrote:
I get one warning:-
cmd_jffs2.c:144:2: warning: #warning "MTDPARTS_DEFAULT not defined!"
Your patch removed
#define MTDPARTS_DEFAULT "mtdparts=omapflash.0:128k(uboot),64k(env),64k(r_env),16256k(data1),-(data2) "
Hmm, it certainly wasn't my patch which removed MTDPARTS_DEFAULT. See this hunk: @@ -221,19 +191,15 @@ */ #define CONFIG_JFFS2_CMDLINE #define MTDIDS_DEFAULT "nor0=omapflash.0" -#define MTDPARTS_DEFAULT "mtdparts=omapflash.0:128k(uboot),64k(env),64k(r_env),16256k(data1),-(data2)" - -#endif /* VOICEBLUE_SMALL_FLASH */ +#define MTDPARTS_DEFAULT "mtdparts=omapflash.0:256k(u-boot),64k(env),64k(r_env),16192k(data0),-(data1)"
And diffing my vs. your version of voiceblue.h also brings interesting result. --- voiceblue.h 2008-01-30 22:16:10.000000000 +0100 +++ include/configs/voiceblue.h 2008-01-25 12:38:08.000000000 +0100 @@ -137,7 +137,6 @@ #define CONFIG_CMD_PING #define CONFIG_CMD_RUN
- /* * BOOTP options */ @@ -162,7 +161,7 @@ "setpart=" \ "if test -n $swapos; then " \ "setenv swapos; saveenv; " \ - "if test $ospart -eq 0; then setenv ospart 1; else setenv ospart 0; fi; "\ + "if test $ospart -eq 0; then setenv ospart 1; else setenv ospart 0; +fi; "\ "fi\0" \ "setup=setenv bootargs console=ttyS0,$baudrate " \ "mtdparts=$mtdparts\0" \ @@ -191,7 +190,6 @@ */ #define CONFIG_JFFS2_CMDLINE #define MTDIDS_DEFAULT "nor0=omapflash.0" -#define MTDPARTS_DEFAULT "mtdparts=omapflash.0:256k(u-boot),64k(env),64k(r_env),16192k(data0),-(data1)"
/*
Indeed, I didn't notice, because partitioning was already saved in environment. Could you please revert your changes except removing that blank line (@@ -137,7 +137,6 @@)?
Best regards, ladis
-----Original Message----- From: Ladislav Michl [mailto:ladis@linux-mips.org] Sent: 30 January 2008 21:24 To: Peter Pearse Cc: u-boot-users@lists.sourceforge.net Subject: Re: ARM[] voiceblue update
On Tue, Jan 29, 2008 at 08:22:20AM +0000, Peter Pearse wrote:
I get one warning:-
......snip
And diffing my vs. your version of voiceblue.h also brings interesting result.
Could you please revert your changes except removing that blank line (@@ -137,7 +137,6 @@)?
Best regards, ladis
Aplogies - trying to keep to Coding Style line length.
I've applied
diff --git a/include/configs/voiceblue.h b/include/configs/voiceblue.h old mode 100644 new mode 100755 index 12d1172..34114ae --- a/include/configs/voiceblue.h +++ b/include/configs/voiceblue.h @@ -145,7 +145,6 @@ #define CONFIG_BOOTP_HOSTNAME #define CONFIG_BOOTP_BOOTPATH
- #define CONFIG_LOOPW
#define CONFIG_BOOTDELAY 3 @@ -161,7 +160,8 @@ "setpart=" \ "if test -n $swapos; then " \ "setenv swapos; saveenv; " \ - "if test $ospart -eq 0; then setenv ospart 1; else setenv ospart 0; +fi; "\ + "if test $ospart -eq 0; then setenv ospart 1; " \ + "else setenv ospart 0; fi; " \ "fi\0" \ "setup=setenv bootargs console=ttyS0,$baudrate " \ "mtdparts=$mtdparts\0" \ @@ -190,7 +190,8 @@ */ #define CONFIG_JFFS2_CMDLINE #define MTDIDS_DEFAULT "nor0=omapflash.0" - +#define MTDPARTS_DEFAULT "mtdparts=omapflash.0:256k(u-boot),64k(env)," \ + "64k(r_env),16192k(data0),-(data1)"
/* * Miscellaneous configurable options
Please retry.
git://linux-arm.org/u-boot-armdev.git#071212_voiceblue
Regards
Peter
participants (3)
-
Ladislav Michl -
Ladislav Michl -
Peter Pearse