On Wed, Jan 3, 2018 at 3:07 PM, Duncan Hare dh@synoia.com wrote:

...

...

selects the LIB_RAND feature since it is required.

Thanks: will be in u-boot/cmd/Kconfig

...

Are we lookin at a series of patches, or a concurrent set?

At this time a series of three, but I'd take advice on the preferred procedure.

Remember that the goal is to be atomic.

You should be able to build and use U-Boot after each patch. For instance, if you are adding a new command, the source for that command, the Kconfig option, the Makefile change to build it, etc should be in the same commit. Similarly, each commit should do as little as is reasonably a distinct change.

Also, any changes to existing code that is not changing behavior but simply making way for new functionality should be done separately. This way it's easier to review in the mindset of "this should be functionally equivalent", making it easier to spot issues without getting lost in a ton of code.

Thanks, -Joe

(1) cmd/Kconfig cmd/net.c

net/Kconfig net/net.c net/ping.c

include/net.h

(2) net/tcp.c net/tcp.h net/Makefile

(3) net/wget.c net/wget.h

---

U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot