[U-Boot] [PATCH] OMAP3 Overo: Fix ethernet related warnings

Fix warning
'setup_net_chip' declared 'static' but never defined
with CONFIG_OMAP3_OVERO_TOBI disabled and
implicit declaration of function 'smc911x_initialize'
with CONFIG_OMAP3_OVERO_TOBI enabled.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
---
Patch against recent u-boot-ti git f4f92c81835ccc43f74925737dfd478edb0182f2 "TI: OMAP3: Overo Tobi ethernet support"
Compile tested only ./MAKEALL omap3_overo with and without CONFIG_OMAP3_OVERO_TOBI enabled.
board/overo/overo.c | 1 + board/overo/overo.h | 2 ++ 2 files changed, 3 insertions(+)
Index: u-boot-ti/board/overo/overo.h =================================================================== --- u-boot-ti.orig/board/overo/overo.h +++ u-boot-ti/board/overo/overo.h @@ -33,7 +33,9 @@ const omap3_sysinfo sysinfo = { #endif };
+#if defined(CONFIG_OMAP3_OVERO_TOBI) static void setup_net_chip(void); +#endif
/* * IEN - Input Enable Index: u-boot-ti/board/overo/overo.c =================================================================== --- u-boot-ti.orig/board/overo/overo.c +++ u-boot-ti/board/overo/overo.c @@ -29,6 +29,7 @@ * MA 02111-1307 USA */ #include <common.h> +#include <netdev.h> #include <twl4030.h> #include <asm/io.h> #include <asm/arch/mux.h>

Fix warning
'setup_net_chip' declared 'static' but never defined
with CONFIG_OMAP3_OVERO_TOBI disabled and
implicit declaration of function 'smc911x_initialize'
with CONFIG_OMAP3_OVERO_TOBI enabled.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
Pushed to u-boot-ti
Thanks, Sandeep

Dear "Paulraj, Sandeep",
In message 0554BEF07D437848AF01B9C9B5F0BC5D927DA017@dlee01.ent.ti.com you wrote:
Fix warning
'setup_net_chip' declared 'static' but never defined
with CONFIG_OMAP3_OVERO_TOBI disabled and
implicit declaration of function 'smc911x_initialize'
with CONFIG_OMAP3_OVERO_TOBI enabled.
Signed-off-by: Dirk Behme dirk.behme@googlemail.com
Pushed to u-boot-ti
I think all these cleanup patches by Dirk should be merged into a cleaned up version of the Overo patch which is needed anyway due to my other comments.
Best regards,
Wolfgang Denk
participants (3)
-
Dirk Behme
-
Paulraj, Sandeep
-
Wolfgang Denk