[U-Boot] [PATCH 1/2] buildman: Fix the logic for the bloat command
This check should now be done whatever mode buildman is running in, since we may be displaying information while building.
Signed-off-by: Simon Glass sjg@chromium.org ---
tools/buildman/control.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py index e97350f..8b8c826 100644 --- a/tools/buildman/control.py +++ b/tools/buildman/control.py @@ -244,13 +244,13 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None, Print(GetActionSummary(options.summary, commits, board_selected, options))
+ # We can't show function sizes without board details at present + if options.show_bloat: + options.show_detail = True builder.SetDisplayOptions(options.show_errors, options.show_sizes, options.show_detail, options.show_bloat, options.list_error_boards) if options.summary: - # We can't show function sizes without board details at present - if options.show_bloat: - options.show_detail = True builder.ShowSummary(commits, board_selected) else: fail, warned = builder.BuildBoards(commits, board_selected,
The get_maintainers script is a useful default, but sometimes is copies too many people, or takes a long time to run.
Add an option to disable it and update the README.
Signed-off-by: Simon Glass sjg@chromium.org ---
tools/patman/README | 4 ++-- tools/patman/patman.py | 6 +++++- tools/patman/series.py | 7 +++++-- 3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/tools/patman/README b/tools/patman/README index 5fb508b..e466886 100644 --- a/tools/patman/README +++ b/tools/patman/README @@ -27,8 +27,8 @@ Series-to: fred.blogs@napier.co.nz
in one of your commits, the series will be sent there.
-In Linux this will also call get_maintainer.pl on each of your -patches automatically. +In Linux and U-Boot this will also call get_maintainer.pl on each of your +patches automatically (unless you use -m to disable this).
How to use this tool diff --git a/tools/patman/patman.py b/tools/patman/patman.py index 2ab6b35..6c6473e 100755 --- a/tools/patman/patman.py +++ b/tools/patman/patman.py @@ -32,6 +32,9 @@ parser.add_option('-c', '--count', dest='count', type='int', parser.add_option('-i', '--ignore-errors', action='store_true', dest='ignore_errors', default=False, help='Send patches email even if patch errors are found') +parser.add_option('-m', '--no-maintainers', action='store_false', + dest='add_maintainers', default=True, + help="Don't cc the file maintainers automatically") parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run', default=False, help="Do a dry run (create but don't email patches)") parser.add_option('-p', '--project', default=project.DetectProject(), @@ -142,7 +145,8 @@ else: ok = True
cc_file = series.MakeCcFile(options.process_tags, cover_fname, - not options.ignore_bad_tags) + not options.ignore_bad_tags, + options.add_maintainers)
# Email the patches out (giving the user time to check / cancel) cmd = '' diff --git a/tools/patman/series.py b/tools/patman/series.py index 88c0d87..b67f870 100644 --- a/tools/patman/series.py +++ b/tools/patman/series.py @@ -201,7 +201,8 @@ class Series(dict): str = 'Change log exists, but no version is set' print col.Color(col.RED, str)
- def MakeCcFile(self, process_tags, cover_fname, raise_on_error): + def MakeCcFile(self, process_tags, cover_fname, raise_on_error, + add_maintainers): """Make a cc file for us to use for per-commit Cc automation
Also stores in self._generated_cc to make ShowActions() faster. @@ -211,6 +212,7 @@ class Series(dict): cover_fname: If non-None the name of the cover letter. raise_on_error: True to raise an error when an alias fails to match, False to just print a message. + add_maintainers: Call the get_maintainers to CC maintainers Return: Filename of temp file created """ @@ -225,7 +227,8 @@ class Series(dict): raise_on_error=raise_on_error) list += gitutil.BuildEmailList(commit.cc_list, raise_on_error=raise_on_error) - list += get_maintainer.GetMaintainer(commit.patch) + if add_maintainers: + list += get_maintainer.GetMaintainer(commit.patch) all_ccs += list print >>fd, commit.patch, ', '.join(list) self._generated_cc[commit.patch] = list
On 14 September 2014 20:23, Simon Glass sjg@chromium.org wrote:
The get_maintainers script is a useful default, but sometimes is copies too many people, or takes a long time to run.
Add an option to disable it and update the README.
Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/misc and now in mainline.
On 14 September 2014 20:23, Simon Glass sjg@chromium.org wrote:
This check should now be done whatever mode buildman is running in, since we may be displaying information while building.
Signed-off-by: Simon Glass sjg@chromium.org
Applied to u-boot-x86/misc and now in mainline.
participants (1)
-
Simon Glass