[U-Boot] [PATCH] blackfin: soft-i2c: No need to define blackfin specific soft i2c operations.

From: Sonic Zhang sonic.zhang@analog.com
Use default GPIO operations.
Signed-off-by: Sonic Zhang sonic.zhang@analog.com --- include/configs/bf533-stamp.h | 29 ++--------------------------- 1 file changed, 2 insertions(+), 27 deletions(-)
diff --git a/include/configs/bf533-stamp.h b/include/configs/bf533-stamp.h index a22c868..f5b9658 100644 --- a/include/configs/bf533-stamp.h +++ b/include/configs/bf533-stamp.h @@ -80,33 +80,8 @@ /* * Software (bit-bang) I2C driver configuration */ -#define PF_SCL PF3 -#define PF_SDA PF2 -#define I2C_INIT (*pFIO_DIR |= PF_SCL); asm("ssync;") -#define I2C_ACTIVE (*pFIO_DIR |= PF_SDA); \ - *pFIO_INEN &= ~PF_SDA; asm("ssync;") -#define I2C_TRISTATE (*pFIO_DIR &= ~PF_SDA); \ - *pFIO_INEN |= PF_SDA; asm("ssync;") -#define I2C_READ ((volatile)(*pFIO_FLAG_D & PF_SDA) != 0); \ - asm("ssync;") -#define I2C_SDA(bit) if (bit) { \ - *pFIO_FLAG_S = PF_SDA; \ - asm("ssync;"); \ - } \ - else { \ - *pFIO_FLAG_C = PF_SDA; \ - asm("ssync;"); \ - } -#define I2C_SCL(bit) if (bit) { \ - *pFIO_FLAG_S = PF_SCL; \ - asm("ssync;"); \ - } \ - else { \ - *pFIO_FLAG_C = PF_SCL; \ - asm("ssync;"); \ - } -#define I2C_DELAY udelay(5) /* 1/4 I2C clock duration */ - +#define CONFIG_SOFT_I2C_GPIO_SCL GPIO_PF3 +#define CONFIG_SOFT_I2C_GPIO_SDA GPIO_PF2
/* * Flash Settings

Hello Sonic
About the subject of your patches
blackfin: soft-i2c: No need to define blackfin specific soft i2c operations.
U-Boot wiki page [http://www.denx.de/wiki/U-Boot/Patches] says like this:
- Don't use periods to end the summary line (e.g., don't do "Add support for X.")
Best Regards Masahiro Yamada
participants (2)
-
Masahiro Yamada
-
Sonic Zhang