Hi,

On Thu, 29 Jun 2023 at 14:04, sunying@nj.iscas.ac.cn wrote:

Hi, We noticed that in the code implementation board/atmel/sama7g5ek/sama7g5ek.c, "#if (IS_ENABLED(CONFIG_I2C_EEPROM))" is located in the condition "#if (IS_ENABLED(CONFIG_MISC_INIT_R))".

Consider that the CONFIG_I2C_EEPROM option requires access to EEPROM memory after normal initial operations are complete.

Do you think it is necessary to add a dependency on MISC_INIT_R in the I2C_EEPROM option definition of drivers/misc/Kconfig file?

That is a board-specific file, so that board should perhaps always enable include MISC_INIT_R. But other boards may not need this.

You could add 'select MISC_INIT_R' to board/atmel/sama7g5ek/Kconfig perhaps, e.g.

config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select MISC_INIT_R

Regards, Simon