Re: [U-Boot] [PATCH 1/1] tools: provide cbfstool
On Sun, Oct 06, 2019 at 10:50:45PM +0200, Heinrich Schuchardt wrote:
'make tests' requires cbfstool. But this file is not built by U-Boot.
cbfstool can be built from https://github.com/coreboot/coreboot.git after copying some include files from https://github.com/coreboot/vboot.git but that is to much of a hassle.
Let's deliver cbfstool with U-Boot.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
I do not want to bundle yet another "thing" from another project that will require re-syncing. We already frankly have problems with too many things getting out-of-date (and making a regular re-sync is on my TODO list, but below removing python2 from our build).
Hi,
On Sun, 6 Oct 2019 at 15:06, Tom Rini trini@konsulko.com wrote:
On Sun, Oct 06, 2019 at 10:50:45PM +0200, Heinrich Schuchardt wrote:
'make tests' requires cbfstool. But this file is not built by U-Boot.
If so this is a bug. The tests are supposed to detect that cbfstool is missing and skip the comparison tests if so.
cbfstool can be built from https://github.com/coreboot/coreboot.git after copying some include files from https://github.com/coreboot/vboot.git but that is to much of a hassle.
Let's deliver cbfstool with U-Boot.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
I do not want to bundle yet another "thing" from another project that will require re-syncing. We already frankly have problems with too many things getting out-of-date (and making a regular re-sync is on my TODO list, but below removing python2 from our build).
-- Tom
Regards, Simon
On Thu, Oct 10, 2019 at 11:06:27AM -0600, Simon Glass wrote:
Hi,
On Sun, 6 Oct 2019 at 15:06, Tom Rini trini@konsulko.com wrote:
On Sun, Oct 06, 2019 at 10:50:45PM +0200, Heinrich Schuchardt wrote:
'make tests' requires cbfstool. But this file is not built by U-Boot.
If so this is a bug. The tests are supposed to detect that cbfstool is missing and skip the comparison tests if so.
Right. To be clearer, these tests are not as useful as we would like as the CI loops do not run them. We could more easily jam this in to GitLab (since we control the host environment) but then we have different coverage in GitLab vs Travis, which is not ideal.
participants (2)
-
Simon Glass -
Tom Rini