[PATCH 0/2] x86: serial: Use NS16550_DYNAMIC in Slim Bootloader
Slim Bootloader provides serial port info in its HOB to support both IO or MMIO serial ports, but it's controlled by SYS_NS16550_MEM32 or SYS_NS16550_PORT_MAPPED in U-Boot. To support both serial port configurations dynamically at runtime, Slim Bootloader serial driver leverages NS16550_DYNAMIC.
Aiden Park (2): x86: serial: Use NS16550_DYNAMIC in Slim Bootloader driver doc: intel: Update serial driver changes in slimbootloader.rst
arch/x86/cpu/slimbootloader/serial.c | 5 ++++ doc/board/intel/slimbootloader.rst | 35 +++++++--------------------- include/configs/slimbootloader.h | 13 ----------- 3 files changed, 13 insertions(+), 40 deletions(-)
Hi Aiden,
On Wed, Dec 18, 2019 at 1:56 PM Park, Aiden aiden.park@intel.com wrote:
Slim Bootloader provides serial port info in its HOB to support both IO or MMIO serial ports, but it's controlled by SYS_NS16550_MEM32 or SYS_NS16550_PORT_MAPPED in U-Boot. To support both serial port configurations dynamically at runtime, Slim Bootloader serial driver leverages NS16550_DYNAMIC.
Aiden Park (2): x86: serial: Use NS16550_DYNAMIC in Slim Bootloader driver doc: intel: Update serial driver changes in slimbootloader.rst
arch/x86/cpu/slimbootloader/serial.c | 5 ++++ doc/board/intel/slimbootloader.rst | 35 +++++++--------------------- include/configs/slimbootloader.h | 13 ----------- 3 files changed, 13 insertions(+), 40 deletions(-)
One issue that needs your attention.
It seems you have configured git email to send from different name other than that in your SoB tag:
See the following git log: commit a6302b7085ce12cb967234e19f2ac2c2320528f1 Author: Park, Aiden aiden.park@intel.com Date: Wed Dec 18 05:56:29 2019 +0000
doc: intel: Update serial driver changes in slimbootloader.rst
Now, Slim Bootloader uses NS16550_DYNAMIC to support serial port configuration at runtime, so no more code change is required. Therefore, remove unnecessary steps and fix minor typo.
Signed-off-by: Aiden Park aiden.park@intel.com
checkpatch complains that: WARNING: Missing Signed-off-by: line by nominal patch author 'Park, Aiden aiden.park@intel.com'
Could you please fix your GIT settings so that both are "Aiden Park aiden.park@intel.com"?
Regards, Bin
Hi Bin,
On Feb 3, 2020, at 7:03 PM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Aiden,
On Wed, Dec 18, 2019 at 1:56 PM Park, Aiden aiden.park@intel.com wrote:
Slim Bootloader provides serial port info in its HOB to support both IO or MMIO serial ports, but it's controlled by SYS_NS16550_MEM32 or SYS_NS16550_PORT_MAPPED in U-Boot. To support both serial port configurations dynamically at runtime, Slim Bootloader serial driver leverages NS16550_DYNAMIC.
Aiden Park (2): x86: serial: Use NS16550_DYNAMIC in Slim Bootloader driver doc: intel: Update serial driver changes in slimbootloader.rst
arch/x86/cpu/slimbootloader/serial.c | 5 ++++ doc/board/intel/slimbootloader.rst | 35 +++++++--------------------- include/configs/slimbootloader.h | 13 ----------- 3 files changed, 13 insertions(+), 40 deletions(-)
One issue that needs your attention.
It seems you have configured git email to send from different name other than that in your SoB tag:
See the following git log: commit a6302b7085ce12cb967234e19f2ac2c2320528f1 Author: Park, Aiden aiden.park@intel.com Date: Wed Dec 18 05:56:29 2019 +0000
doc: intel: Update serial driver changes in slimbootloader.rst
Now, Slim Bootloader uses NS16550_DYNAMIC to support serial port configuration at runtime, so no more code change is required. Therefore, remove unnecessary steps and fix minor typo.
Signed-off-by: Aiden Park aiden.park@intel.com
checkpatch complains that: WARNING: Missing Signed-off-by: line by nominal patch author 'Park, Aiden aiden.park@intel.com'
Could you please fix your GIT settings so that both are "Aiden Park aiden.park@intel.com"?
Thanks for giving me heads-up. Let me double check my configuration for further commits. Thanks again.
Regards, Bin
Best Regards, Aiden
participants (2)
-
Bin Meng -
Park, Aiden