[U-Boot] [PATCH] Remove CONFIG_SHOW_ACTIVITY from stx boards which don't support it

commit 9cff4448a9cb882defe6c8bde73b77fc0c636799 removed the mpc85xx version of timer_interrupt, which was overriding the lib_ppc version. The lib_ppc version tries to invoke board_show_activity() if CONFIG_SHOW_ACTIVITY is defined. stxgp3 and stxssa defined it, despite not defining board_show_activity(). I'll leave it to the stx* maintainer to implement that function if desired. :)
Signed-off-by: Andy Fleming afleming@freescale.com --- include/configs/stxgp3.h | 4 ---- include/configs/stxssa.h | 4 ---- 2 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/include/configs/stxgp3.h b/include/configs/stxgp3.h index ea79de7..7cb5dc9 100644 --- a/include/configs/stxgp3.h +++ b/include/configs/stxgp3.h @@ -55,10 +55,6 @@
#define CONFIG_SYS_CLK_FREQ 33333333 /* most pci cards are 33Mhz */
-/* Blinkin' LEDs for Robert :-) -*/ -#define CONFIG_SHOW_ACTIVITY 1 - /* * These can be toggled for performance analysis, otherwise use default. */ diff --git a/include/configs/stxssa.h b/include/configs/stxssa.h index ac349df..8e2d56f 100644 --- a/include/configs/stxssa.h +++ b/include/configs/stxssa.h @@ -55,10 +55,6 @@
#define CONFIG_SYS_CLK_FREQ 33000000 /* most pci cards are 33Mhz */
-/* Blinkin' LEDs for Robert :-) -*/ -#define CONFIG_SHOW_ACTIVITY 1 - /* * These can be toggled for performance analysis, otherwise use default. */

Dear Andy Fleming,
In message 1220925000-3903-1-git-send-email-afleming@freescale.com you wrote:
commit 9cff4448a9cb882defe6c8bde73b77fc0c636799 removed the mpc85xx version of timer_interrupt, which was overriding the lib_ppc version. The lib_ppc version tries to invoke board_show_activity() if CONFIG_SHOW_ACTIVITY is defined. stxgp3 and stxssa defined it, despite not defining board_show_activity(). I'll leave it to the stx* maintainer to implement that function if desired. :)
Your patch is incorrect as it not only disables board_show_activity() which indeed is not implemented on these boards, but it also disables show_activity() which *is* implemented and shall not be touched.
NAK!
Best regards,
Wolfgang Denk
participants (2)
-
Andy Fleming
-
Wolfgang Denk