[U-Boot] [PATCH] spl: remove redundant call to parse_image_header()
Image header was checked twice.
Signed-off-by: Tomas Melin tomas.melin@vaisala.com --- common/spl/spl_ymodem.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c index 13e8e51..957894d 100644 --- a/common/spl/spl_ymodem.c +++ b/common/spl/spl_ymodem.c @@ -109,7 +109,6 @@ static int spl_ymodem_load_image(struct spl_image_info *spl_image, while ((res = xyzModem_stream_read(buf, BUF_SIZE, &err)) > 0) size += res; } else { - spl_parse_image_header(spl_image, (struct image_header *)buf); ret = spl_parse_image_header(spl_image, (struct image_header *)buf); if (ret)
+ Tom
On Wednesday 16 November 2016 04:45 PM, Tomas Melin wrote:
Image header was checked twice.
Signed-off-by: Tomas Melin tomas.melin@vaisala.com
Acked-by: Lokesh Vutla lokeshvutla@ti.com
Thanks and regards, Lokesh
common/spl/spl_ymodem.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c index 13e8e51..957894d 100644 --- a/common/spl/spl_ymodem.c +++ b/common/spl/spl_ymodem.c @@ -109,7 +109,6 @@ static int spl_ymodem_load_image(struct spl_image_info *spl_image, while ((res = xyzModem_stream_read(buf, BUF_SIZE, &err)) > 0) size += res; } else {
spl_parse_image_header(spl_image, (struct image_header *)buf);
On 16 November 2016 at 04:15, Tomas Melin tomas.melin@vaisala.com wrote:
Image header was checked twice.
Signed-off-by: Tomas Melin tomas.melin@vaisala.com
common/spl/spl_ymodem.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c index 13e8e51..957894d 100644 --- a/common/spl/spl_ymodem.c +++ b/common/spl/spl_ymodem.c @@ -109,7 +109,6 @@ static int spl_ymodem_load_image(struct spl_image_info *spl_image, while ((res = xyzModem_stream_read(buf, BUF_SIZE, &err)) > 0) size += res; } else {
spl_parse_image_header(spl_image, (struct image_header *)buf); ret = spl_parse_image_header(spl_image, (struct image_header *)buf); if (ret)-- 2.1.4
Reviewed-by: Simon Glass sjg@chromium.org
On Wed, Nov 16, 2016 at 01:15:05PM +0200, tomas.melin@vaisala.com wrote:
Image header was checked twice.
Signed-off-by: Tomas Melin tomas.melin@vaisala.com Acked-by: Lokesh Vutla lokeshvutla@ti.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
participants (4)
-
Lokesh Vutla -
Simon Glass -
Tom Rini -
Tomas Melin