[U-Boot] [PATCH 1/3] factor out common code for matrix vision boards
MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
In message 1245678391.3867.11.camel@swa-m460 you wrote:
factor out common code for Matrix Vision based boards.
Signed-off-by: Andre Schwarz andre.schwarz@matrix-vision.de
board/matrix_vision/common/Makefile | 54 ++++++++++++++ board/matrix_vision/common/mv_common.c | 125 ++++++++++++++++++++++++++++++++ board/matrix_vision/common/mv_common.h | 25 +++++++ 3 files changed, 204 insertions(+), 0 deletions(-) create mode 100644 board/matrix_vision/common/Makefile create mode 100644 board/matrix_vision/common/mv_common.c create mode 100644 board/matrix_vision/common/mv_common.h
Hm... to me factor out means removing the same part of code form several places and adding a unique copy of it somewhere. But I see only added code, none removed?
Best regards,
Wolfgang Denk
On Thu, 2009-07-16 at 22:54 +0200, Wolfgang Denk wrote:
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
In message 1245678391.3867.11.camel@swa-m460 you wrote:
factor out common code for Matrix Vision based boards.
Signed-off-by: Andre Schwarz andre.schwarz@matrix-vision.de
board/matrix_vision/common/Makefile | 54 ++++++++++++++ board/matrix_vision/common/mv_common.c | 125 ++++++++++++++++++++++++++++++++ board/matrix_vision/common/mv_common.h | 25 +++++++ 3 files changed, 204 insertions(+), 0 deletions(-) create mode 100644 board/matrix_vision/common/Makefile create mode 100644 board/matrix_vision/common/mv_common.c create mode 100644 board/matrix_vision/common/mv_common.h
Hm... to me factor out means removing the same part of code form several places and adding a unique copy of it somewhere. But I see only added code, none removed?
yes - looks like I've chosen the wrong expression/description. Will provide new patches with descriptions more suitable.
Regards,
André
Best regards,
Wolfgang Denk
MATRIX VISION GmbH, Talstra�e 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch�ftsf�hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
participants (2)
-
André Schwarz -
Wolfgang Denk