Coverity reported 3 warnings on the current code. CID 331856, 331855, 331854 on the latest scan.

Fix the rest of the warnings by initializing the variables before passing them to tpm2_get_pcr_info(). In order to avoid future warnings and errors initialize them to 0 within the function as well, since the values are always OR'ed after querying the hardware.

Signed-off-by: Ilias Apalodimas ilias.apalodimas@linaro.org --- lib/efi_loader/efi_tcg2.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index 39074f754772..ee743f5951fb 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib/efi_loader/efi_tcg2.c @@ -403,6 +403,9 @@ static int tpm2_get_pcr_info(struct udevice *dev, u32 *supported_pcr, size_t i; int tpm_ret;

+ *supported_pcr = 0; + *active_pcr = 0; + *pcr_banks = 0; memset(response, 0, sizeof(response)); ret = tpm2_get_capability(dev, TPM2_CAP_PCRS, 0, response, 1); if (ret) @@ -481,7 +484,7 @@ out: static efi_status_t __get_active_pcr_banks(u32 *active_pcr_banks) { struct udevice *dev; - u32 active, supported, pcr_banks; + u32 active = 0, supported = 0, pcr_banks = 0; efi_status_t ret; int err;

@@ -900,7 +903,7 @@ static efi_status_t create_specid_event(struct udevice *dev, void *buffer, struct tcg_efi_spec_id_event *spec_event; size_t spec_event_size; efi_status_t ret = EFI_DEVICE_ERROR; - u32 active, supported; + u32 active = 0, supported = 0; int err; size_t i;