[U-Boot] [PATCH] Env. vars fix for lite5200
I still have a few older lite5200 boards around and when I recently tried to upgrade U-Boot I ran into weird problems where "saveenv" would fry the bootloader. Attached is a fix. It seems that somewhere along the way the image size grew larger than 256K and the address for the env vars overlapped with the code.
P.S.: Apologies for not putting the patch inline, the email provider I use has a brain-dead policy of enforcing line-wraps on text emails :/
-- Karim Yaghmour CEO - Opersys inc. / www.opersys.com http://twitter.com/karimyaghmour
Dear Karim Yaghmour,
In message cce4b6d6c15fe8f412e82dcbacc5d56c@mail.gmail.com you wrote:
I still have a few older lite5200 boards around and when I recently tried to upgrade U-Boot I ran into weird problems where "saveenv" would fry the bootloader. Attached is a fix. It seems that somewhere along the way the image size grew larger than 256K and the address for the env vars overlapped with the code.
...
diff -urN u-boot-2010.12/include/configs/IceCube.h u-boot-2010.12-fix-lite5200//include/configs/IceCube.h --- u-boot-2010.12/include/configs/IceCube.h 2010-12-22 14:22:14.000000000 -0500 +++ u-boot-2010.12-fix-lite5200//include/configs/IceCube.h 2011-02-23 16:46:35.751137042 -0500
Proper commit message and Signed-off-by: line missing.
Also, patches should be made using "git format-patch". If you really have to do it by hand, then please make sure that they can be applied with "git am", i. e. at least make sure that "patch -p1 works", and that your attached patch has the full information including From:, Date: and Subject.
@@ -234,7 +234,7 @@ #define CONFIG_ENV_ADDR (CONFIG_SYS_FLASH_BASE + 0x00040000 + 0x00800000) #endif #if defined(CONFIG_SYS_LOWBOOT16) -#define CONFIG_ENV_ADDR (CONFIG_SYS_FLASH_BASE + 0x00040000) +#define CONFIG_ENV_ADDR (CONFIG_SYS_FLASH_BASE + 0x00050000) #endif #endif /* CONFIG_SYS_LOWBOOT */ #endif /* CONFIG_LITE5200B */
Hm... This should also be fixed for the highboot case, then.
Best regards,
Wolfgang Denk
participants (2)
-
Karim Yaghmour -
Wolfgang Denk