In message 1122669513.7750.39.camel@cashmere.sps.mot.com you wrote:

OK, I'll fix those.

Thanks.

...

Also, the patch contains stuff that does not belong into it, like this chunk:

But GIT doesn't care! It knows!

This was a patch sent to the public mailing list, and here we don't know much about git yet. We use CVS, and your patch does not apply cleanly to this tree.

[Sorry for being so anal retentive here, but remember that there are others on this list who might be interested in using your patch.]

Best regards,

Wolfgang Denk

In message 1123024299.2614.37.camel@cashmere.sps.mot.com you wrote:

I have fixed up the request style issues now.

Thanks.

I have also remerged with the current head as of a couple hours ago. Also, I've brought up an rsync server, so my git trees at http://www.jdl.com/git_repos/ will feed you http or rsync as needed.

Thanks, worked fine for me.

I understand that it would cause an unacceptable anmount of work for you to re-unwind all these modifications, but please note that this is a one time exception I will make. From now on please use separate branches for boards and processors as discussed.

I see the following problems with your new code (I guess you missed to run the MAKEALL script ???)

MPC8349ADS:

cpu.c: In function `do_reset': cpu.c:77: warning: unused variable `addr' pci.c: In function `pci_mpc83xx_init': pci.c:119: warning: implicit declaration of function `i2c_init' pci.c:122: warning: implicit declaration of function `i2c_write' pci.c:172: warning: passing arg 1 of `pci_set_region' discards qualifiers from pointer target type pci.c:178: warning: passing arg 1 of `pci_set_region' discards qualifiers from pointer target type pci.c:184: warning: passing arg 1 of `pci_setup_indirect' discards qualifiers from pointer target type pci.c:188: warning: passing arg 1 of `pci_hose_write_config_byte' discards qualifiers from pointer target type pci.c:190: warning: passing arg 1 of `pci_hose_read_config_word' discards qualifiers from pointer target type pci.c:192: warning: passing arg 1 of `pci_hose_write_config_word' discards qualifiers from pointer target type pci.c:197: warning: passing arg 1 of `pci_hose_write_config_word' discards qualifiers from pointer target type pci.c:198: warning: passing arg 1 of `pci_hose_write_config_byte' discards qualifiers from pointer target type pci.c:207: warning: passing arg 1 of `pci_set_region' discards qualifiers from pointer target type pci.c:213: warning: passing arg 1 of `pci_set_region' discards qualifiers from pointer target type pci.c:219: warning: passing arg 1 of `pci_setup_indirect' discards qualifiers from pointer target type pci.c:221: warning: passing arg 1 of `pci_hose_write_config_byte' discards qualifiers from pointer target type pci.c:222: warning: passing arg 1 of `pci_hose_read_config_word' discards qualifiers from pointer target type pci.c:224: warning: passing arg 1 of `pci_hose_write_config_word' discards qualifiers from pointer target type pci.c:229: warning: passing arg 1 of `pci_hose_write_config_word' discards qualifiers from pointer target type pci.c:230: warning: passing arg 1 of `pci_hose_write_config_byte' discards qualifiers from pointer target type pci.c:247: warning: passing arg 1 of `pci_register_hose' discards qualifiers from pointer target type pci.c:248: warning: passing arg 1 of `pci_hose_scan' discards qualifiers from pointer target type pci.c:54: warning: unused variable `tmp8' pci.c:55: warning: unused variable `tmp16' spd_sdram.c:84:2: warning: #warning Current spd_sdram does not fit its usage... adjust implementation or API...

Please cleanup.

Best regards,

Wolfgang Denk