Re: [U-Boot] [PATCH] [ARM] Change the UDP Checksum code to work with ARM data alignment.
Wolfgang Denk wrote:
In message 48B38020.4010204@ceos.com.au you wrote:
I followed Ben's instructions and here's the resulting patch.
I'm sorry, but this patch is corrupted and cannot be applied.
In the original code, there were no spaces but TAB characters used for indentation. Someone (you?)
Not me.
Something is severely broken in your setup.
Windows or Thunderbird, take your pick. :-)
I'll try to email from one of our physical or virtual linux machines. If that doesn't work I'll have to send the patch as a zipped attachment. Or gzipped. Is this allowable or does it have to be "real email text"?
- === Tom Evans Tom.Evans@ceos.com.au CEOS Pty Ltd www.ceos.com.au 3/17 Burgundy St, Heidelberg, Victoria 3084, Australia
Phone (+61 3) 9458 4955 Direct Unsupported FAX (+61 3) 9458 4966 Mobile 0405 776 431
Hi Tom,
Tom Evans wrote:
Wolfgang Denk wrote:
In message 48B38020.4010204@ceos.com.au you wrote:
I followed Ben's instructions and here's the resulting patch.
I'm sorry, but this patch is corrupted and cannot be applied.
In the original code, there were no spaces but TAB characters used for indentation. Someone (you?)
Not me.
Something is severely broken in your setup.
Windows or Thunderbird, take your pick. :-)
I'll try to email from one of our physical or virtual linux machines. If that doesn't work I'll have to send the patch as a zipped attachment. Or gzipped. Is this allowable or does it have to be "real email text"?
The only 100%* way to send patches is using git-send-email, but it's a small pain to set up especially if you're not going to be using it much. I've had decent luck with Thunderbird, as long as you select 'Preformat' for the patch part of your e-mail and send it as plain text. Please try this. If it still doesn't work I'll fix it manually.
regards, Ben
Dear Ben Warren,
In message 48B4E607.8040700@gmail.com you wrote:
The only 100%* way to send patches is using git-send-email, but it's a small pain to set up especially if you're not going to be using it much.
oops? What do you mean by "pain to set up" ? You don;t have to set up anything.
Just type:
git-send-email --to u-boot@lists.denx.de patch...
I've had decent luck with Thunderbird, as long as you select 'Preformat' for the patch part of your e-mail and send it as plain text. Please try this. If it still doesn't work I'll fix it manually.
You do not need Thunderbird or any other MUA at all.
Best regards,
Wolfgang Denk
On Wednesday 27 August 2008, Wolfgang Denk wrote:
The only 100%* way to send patches is using git-send-email, but it's a small pain to set up especially if you're not going to be using it much.
oops? What do you mean by "pain to set up" ? You don;t have to set up anything.
Just type:
git-send-email --to u-boot@lists.denx.de patch...
You forgot about the configuration you have done in your ~/.gitconfig file ([sendemail] section, smtpserver...). But is not really hard to configure. And it really is worth the effort.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Dear Stefan Roese,
In message 200808271058.21467.sr@denx.de you wrote:
Just type:
git-send-email --to u-boot@lists.denx.de patch...
You forgot about the configuration you have done in your ~/.gitconfig file ([sendemail] section, smtpserver...). But is not really hard to configure. And it really is worth the effort.
No, I did not forget this:
-> ls -l ~/.gitconfig ls: cannot access /home/wd/.gitconfig: No such file or directory
Best regards,
Wolfgang Denk
On Wednesday 27 August 2008, Wolfgang Denk wrote:
Just type:
git-send-email --to u-boot@lists.denx.de patch...
You forgot about the configuration you have done in your ~/.gitconfig file ([sendemail] section, smtpserver...). But is not really hard to configure. And it really is worth the effort.
No, I did not forget this:
-> ls -l ~/.gitconfig ls: cannot access /home/wd/.gitconfig: No such file or directory
Hmmm. Then I'm really curious how git-send-email know to which SMTP server to send this mail.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Dear Stefan Roese,
In message 200808271149.46867.sr@denx.de you wrote:
Hmmm. Then I'm really curious how git-send-email know to which SMTP server to send this mail.
It runs "sendmail" to send the message, assuming you have a working mail configuration on your host.
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
Dear Stefan Roese,
In message 200808271149.46867.sr@denx.de you wrote:
Hmmm. Then I'm really curious how git-send-email know to which SMTP server to send this mail.
It runs "sendmail" to send the message, assuming you have a working mail configuration on your host.
Best regards,
Wolfgang Denk
"...assuming you have a working mail configuration on your host." Winders hosts don't have a working mail configuration ("sendmail" or localhost port 25 support), which means that the people that need git-send-email worst (those stuck in a Winders-centric corporate borg) require setup and luck.
If you are a borger (that would be Germanization of "lives in a borg," IIRC), your Exchange server may support port 25 (IIUC, it is an optional configuration item, but probably configured).
You first need to know the name of your Exchange server. 1. In Outlook, select the menu selection Tools/Email Accounts which brings up a dialog allowing you to "View or change existing e-mail accounts" 2. Click the "Next" button which brings up the next dialog box. 3. Select the "Microsoft Exchange Server" account and click the "Change" button. 4. This dialog box shows your Exchange server name. Hopefully it supports port 25 communications. 5. Click the "Cancel" button to exit without changing your Outlook setup.
You may need to authenticate, in which case you would use "domain\user" (where "domain" is your ActiveDirectory domain, "user" is your user name, and the backslash *is* a backslash and may need to be quoted/doubled).
I have done this with Thunderbird[1] on Windows (check my headers, but please don't tell the IT staff ;-), but I have *not* done it with git-send-email. If anybody tries this, please let us know how it worked out (success or failure).
Thanks & good luck, gvb
[1] The Exchange server I connect to actually supports IMAP as well as port 25 and it works very well (surprisingly).
Wolfgang Denk wrote:
Dear Ben Warren,
In message 48B4E607.8040700@gmail.com you wrote:
The only 100%* way to send patches is using git-send-email, but it's a small pain to set up especially if you're not going to be using it much.
oops? What do you mean by "pain to set up" ? You don;t have to set up anything.
Just type:
git-send-email --to u-boot@lists.denx.de patch...
Sure, if you have easy access to an SMTP server and have sendmail running it's trivial. If you use gmail, there are a few hoops you need to jump through regarding authentication. All-in-all, worth the effort if you're going to do it more than once.
regards, Ben
participants (5)
-
Ben Warren -
JerryVanBaren -
Stefan Roese -
Tom Evans -
Wolfgang Denk