[PATCH] serial-uclass: fix build warning
if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not, gcc drops warnings for serial_stub_* functions that they are defined but not used.
Fix it.
Signed-off-by: Heiko Schocher hs@denx.de --- azure build is clean https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
drivers/serial/serial-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index 96a1cb65ba..362cedd955 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -357,7 +357,6 @@ static void serial_stub_putc(struct stdio_dev *sdev, const char ch) { _serial_putc(sdev->priv, ch); } -#endif
static void serial_stub_puts(struct stdio_dev *sdev, const char *str) { @@ -374,6 +373,7 @@ static int serial_stub_tstc(struct stdio_dev *sdev) return _serial_tstc(sdev->priv); } #endif +#endif
/** * on_baudrate() - Update the actual baudrate when the env var changes
On Wed, 2 Feb 2022 at 05:55, Heiko Schocher hs@denx.de wrote:
if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not, gcc drops warnings for serial_stub_* functions that they are defined but not used.
Fix it.
Signed-off-by: Heiko Schocher hs@denx.de
azure build is clean https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
drivers/serial/serial-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
On Wed, 2 Feb 2022 at 05:55, Heiko Schocher hs@denx.de wrote:
if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not, gcc drops warnings for serial_stub_* functions that they are defined but not used.
Fix it.
Signed-off-by: Heiko Schocher hs@denx.de
azure build is clean https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
drivers/serial/serial-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!
participants (2)
-
Heiko Schocher -
Simon Glass