[U-Boot-Users] JFFS2 speed enhancement patch

Hi,
for the sake of speed I repaired the header CRC calculation in the jffs2_1pass.c.
I also added the eraseblock size to the partition information to skip empty eraseblocks if we find more then 4k of free space.
The JFFS2 scanner is now fast enough to remove the spinning wheel so I #ifdef-ed it out.
I added watchdog calls in the long running loops.
The speed increasement was x10 on my board. I tested this for some days now and it works good for me.
regards Christian

In message 20040423155233.C8298@gateway.bln.innominate.local you wrote:
for the sake of speed I repaired the header CRC calculation in the jffs2_1pass.c.
I also added the eraseblock size to the partition information to skip empty eraseblocks if we find more then 4k of free space.
The JFFS2 scanner is now fast enough to remove the spinning wheel so I #ifdef-ed it out.
I added watchdog calls in the long running loops.
Thanks, added.
Please provide a CHANGELOG entry next time, and don't add trailing white space to files!
Best regards,
Wolfgang Denk

In message 20040423155233.C8298@gateway.bln.innominate.local you wrote:
for the sake of speed I repaired the header CRC calculation in the jffs2_1pass.c.
I also added the eraseblock size to the partition information to skip empty eraseblocks if we find more then 4k of free space.
Note that your patch breaks all boards which use JFFS2 without defining PHYS_FLASH_SECT_SIZE - I guess you forgot to run the MAKEALL script? Grrrgh...
Actually, PHYS_FLASH_SECT_SIZE is just a private definition used in- ternally by some boards; it is definitely NOT a configuration para- meter which can be used in common code.
I will back out your patch, and reject it.
Please clean it up, amd make sure to use only public data.
Also, please don't forget to run MAKEALL to make sure the other boards are at least compile clean.
Best regards,
Wolfgang Denk
participants (2)
-
Christian Hohnstaedt
-
Wolfgang Denk