Re: [U-Boot] [PATCH 0/4] Make some changes to SDP
Hi Angus,
I have just finished the SDP test on imx8mq_evk and the SDP can work with some board configs. I guess it may be two problems that lead your SDP can't work on imx8mq_evk. You can add the follow two changes and test it again.
The first change: --- a/drivers/usb/gadget/epautoconf.c +++ b/drivers/usb/gadget/epautoconf.c @@ -262,6 +262,7 @@ struct usb_ep *usb_ep_autoconfig( ep = find_ep(gadget, "ep1-bulk"); if (ep && ep_matches(gadget, ep, desc)) return ep; +#ifndef CONFIG_SPL_BUILD } else if (gadget_is_dwc3(gadget)) { const char *name = NULL; /* @@ -284,6 +285,7 @@ struct usb_ep *usb_ep_autoconfig( ep = find_ep(gadget, name); if (ep && ep_matches(gadget, ep, desc)) return ep; +#endif }
The second change: --- a/arch/arm/mach-imx/imx8m/soc.c +++ b/arch/arm/mach-imx/imx8m/soc.c @@ -55,6 +55,13 @@ void enable_tzc380(void) /* Enable TZASC and lock setting */ setbits_le32(&gpr->gpr[10], GPR_TZASC_EN); setbits_le32(&gpr->gpr[10], GPR_TZASC_EN_LOCK); + + /* + * set Region 0 attribute to allow secure and non-secure read/write permission + * Found some masters like usb dwc3 controllers can't work with secure memory. + */ + writel(0xf0000000, TZASC_BASE_ADDR + 0x108); + }
If there is anything you don’t understand, you can also get my test patches at https://github.com/sherrysun1/u-boot-imx.git. You just need check the first four patches which I used to test for imx8mq_evk.
And feel free to let me know if any problems.
Best regards Sherry sun
Hi Sherry,
On Aug. 8, 2019 2:38 a.m., Sherry Sun <sherry.sun@nxp.commailto:sherry.sun@nxp.com> wrote:
Hi Angus,
Sorry for the late reply.
Hi Peng,
On 2019-08-01 18:01, Peng Fan wrote:
Angus,
Subject: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
Hi Sherry,
On 2019-07-31 19:56, Sherry Sun wrote:
Hi Angus
Hi Sherry,
On 2019-07-17 18:40, sherry sun wrote:
From: Sherry Sun <sherry.sun@nxp.commailto:sherry.sun@nxp.com>
This patchset adds:
- Add usb_gadget_initialize() and usb_gadget_release() to
initialize and release UDC during sdp download. 2. Add high speed endpoint descriptor for sdp. 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load address while SDP_WRITE and SDP_JUMP command addr is zero.
Sherry Sun (4): imx: spl: Change USB boot device type SDP: use CONFIG_SDP_LOADADDR as default load address SDP: fix wrong usb request size and add high speed endpoint descriptor SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC
These changes look like like they target SDP on imx8. For imx8mq is this all that is required to get SDP working with uuu or are there additional changes required ?
The changes in patch 1/4 are target on both imx8 and imx8m. The rest three patches are target on all boards which used SDP. So for imx8mq, if your usb gadget driver is ready ,these changes are enough to get SDP working with UUU.
I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's enabled there. Do you have patches to enable SDP on the imx8mq-evk , even if they aren't ready to go upstream ?
You could try downstream code, https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
ce.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2F&data=02%7C01 %7Cs
herry.sun%40nxp.com%7C6d63289fbb104168bce308d716f157c4%7C686ea1 d3bc2b4
c6fa92cd99c5c301635%7C0%7C0%7C637003098143081621&sdata=beh 08%2Fv3f
s8ZZPP29F1iVMfo3uNTWGf91SYYyak2GVU%3D&reserved=0 branch: imx_v2019.04_4.19.35_1.0.0
I already have SDP working with the vendor u-boot. I'm trying to switch to mainline u-boot so I'm looking for mainline patches.
May I ask, is your usb gadget driver is working? Such as you can use it for fastboot or ums. If I enable dwc3 gadget and DM for the SPL then I must start removing other SPL features to get it to fit in the 124k allocation.
It sounds like you haven't tested this on the imx8mq-evk then ?
Thanks Angus
Best regards Sherry sun
Thanks Angus
Regards, Peng.
Thanks Angus
Best regards Sherry sun
Thanks Angus
arch/arm/mach-imx/spl.c | 2 +- common/spl/spl_sdp.c | 4 ++++ drivers/usb/gadget/Kconfig | 4 ++++ drivers/usb/gadget/f_sdp.c | 39 +++++++++++++++++++++++++++++++++----- 4 files changed, 43 insertions(+), 6 deletions(-)
participants (1)
-
Sherry Sun