[U-Boot] [PATCH v2] test: py: Add cmd_echo dependency

There is missing dependency on echo command. Mark tests which requires echo.
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
Changes in v2: - Removed incorrect dependency on echo command - Add empty line before header and module import - Mark the whole file with global pytestmark - all reported by Stephen
test/py/tests/test_env.py | 3 +++ test/py/tests/test_shell_basics.py | 4 ++++ 2 files changed, 7 insertions(+)
diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py index 035dbf5cac4c..b7f960c755fe 100644 --- a/test/py/tests/test_env.py +++ b/test/py/tests/test_env.py @@ -164,6 +164,7 @@ def test_env_echo_exists(state_test_env): value = state_test_env.env[var] validate_set(state_test_env, var, value)
+@pytest.mark.buildconfigspec('cmd_echo') def test_env_echo_non_existent(state_test_env): """Test echoing a variable that doesn't exist."""
@@ -179,6 +180,7 @@ def test_env_printenv_non_existent(state_test_env): response = c.run_command('printenv %s' % var) assert(response == '## Error: "%s" not defined' % var)
+@pytest.mark.buildconfigspec('cmd_echo') def test_env_unset_non_existent(state_test_env): """Test unsetting a nonexistent variable."""
@@ -202,6 +204,7 @@ def test_env_set_existing(state_test_env): set_var(state_test_env, var, value) validate_set(state_test_env, var, value)
+@pytest.mark.buildconfigspec('cmd_echo') def test_env_unset_existing(state_test_env): """Test unsetting a variable."""
diff --git a/test/py/tests/test_shell_basics.py b/test/py/tests/test_shell_basics.py index 702e5e27e002..0024d5f7f619 100644 --- a/test/py/tests/test_shell_basics.py +++ b/test/py/tests/test_shell_basics.py @@ -4,6 +4,10 @@
# Test basic shell functionality, such as commands separate by semi-colons.
+import pytest + +pytestmark = pytest.mark.buildconfigspec('cmd_echo') + def test_shell_execute(u_boot_console): """Test any shell command."""

On 05/15/2017 06:29 AM, Michal Simek wrote:
There is missing dependency on echo command. Mark tests which requires echo.
Reviewed-by: Stephen Warren swarren@nvidia.com
It'd be good to update test_hush_if_test.py too though, even if separately.

On 15.5.2017 23:49, Stephen Warren wrote:
On 05/15/2017 06:29 AM, Michal Simek wrote:
There is missing dependency on echo command. Mark tests which requires echo.
Reviewed-by: Stephen Warren swarren@nvidia.com
It'd be good to update test_hush_if_test.py too though, even if separately.
I have sent patch for that please review.
Thanks, Michal

On Mon, May 15, 2017 at 02:29:02PM +0200, Michal Simek wrote:
There is missing dependency on echo command. Mark tests which requires echo.
Signed-off-by: Michal Simek michal.simek@xilinx.com Reviewed-by: Stephen Warren swarren@nvidia.com
Applied to u-boot/master, thanks!
participants (3)
-
Michal Simek
-
Stephen Warren
-
Tom Rini