[U-Boot] [PATCH 1/2] coreboot: only init usb if necessary
From: Thomas RIENOESSL thomas.rienoessl@bachmann.info
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as a coreboot payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by: Thomas RIENOESSL thomas.rienoessl@bachmann.info Reviewed-by: Bin Meng bmeng.cn@gmail.com Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
arch/x86/cpu/coreboot/coreboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c index aaf0d07..4c6ed0b 100644 --- a/arch/x86/cpu/coreboot/coreboot.c +++ b/arch/x86/cpu/coreboot/coreboot.c @@ -77,7 +77,8 @@ int last_stage_init(void) timestamp_add_to_bootstage();
/* start usb so that usb keyboard can be used as input device */ - usb_init(); + if (CONFIG_IS_ENABLED(USB_KEYBOARD)) + usb_init();
board_final_cleanup();
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as an EFI payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
arch/x86/cpu/efi/payload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/cpu/efi/payload.c b/arch/x86/cpu/efi/payload.c index c323c7b..225aef7 100644 --- a/arch/x86/cpu/efi/payload.c +++ b/arch/x86/cpu/efi/payload.c @@ -166,7 +166,8 @@ int reserve_arch(void) int last_stage_init(void) { /* start usb so that usb keyboard can be used as input device */ - usb_init(); + if (CONFIG_IS_ENABLED(USB_KEYBOARD)) + usb_init();
return 0; }
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng bmeng.cn@gmail.com:
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as an EFI payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
Reviewed-by: Christian Gmeiner christian.gmeiner@gmail.com
arch/x86/cpu/efi/payload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/cpu/efi/payload.c b/arch/x86/cpu/efi/payload.c index c323c7b..225aef7 100644 --- a/arch/x86/cpu/efi/payload.c +++ b/arch/x86/cpu/efi/payload.c @@ -166,7 +166,8 @@ int reserve_arch(void) int last_stage_init(void) { /* start usb so that usb keyboard can be used as input device */
usb_init();
if (CONFIG_IS_ENABLED(USB_KEYBOARD))usb_init(); return 0;}
2.7.4
On Fri, Nov 30, 2018 at 3:43 PM Christian Gmeiner christian.gmeiner@gmail.com wrote:
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng bmeng.cn@gmail.com:
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as an EFI payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
Reviewed-by: Christian Gmeiner christian.gmeiner@gmail.com
applied to u-boot-x86, thanks!
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng bmeng.cn@gmail.com:
From: Thomas RIENOESSL thomas.rienoessl@bachmann.info
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as a coreboot payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by: Thomas RIENOESSL thomas.rienoessl@bachmann.info Reviewed-by: Bin Meng bmeng.cn@gmail.com Signed-off-by: Bin Meng bmeng.cn@gmail.com
I totally forgot to send an updated version of this patch - thanks for doing this Bin!
Reviewed-by: Christian Gmeiner christian.gmeiner@gmail.com
On Fri, Nov 30, 2018 at 3:43 PM Christian Gmeiner christian.gmeiner@gmail.com wrote:
Am Fr., 30. Nov. 2018 um 05:02 Uhr schrieb Bin Meng bmeng.cn@gmail.com:
From: Thomas RIENOESSL thomas.rienoessl@bachmann.info
Up until now the call to initialize the USB subsystem was hardcoded for U-Boot running as a coreboot payload. This was used to enable the use of a USB keyboard in the U-Boot shell. However not all boards might need this functionality. As initializing the USB subsystem can take a considerable amount of time (several seconds on some boards), we now initialize the USB subsystem only if U-Boot is configured to use USB keyboards.
Signed-off-by: Thomas RIENOESSL thomas.rienoessl@bachmann.info Reviewed-by: Bin Meng bmeng.cn@gmail.com Signed-off-by: Bin Meng bmeng.cn@gmail.com
I totally forgot to send an updated version of this patch - thanks for doing this Bin!
Reviewed-by: Christian Gmeiner christian.gmeiner@gmail.com
applied to u-boot-x86, thanks!
participants (2)
-
Bin Meng -
Christian Gmeiner