[U-Boot] Converting serial_s3c24x0.c to driver model
Hi David,
I'm sorry if you have not heard about this before. I sent out an email to all maintainers some months ago.
You are listed as the maintainer of a few boards which use the serial_s3c24x0.c serial driver. We are trying to convert all of these drivers to driver model. Please see doc/driver-model/serial-howto.txt.
Do you have an update please?
Regards, Simon
Hello
Simon Glass wrote:
I'm sorry if you have not heard about this before. I sent out an email to all maintainers some months ago. You are listed as the maintainer of a few boards which use the serial_s3c24x0.c serial driver. We are trying to convert all of these drivers to driver model. Please see doc/driver-model/serial-howto.txt.
Do you have an update please?
Sorry, seems that I missed your previous message somehow.
Dave
Hi David,
On 2 February 2016 at 08:59, David Müller (ELSOFT AG) d.mueller@elsoft.ch wrote:
Hello
Simon Glass wrote:
I'm sorry if you have not heard about this before. I sent out an email to all maintainers some months ago. You are listed as the maintainer of a few boards which use the serial_s3c24x0.c serial driver. We are trying to convert all of these drivers to driver model. Please see doc/driver-model/serial-howto.txt.
Do you have an update please?
Sorry, seems that I missed your previous message somehow.
I'm sorry about that. - it was a cc to you in November. Are you planning to take a look at this?
Regards, Simon
Hello
While trying to convert the serial_s3c24x0.c driver to DM, I noticed that no offical U-Boot configuration seems to be using the CONFIG_MODEM_SUPPORT or CONFIG_HWFLOW option.
Do you know if these two options are still in use somewhere else? Or can all the references to these options be removed irrevocably?
git grep CONFIG_MODEM_SUPPORT | uniq
README: CONFIG_MODEM_SUPPORT arch/powerpc/cpu/mpc8xx/serial.c:#ifdef CONFIG_MODEM_SUPPORT common/Makefile:obj-$(CONFIG_MODEM_SUPPORT) += modem.o common/board_f.c:#ifdef CONFIG_MODEM_SUPPORT common/main.c:#ifdef CONFIG_MODEM_SUPPORT drivers/serial/serial_s3c24x0.c:#ifdef CONFIG_MODEM_SUPPORT include/asm-generic/global_data.h:#ifdef CONFIG_MODEM_SUPPORT
git grep CONFIG_HWFLOW | uniq
README: CONFIG_HWFLOW common/modem.c:#ifdef CONFIG_HWFLOW doc/README.Modem:UART driver supports it (see CONFIG_HWFLOW compile-time flag in drivers/serial/serial_imx.c:#ifdef CONFIG_HWFLOW drivers/serial/serial_s3c24x0.c:#ifdef CONFIG_HWFLOW
Dave
On Fri, Feb 05, 2016 at 11:59:17AM +0100, David Müller (ELSOFT AG) wrote:
Hello
While trying to convert the serial_s3c24x0.c driver to DM, I noticed that no offical U-Boot configuration seems to be using the CONFIG_MODEM_SUPPORT or CONFIG_HWFLOW option.
Do you know if these two options are still in use somewhere else? Or can all the references to these options be removed irrevocably?
I think all boards have been removed so yes, go ahead and drop the code as a pre-req patch to the DM work you're doing, thanks!
Dear David,
In message 56B48085.2050500@elsoft.ch you wrote:
While trying to convert the serial_s3c24x0.c driver to DM, I noticed that no offical U-Boot configuration seems to be using the CONFIG_MODEM_SUPPORT or CONFIG_HWFLOW option.
Do you know if these two options are still in use somewhere else? Or can all the references to these options be removed irrevocably?
IIRC the modem support was added more than a decade ago for a specific board which has been removed from the tree long ago. I cannot remember that any other user has questions or problems with that code, so probably nobody else ever used it.
I think chances are good that you can remove this stuff and nobody would ever notice ;-)
Best regards,
Wolfgang Denk
participants (4)
-
David Müller (ELSOFT AG) -
Simon Glass -
Tom Rini -
Wolfgang Denk