[U-Boot] [PATCH] ns16550: change to allow 32 bit access to registers

If CONFIG_SYS_NS16550_MEM32 is defined then 32 bit memory mapped access will be used to read/write the uart registers.
This is especially useful for SoC devices that implement 16550 compatible uarts but that have peripheral access width constraints.
Signed-off-by: Dave Aldridge fovsoft@gmail.com --- drivers/serial/ns16550.c | 3 +++ include/ns16550.h | 2 ++ 2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 8eeb48f..fbb7165 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -19,6 +19,9 @@ #ifdef CONFIG_SYS_NS16550_PORT_MAPPED #define serial_out(x,y) outb(x,(ulong)y) #define serial_in(y) inb((ulong)y) +#elif defined(CONFIG_SYS_NS16550_MEM32) +#define serial_out(x,y) writel(x,y) +#define serial_in(y) readl(y) #else #define serial_out(x,y) writeb(x,y) #define serial_in(y) readb(y) diff --git a/include/ns16550.h b/include/ns16550.h index 9ea81e9..d4ffac9 100644 --- a/include/ns16550.h +++ b/include/ns16550.h @@ -23,6 +23,8 @@
#if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == 0) #error "Please define NS16550 registers size." +#elif defined(CONFIG_SYS_NS16550_MEM32) +#define UART_REG(x) unsigned int x; #elif (CONFIG_SYS_NS16550_REG_SIZE > 0) #define UART_REG(x) \ unsigned char prepad_##x[CONFIG_SYS_NS16550_REG_SIZE - 1]; \

Dear Dave Aldridge,
In message 1313589281-9789-1-git-send-email-fovsoft@gmail.com you wrote:
If CONFIG_SYS_NS16550_MEM32 is defined then 32 bit memory mapped access will be used to read/write the uart registers.
This is especially useful for SoC devices that implement 16550 compatible uarts but that have peripheral access width constraints.
Signed-off-by: Dave Aldridge fovsoft@gmail.com
drivers/serial/ns16550.c | 3 +++ include/ns16550.h | 2 ++ 2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 8eeb48f..fbb7165 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -19,6 +19,9 @@ #ifdef CONFIG_SYS_NS16550_PORT_MAPPED #define serial_out(x,y) outb(x,(ulong)y) #define serial_in(y) inb((ulong)y) +#elif defined(CONFIG_SYS_NS16550_MEM32) +#define serial_out(x,y) writel(x,y) +#define serial_in(y) readl(y)
Don't we have to consider endianess issues here?
Best regards,
Wolfgang Denk
participants (2)
-
Dave Aldridge
-
Wolfgang Denk