[U-Boot] [PATCH] Fix compile issue
Fixes this compile error: board.c: In function 'do_switch_ecc': board.c:339: error: 'cmd_tbl_t' has no member named 'help' make[1]: *** [board.o] Error 1 make[1]: Leaving directory `/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3' make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2
Signed-off-by: Sanjeev Premi premi@ti.com --- cpu/arm_cortexa8/omap3/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c index 7bb3e28..15ea936 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) return 0;
usage: - printf ("Usage: nandecc %s\n", cmdtp->help); + printf ("Usage: nandecc %s\n", cmdtp->usage); return 1; }
On Thursday 02 April 2009 12:21:54 Sanjeev Premi wrote:
cpu/arm_cortexa8/omap3/board.c | 2 +-
you're fixing a specific board or board family, so please put that into the subject line. "Fix compile issue" might be ok if it were an error in the top level build files, but this isnt ... -mike
On 12:59 Thu 02 Apr , Mike Frysinger wrote:
On Thursday 02 April 2009 12:21:54 Sanjeev Premi wrote:
cpu/arm_cortexa8/omap3/board.c | 2 +-
you're fixing a specific board or board family, so please put that into the subject line. "Fix compile issue" might be ok if it were an error in the top level build files, but this isnt ...
please also add in your commit message that it's because the current command use the long help for usage print evenif when the CONFIG_SYS_LONGHELP is not active
Best Regards, J.
Sanjeev Premi wrote:
Fixes this compile error: board.c: In function 'do_switch_ecc': board.c:339: error: 'cmd_tbl_t' has no member named 'help' make[1]: *** [board.o] Error 1 make[1]: Leaving directory `/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3' make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2
How do you get this error (which U-Boot branch/git head)? It seems I don't have this with recent U-Boot mainline:
-- cut -- HEAD is now at dfc91c3... Merge branch 'master' of git://git.denx.de/u-boot-arm
./MAKEALL ARM_CORTEX_A8
Configuring for omap3_beagle board... text data bss dec hex filename 168317 8504 205616 382437 5d5e5 ./u-boot Configuring for omap3_overo board... text data bss dec hex filename 157161 8448 204936 370545 5a771 ./u-boot Configuring for omap3_evm board... text data bss dec hex filename 159957 6048 219032 385037 5e00d ./u-boot Configuring for omap3_pandora board... text data bss dec hex filename 157253 8368 204936 370557 5a77d ./u-boot Configuring for omap3_zoom1 board... text data bss dec hex filename 157905 8448 204936 371289 5aa59 ./u-boot -- cut --
Regards
Dirk
Signed-off-by: Sanjeev Premi premi@ti.com
cpu/arm_cortexa8/omap3/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c index 7bb3e28..15ea936 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) return 0;
usage:
- printf ("Usage: nandecc %s\n", cmdtp->help);
- printf ("Usage: nandecc %s\n", cmdtp->usage); return 1;
}
-----Original Message----- From: Dirk Behme [mailto:dirk.behme@googlemail.com] Sent: Thursday, April 02, 2009 11:48 PM To: Premi, Sanjeev Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] Fix compile issue
Sanjeev Premi wrote:
Fixes this compile error: board.c: In function 'do_switch_ecc': board.c:339: error: 'cmd_tbl_t' has no member named 'help' make[1]: *** [board.o] Error 1 make[1]: Leaving directory
`/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3'
make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2
How do you get this error (which U-Boot branch/git head)? It seems I don't have this with recent U-Boot mainline:
It doesn't come with my default configuration (omap3_evm_config). But when I tried to turn on/off few options for minimal uboot build, I came across this.
I am away from the actual code, but I believe it was after enabling #define CONFIG_NAND_OMAP_GPMC
Of course, it leads to another error - a missing function. But still haven't figured that one.
~sanjeev
-- cut -- HEAD is now at dfc91c3... Merge branch 'master' of git://git.denx.de/u-boot-arm
./MAKEALL ARM_CORTEX_A8
Configuring for omap3_beagle board... text data bss dec hex filename 168317 8504 205616 382437 5d5e5 ./u-boot Configuring for omap3_overo board... text data bss dec hex filename 157161 8448 204936 370545 5a771 ./u-boot Configuring for omap3_evm board... text data bss dec hex filename 159957 6048 219032 385037 5e00d ./u-boot Configuring for omap3_pandora board... text data bss dec hex filename 157253 8368 204936 370557 5a77d ./u-boot Configuring for omap3_zoom1 board... text data bss dec hex filename 157905 8448 204936 371289 5aa59 ./u-boot -- cut --
Regards
Dirk
Signed-off-by: Sanjeev Premi premi@ti.com
cpu/arm_cortexa8/omap3/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/arm_cortexa8/omap3/board.c
b/cpu/arm_cortexa8/omap3/board.c
index 7bb3e28..15ea936 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t *
cmdtp, int flag, int argc, char *argv[])
return 0;
usage:
- printf ("Usage: nandecc %s\n", cmdtp->help);
- printf ("Usage: nandecc %s\n", cmdtp->usage); return 1;
}
participants (5)
-
Dirk Behme -
Jean-Christophe PLAGNIOL-VILLARD -
Mike Frysinger -
Premi, Sanjeev -
Sanjeev Premi