[U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Serise-changes: 2 - Update commit from Jaehoon
Signed-off-by: Ziyuan Xu jk.kernel@gmail.com ---
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..beebc70 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
for (uclass_first_device(UCLASS_MMC, &dev); dev; - uclass_next_device(&dev)) { + uclass_next_device(&dev), first = false) { struct mmc *m = mmc_get_mmc_dev(dev);
if (!first) {
Hi Ziyuan,
On 07/19/2016 11:21 PM, Ziyuan Xu wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Right? "With latter"?
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Serise-changes: 2
- Update commit from Jaehoon
Could you add the Changelog to the below line?
Signed-off-by: Ziyuan Xu jk.kernel@gmail.com
Locate the Changelog at here.
Best Regards, Jaehoon Chung
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..beebc70 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
for (uclass_first_device(UCLASS_MMC, &dev); dev;
uclass_next_device(&dev)) {
uclass_next_device(&dev), first = false) {struct mmc *m = mmc_get_mmc_dev(dev);
if (!first) {
Hi Jaehoon,
Thanks for your catch, fix it in v3.
On 2016年07月21日 10:11, Jaehoon Chung wrote:
Hi Ziyuan,
On 07/19/2016 11:21 PM, Ziyuan Xu wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Right? "With latter"?
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Serise-changes: 2
- Update commit from Jaehoon
Could you add the Changelog to the below line?
Signed-off-by: Ziyuan Xu jk.kernel@gmail.com
Locate the Changelog at here.
Best Regards, Jaehoon Chung
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..beebc70 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
for (uclass_first_device(UCLASS_MMC, &dev); dev;
uclass_next_device(&dev)) {
uclass_next_device(&dev), first = false) {struct mmc *m = mmc_get_mmc_dev(dev);
if (!first) {
On 19 July 2016 at 08:21, Ziyuan Xu xzy.xu@rock-chips.com wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Serise-changes: 2
- Update commit from Jaehoon
Signed-off-by: Ziyuan Xu jk.kernel@gmail.com
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the bug fix.
Acked-by: Simon Glass sjg@chromium.org
Hi,
On 21 July 2016 at 21:21, Simon Glass sjg@chromium.org wrote:
On 19 July 2016 at 08:21, Ziyuan Xu xzy.xu@rock-chips.com wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Serise-changes: 2
- Update commit from Jaehoon
Signed-off-by: Ziyuan Xu jk.kernel@gmail.com
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the bug fix.
Acked-by: Simon Glass sjg@chromium.org
Please can you send a v2 with the nits fixed?
- Simon
Hi Simon,
On 2016年07月23日 10:57, Simon Glass wrote:
Hi,
On 21 July 2016 at 21:21, Simon Glass sjg@chromium.org wrote:
On 19 July 2016 at 08:21, Ziyuan Xu xzy.xu@rock-chips.com wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Serise-changes: 2
- Update commit from Jaehoon
Signed-off-by: Ziyuan Xu jk.kernel@gmail.com
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the bug fix.
Acked-by: Simon Glass sjg@chromium.org
Please can you send a v2 with the nits fixed?
Fixed, see v3.
- Simon
participants (3)
-
Jaehoon Chung -
Simon Glass -
Ziyuan Xu