notice the following, in which a number of config files for SH-related boards explicitly define the macro "CONFIG_SH":

$ grep -rw CONFIG_SH * common/cmd_bdinfo.c:#elif defined(CONFIG_SH) drivers/bios_emulator/include/x86emu.h:#elif defined (CONFIG_SH) drivers/net/sh_eth.h:#if defined(CONFIG_SH) drivers/net/sh_eth.h:#endif /* defined(CONFIG_SH) */ examples/standalone/stubs.c:#elif defined(CONFIG_SH) include/configs/MigoR.h:#define CONFIG_SH 1 include/configs/ms7722se.h:#define CONFIG_SH 1 include/configs/r0p7734.h:#define CONFIG_SH 1 include/configs/rsk7269.h:#define CONFIG_SH 1 include/configs/r2dplus.h:#define CONFIG_SH 1 include/configs/sh7785lcr.h:#define CONFIG_SH 1 include/configs/ms7720se.h:#define CONFIG_SH 1 include/configs/sh7752evb.h:#define CONFIG_SH 1 include/configs/ms7750se.h:#define CONFIG_SH 1 include/configs/shmin.h:#define CONFIG_SH 1 include/configs/sh7763rdp.h:#define CONFIG_SH 1 include/configs/ap325rxa.h:#define CONFIG_SH 1 include/configs/sh7757lcr.h:#define CONFIG_SH 1 include/configs/rsk7264.h:#define CONFIG_SH 1 include/configs/mpr2.h:#define CONFIG_SH 1 include/configs/ap_sh4a_4a.h:#define CONFIG_SH 1 include/configs/espt.h:#define CONFIG_SH 1 include/configs/r7780mp.h:#define CONFIG_SH 1 include/configs/ecovec.h:#define CONFIG_SH 1 include/configs/rsk7203.h:#define CONFIG_SH 1 $

which is fine -- it doesn't hurt -- but aren't all those define's superfluous since that macro will be defined via this:

arch/sh/config.mk:PLATFORM_CPPFLAGS += -DCONFIG_SH -D__SH__ ^^^^^^^^^^^

not suggesting they deserve immediate removal, just want to verify that my understanding is correct and that they're unnecessary. thanks.

rday