[U-Boot] [PATCH next] silence awk command display during build
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...
Signed-off-by: Kim Phillips kim.phillips@freescale.com --- applies to u-boot.git's next branch.
Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index 36f2e1e..50bbe08 100644 --- a/Makefile +++ b/Makefile @@ -495,7 +495,7 @@ unconfig:
sinclude .boards.depend .boards.depend: boards.cfg - awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@ + @awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@
# # Functions to generate common board directory names
On Monday, September 13, 2010 21:17:30 Kim Phillips wrote:
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg
.boards.depend Configuring for ve8313 board...
how about we change MAKEALL to run the config step with -s ? -mike
On Mon, 13 Sep 2010 21:59:21 -0400 Mike Frysinger vapier@gentoo.org wrote:
On Monday, September 13, 2010 21:17:30 Kim Phillips wrote:
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg
.boards.depend Configuring for ve8313 board...
how about we change MAKEALL to run the config step with -s ?
not sure how that relates to this patch...afaict, make board config, MAKEALL or non:
[u-boot next]$ make distclean && make ve8313_config Generating include/autoconf.mk Generating include/autoconf.mk.dep awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board... [u-boot next]$
..should be silent except for announcing what board its configuring.
Kim
On Tuesday, September 14, 2010 14:41:16 Kim Phillips wrote:
On Mon, 13 Sep 2010 21:59:21 -0400 Mike Frysinger wrote:
On Monday, September 13, 2010 21:17:30 Kim Phillips wrote:
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg
.boards.depend Configuring for ve8313 board...
how about we change MAKEALL to run the config step with -s ?
not sure how that relates to this patch...afaict, make board config, MAKEALL or non:
[u-boot next]$ make distclean && make ve8313_config Generating include/autoconf.mk Generating include/autoconf.mk.dep awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg
.boards.depend Configuring for ve8313 board...
[u-boot next]$
..should be silent except for announcing what board its configuring.
instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.
so to get back to your patch, if you want "pretty" MAKEALL output, change MAKEALL to call make with "-s". -mike
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...
Signed-off-by: Kim Phillips kim.phillips@freescale.com --- applies to u-boot.git's next branch.
MAKEALL | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAKEALL b/MAKEALL index 761038e..1b506d6 100755 --- a/MAKEALL +++ b/MAKEALL @@ -727,7 +727,7 @@ build_target() { target=$1
${MAKE} distclean >/dev/null - ${MAKE} ${target}_config + ${MAKE} -s ${target}_config
${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \ | tee ${LOG_DIR}/$target.ERR
On Tuesday, September 14, 2010 15:48:16 Kim Phillips wrote:
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg
.boards.depend Configuring for ve8313 board...
Signed-off-by: Kim Phillips kim.phillips@freescale.com
Acked-by: Mike Frysinger vapier@gentoo.org -mike
Dear Kim Phillips,
In message 20100914144816.177602d5.kim.phillips@freescale.com you wrote:
[u-boot next]$ ./MAKEALL 83xx awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for ve8313 board...
Signed-off-by: Kim Phillips kim.phillips@freescale.com
applies to u-boot.git's next branch.
MAKEALL | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to "next" branch, thanks.
Best regards,
Wolfgang Denk
Dear Mike Frysinger,
In message 201009141525.05345.vapier@gentoo.org you wrote:
instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.
I do. It is a change in behaviour and potentially braks a number of build systems.
Please let's fix this so the previous behaviour is restored.
On Tuesday, September 14, 2010 18:04:29 Wolfgang Denk wrote:
Mike Frysinger wrote:
instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.
I do. It is a change in behaviour and potentially braks a number of build systems.
as Kim highlighted, this has already been "broken" somewhat by other commits as sometimes output can be shown before the config line. so if it was breaking people, wouldnt they have complained by now ? -mike
On Tue, 14 Sep 2010 22:09:58 -0400 Mike Frysinger vapier@gentoo.org wrote:
On Tuesday, September 14, 2010 18:04:29 Wolfgang Denk wrote:
Mike Frysinger wrote:
instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.
I do. It is a change in behaviour and potentially braks a number of build systems.
as Kim highlighted, this has already been "broken" somewhat by other commits as sometimes output can be shown before the config line. so if it was
what commits? awk is the only command in the area that isn't silenced in make. wrt the output...I believe that was distclean speaking..make config only emits "configuring for blah.."
breaking people, wouldnt they have complained by now ?
both the MAKEALL and make blah_config behaviour have changed since:
commit 866b5619fbc15db8a88954961bbc371c2c9c8b86 Author: Mike Frysinger vapier@gentoo.org Date: Wed Aug 11 18:52:36 2010 -0400
Makefile: restore support for board shortcut targets
I was originally confused because build verbosity is has a reversed sense in u-boot (make is by default noisy, needs silencing vs. linux' make is by default 'neat', needs verbosity flag set to be noisy), but I tend to agree with WD on this one. Else, e.g., why isn't the mkconfig invocation noisy?
Anyway, for backward noise compatible operation, the 1st patch in this thread should be applied.
Kim
On Wednesday, September 15, 2010 12:12:32 Kim Phillips wrote:
On Tue, 14 Sep 2010 22:09:58 -0400
Mike Frysinger vapier@gentoo.org wrote:
On Tuesday, September 14, 2010 18:04:29 Wolfgang Denk wrote:
Mike Frysinger wrote:
instead of silencing a somewhat complicated command that could break the build system if it goes wrong, use the mechanisms already in place if you want nice & concise output -- the --silent option to make. i dont see a problem with this output you've quoted in the normal run of things.
I do. It is a change in behaviour and potentially braks a number of build systems.
as Kim highlighted, this has already been "broken" somewhat by other commits as sometimes output can be shown before the config line. so if it was
what commits? awk is the only command in the area that isn't silenced in make. wrt the output...I believe that was distclean speaking..make config only emits "configuring for blah.."
it is not tied strictly to disclean. run config targets multiple times and see the same thing. `make ve8313; make ve8313`.
breaking people, wouldnt they have complained by now ?
both the MAKEALL and make blah_config behaviour have changed since:
behavior changed !== breakage
I was originally confused because build verbosity is has a reversed sense in u-boot (make is by default noisy, needs silencing vs. linux' make is by default 'neat', needs verbosity flag set to be noisy), but I tend to agree with WD on this one. Else, e.g., why isn't the mkconfig invocation noisy?
yes, the current behavior is pretty squirrelly imo -mike
Dear Mike Frysinger,
In message 201009151514.48147.vapier@gentoo.org you wrote:
breaking people, wouldnt they have complained by now ?
Eventually they don't complain because they did not use this feature (yet).
both the MAKEALL and make blah_config behaviour have changed since:
behavior changed !== breakage
OK.
Please undo that behaviour change anyway.
Best regards,
Wolfgang Denk
On Wednesday, September 15, 2010 15:28:58 Wolfgang Denk wrote:
Mike Frysinger wrote:
both the MAKEALL and make blah_config behaviour have changed since:
behavior changed !== breakage
OK.
Please undo that behaviour change anyway.
i dont really want this to be completely silenced all the time. introduce a variable to prefix things with for people to control ? Q_BUILD = @ ... $(Q_BUILD)..... -mike
Dear Mike Frysinger,
In message 201009151620.05329.vapier@gentoo.org you wrote:
i dont really want this to be completely silenced all the time. introduce a variable to prefix things with for people to control ? Q_BUILD = @ ... $(Q_BUILD).....
NAK. Please do not add such mess to the Makefile. It does not belong there. If you want such behaviour, it should be added to the make command itself.
I repeat myself, but all this cmd_* / quiet_cmd_* stuff etc. we see in the Linux kernel Makefiles (and copied around into a zillion of other projects) does not belong to the Makefile; it should be implemented inside make itself.
I never understood why nobody bothered to solve the problem at the root.
Best regards,
Wolfgang Denk
On Wednesday, September 15, 2010 17:25:25 Wolfgang Denk wrote:
Mike Frysinger wrote:
i dont really want this to be completely silenced all the time. introduce a variable to prefix things with for people to control ? Q_BUILD = @ ...
$(Q_BUILD).....
NAK. Please do not add such mess to the Makefile. It does not belong there. If you want such behaviour, it should be added to the make command itself.
funny, i could say the same exact thing about "quiet" config output. make already has an option to accomplish exactly that: use the --silent option. i dont see why you would ban pretty output in favor of using standard make options while at the same exact time you want to change u-boot's make code so that it produces pretty output instead of using standard make options that already exist.
how are these situations any different ? -mike
participants (3)
-
Kim Phillips -
Mike Frysinger -
Wolfgang Denk