[U-Boot] lcd_putc bug?
In the lcd_putc() of common/lcd.c, line 189 handles tab '\t'. And the following lines: console_col |= 8; console_col &= ~7; seems to have problems. If console_col is 9, it will become 8 after the above two lines, which means instead of tab of 8 spaces, it goes back 1. Is this intentional or a bug?
I think it should be console_col += 8; instead of console_col |= 8;
Derek
Dear Derek Ou,
In message 49889076.5010509@siconix.com you wrote:
In the lcd_putc() of common/lcd.c, line 189 handles tab '\t'. And the following lines: console_col |= 8; console_col &= ~7; seems to have problems. If console_col is 9, it will become 8 after the above two lines, which means instead of tab of 8 spaces, it goes back
- Is this intentional or a bug?
I think it should be console_col += 8; instead of console_col |= 8;
I think you are right - can you please submit a patch?
Best regards,
Wolfgang Denk
participants (2)
-
Derek Ou -
Wolfgang Denk